From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4E27CD1284 for ; Tue, 9 Apr 2024 08:53:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HkcEa9ifa5HfEffY9cnMQlnGe59pLWfB/OawJF+lne4=; b=BJSL+O7Xl2Fwss Kc8XbzgRVwuzLSLXQVtwfGKPJWNEFBNC5AzL0QXUDnK8SQwFQuOAPKyp4jHbKOjrRXoJDZhbkhabX gnLCqDQO94kPpAeA+0t2y7CtJD8AGe+8hndFqP0zANFa/ERVzVW5mlg/1aNjM3fFm800KNna0rfCf LHnsEMu4ANZQRpLUM32G9IxD+B1fMMo7GErcXx5Vm+Puxc6EakhBWv0gvDFaZk8xOmr+9l9rtfTV+ q61IyJ63DmEOG8H+UNU6LHO1GwG/XdYAhfxiPf0hNUM+NraWCsVcDG5BcfzqvVZQ0eVOHUaVVocHm eW2Hjo3M2PgnuqX2vZjw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru7E7-000000015BC-05aS; Tue, 09 Apr 2024 08:53:11 +0000 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru7Dz-00000001595-3if5 for linux-arm-kernel@lists.infradead.org; Tue, 09 Apr 2024 08:53:07 +0000 Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-a51b008b3aeso365510666b.3 for ; Tue, 09 Apr 2024 01:52:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712652777; x=1713257577; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=a0jIR2OL0GyuZ7AB0nPnmYn4Ft44qzFta5fRUBXkOno=; b=Jen4dzZ2pIbrmw8wp/eKNNnmO+591SiQpLVbKqZDAp22mcy8xoXOCTvVixwumsAbmc wSJeomodJw419iTyUB6wM4KxfygLnVrsOIcKSNsZxiuZFHxHGA93gM9qoV5Ya5MU4Acn n0jOdstXraRpSxzYJYRFH3vMkokBdrDOk4Kyy5az4n13vqDlFENK8AMtMhIi2FiE/uju Ac+qAesSHK+HeFBJro+p5wHduAU674FO7HRVS8ZnLZoTVLV7+FNT04fOLPH8ZUQpoZvP rMKf9+g63sPI3GcltQ8Iqe5tKKjq4Eh7FV+YLhBp1dZm3Fvix2AuumO7zsrK3JKtbqQi hdiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712652777; x=1713257577; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=a0jIR2OL0GyuZ7AB0nPnmYn4Ft44qzFta5fRUBXkOno=; b=KLhFHHiX4kdSeUn/Rp0NQPE18sA0h7LeehQGJziLB97ATbmYkaJXf9mS/XQaJZehf9 3y2DFjlvSCb3O/NsmgYnV4zGpmn7fnUF7vaG7/0t6Rj/l/Ul7smfL/ptNOZiCFkcs3/Z Yr30cQNaWwfcy5byl1bWD+Q/qhmioLSJNdm7ToHr26NA11yCjF7ZZCmZbMREo3iNo3B5 xS0kBQAkq8ymDyNwr3eJ561SoQmJRAqv1vvYb8alNPg/u4USyqOeSVQRzOnnh4jJuuhv JwYD629Dc+koZl4u2wHoVdqlFL1ahe+7TqqwYJ/gQRFO8P6BpoG3ljiN9lS4TqiYx+cz 7Aug== X-Forwarded-Encrypted: i=1; AJvYcCXdXXJAkDY1bOPvIPAiTvdRcUvEDazbAieZOENIpZ1C/a1gZ14bwzd9tNVpMCPxQ/FgvZyTmXN9Wg3eRTe4OKOUVHrfdnh2s/McLdLYR31W7WiylQs= X-Gm-Message-State: AOJu0YyREub7zmONz7k49L47xzsroPcBF8p8qDtWNFSctB2e5RNYkXCI MJFv0iPPvmv6BS5tWVwcHqwQEJlnNEY08fF3/ITmDAkWEoQJHHNy X-Google-Smtp-Source: AGHT+IEAFHw1NjWQVbVzBzYATvddUlqkzBcIRzHxlgvPpMiPiCZOtlevHR5EjAtm+ZEjmL4iwtsgFA== X-Received: by 2002:a17:906:6c97:b0:a51:88e5:5451 with SMTP id s23-20020a1709066c9700b00a5188e55451mr5956856ejr.29.1712652777110; Tue, 09 Apr 2024 01:52:57 -0700 (PDT) Received: from [192.168.0.31] (84-115-213-64.cable.dynamic.surfer.at. [84.115.213.64]) by smtp.gmail.com with ESMTPSA id ak2-20020a170906888200b00a51dccd16d9sm1836588ejc.99.2024.04.09.01.52.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Apr 2024 01:52:56 -0700 (PDT) Message-ID: <6dc808bf-682f-4e91-aac7-7ce6f05a0ab4@gmail.com> Date: Tue, 9 Apr 2024 10:52:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/9] dt-bindings: rtc: lpc32xx-rtc: move to trivial-rtc To: Krzysztof Kozlowski , Alexandre Belloni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jiaxun Yang , Vladimir Zapolskiy , Joel Stanley , Andrew Jeffery , Maxime Coquelin , Alexandre Torgue Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-stm32@st-md-mailman.stormreply.com References: <20240408-rtc_dtschema-v1-0-c447542fc362@gmail.com> <20240408-rtc_dtschema-v1-3-c447542fc362@gmail.com> Content-Language: en-US, de-AT From: Javier Carrasco In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240409_015306_304237_A1D0F6EE X-CRM114-Status: GOOD ( 21.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/9/24 09:34, Krzysztof Kozlowski wrote: > On 08/04/2024 17:53, Javier Carrasco wrote: >> This RTC requires a compatible, a reg and a single interrupt, >> which makes it suitable for a direct conversion into trivial-rtc. >> >> Signed-off-by: Javier Carrasco >> --- >> Documentation/devicetree/bindings/rtc/lpc32xx-rtc.txt | 15 --------------- >> Documentation/devicetree/bindings/rtc/trivial-rtc.yaml | 2 ++ >> 2 files changed, 2 insertions(+), 15 deletions(-) > > This one no... and if you tested DTS you would see errors, although you > need to test specific lpc config, not multi_v7. > > It does not look like you tested the DTS against bindings. Please run > `make dtbs_check W=1` (see > Documentation/devicetree/bindings/writing-schema.rst or > https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ > for instructions). > > Anyway, you *must* check all DTS before moving anything to trivial. > > Does it mean all other bindings were not checked against DTS at all? > > Best regards, > Krzysztof > Hi, I did check the conversion against nxp/lpc/lpc3250-phy3250.dts, which throws a message about the 'clocks' property. That property is not documented in the original binding, and even though it could be missing, I could not find any function to get a clock (i.e. any form of clk_get()) in rtc-lpc32xx.c, which is the only file where the compatible can be found. Is therefore the property not useless in the dts? My apologies if I am missing something here. Thanks and best regards, Javier Carrasco _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel