From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD63AF327C2 for ; Tue, 21 Apr 2026 08:51:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:References:Cc:To:From:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Kyt6VajlrdyjJahDEeBmIcUrxewyqbhvFLuqH332Q3k=; b=KMM4ezYqc+qKCJuXvjuJrFV/gX N1UsBxSinEIIB7OBZ5lCEeiP8ufOYTXuZvacs8ts9lu9HXs60C1aY/8FIpwJVuXFF6RvPHX2rAIhl gOkmuKtvj2Mtsnladi9UCtznHdniTb6FhHrUMw4UcIh8naAVfiGh7Qmt2OxGCG18ebzWCbHcA275M Ur9C9ukGx4pqqNjaoFYzsLBIliRqaMxyW1shl/oviFzU2+6Pf+Z1k/LDTNfoJwskdgD+uE7TfDOsb lauIWzedh3NcoywhFeB4OCkaxhfajr47SatmyOACQuHdqqzYnX5HNocQcDgw9WBu/TzOtUe/CFZxZ FbpFvx0w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wF6oy-00000008HHK-0dDj; Tue, 21 Apr 2026 08:51:04 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wF6ov-00000008HGZ-43Xi for linux-arm-kernel@lists.infradead.org; Tue, 21 Apr 2026 08:51:03 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C9C6625E0; Tue, 21 Apr 2026 01:50:54 -0700 (PDT) Received: from [10.57.17.241] (unknown [10.57.17.241]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C6C433F915; Tue, 21 Apr 2026 01:50:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1776761460; bh=bnoP5YNr4DMDkrY0kSZkQ7sNqqURlVJaylvyCZaTk7Y=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=stJIgZ23FrBqf0a2lHiIC1Hoh/aJV3ZwmPS/N5ncEOZTsdTUTLTPebM1MPu9+p+y7 V5oUsp7pIC3Rzc8cCtucTZw0dF4kWLJOpHIDOLqLmv1Zk5lDco50V5lryxsfRrrmmi 2NljbEAoMm0nfHoZh0sK9/+s3mSI2lMR7HRrUlvc= Message-ID: <6dcb14c1-0759-4f2a-8bbc-b85adf3d12f4@arm.com> Date: Tue, 21 Apr 2026 09:50:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 02/12] coresight: etm4x: fix underflow for nrseqstate Content-Language: en-GB From: Suzuki K Poulose To: Leo Yan , Yeoreum Yun Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, mike.leach@arm.com, james.clark@linaro.org, alexander.shishkin@linux.intel.com, jie.gan@oss.qualcomm.com References: <20260415165528.3369607-1-yeoreum.yun@arm.com> <20260415165528.3369607-3-yeoreum.yun@arm.com> <20260416151102.GL356832@e132581.arm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260421_015102_039844_0566A5DB X-CRM114-Status: GOOD ( 12.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21/04/2026 09:50, Suzuki K Poulose wrote: > On 16/04/2026 16:11, Leo Yan wrote: >> On Wed, Apr 15, 2026 at 05:55:18PM +0100, Yeoreum Yun wrote: >>> TCRSEQEVR is implemented only when TCRIDR5.NUMSEQSTATE is 0b100, >>> in which case n ranges from 0 to 2; otherwise, TCRIDR5.NUMSEQSTATE is >>> 0b000. >> >> My suggestion in previous version is not quite right, thanks for >> making this correct. >> >> [...] >> >>> @@ -1395,6 +1395,8 @@ static ssize_t seq_idx_store(struct device *dev, >>>       struct etmv4_drvdata *drvdata = dev_get_drvdata(dev->parent); >>>       struct etmv4_config *config = &drvdata->config; >>> +    if (!drvdata->nrseqstate) >>> +        return -EINVAL; >> >> For "nrseqstate = 0" case, would it return -EOPNOTSUPP instead? > > Or should we make this only visible if the nrseqstore is meaningful ? > > Suzuki > >> >> Otherwise, LGTM: >> >> Reviewed-by: Leo Yan > Also, please add Fixes: tag for these bug fixes