[PATCH] ARM: dts: socfpga: arria10: add aliases for ethernet

[PATCH] ARM: dts: socfpga: arria10: add aliases for ethernet

[Steffen Trumtrar]

The stmmac driver uses the alias id to enumerate multiple ethernet devices.
Add the aliases for ethernet, so multiple ethernet ports can be enabled
without errors.

Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
---
 arch/arm/boot/dts/socfpga_arria10.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/socfpga_arria10.dtsi b/arch/arm/boot/dts/socfpga_arria10.dtsi
index a4dcb68f4322..9d490f907c98 100644
--- a/arch/arm/boot/dts/socfpga_arria10.dtsi
+++ b/arch/arm/boot/dts/socfpga_arria10.dtsi
@@ -21,6 +21,13 @@
 	#address-cells = <1>;
 	#size-cells = <1>;
 
+	aliases {
+		ethernet0 = &gmac0;
+		ethernet1 = &gmac1;
+		ethernet2 = &gmac2;
+	};
+
+
 	cpus {
 		#address-cells = <1>;
 		#size-cells = <0>;
-- 
2.19.0

[PATCH] ARM: dts: socfpga: arria10: add aliases for ethernet

[Dinh Nguyen]

On 09/28/2018 07:16 AM, Steffen Trumtrar wrote:
> The stmmac driver uses the alias id to enumerate multiple ethernet devices.
> Add the aliases for ethernet, so multiple ethernet ports can be enabled
> without errors.
> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
>  arch/arm/boot/dts/socfpga_arria10.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 

Applied, thanks!

Dinh

[PATCH] ARM: dts: socfpga: arria10: add aliases for ethernet

[Dinh Nguyen]

On 09/28/2018 10:47 AM, Dinh Nguyen wrote:
> 
> 
> On 09/28/2018 07:16 AM, Steffen Trumtrar wrote:
>> The stmmac driver uses the alias id to enumerate multiple ethernet devices.
>> Add the aliases for ethernet, so multiple ethernet ports can be enabled
>> without errors.
>>
>> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
>> ---
>>  arch/arm/boot/dts/socfpga_arria10.dtsi | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
> 
> Applied, thanks!

I don't think we can add these ethernet aliases to the base arria10 dtsi
file. The reason is that different boards may elect to use other gmacs
instead of gmac0.

Do you agree?

Dinh

[PATCH] ARM: dts: socfpga: arria10: add aliases for ethernet

[Steffen Trumtrar]

Dinh Nguyen <dinguyen@kernel.org> writes:

> On 09/28/2018 10:47 AM, Dinh Nguyen wrote:
>> 
>> 
>> On 09/28/2018 07:16 AM, Steffen Trumtrar wrote:
>>> The stmmac driver uses the alias id to enumerate multiple 
>>> ethernet devices.
>>> Add the aliases for ethernet, so multiple ethernet ports can 
>>> be enabled
>>> without errors.
>>>
>>> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
>>> ---
>>>  arch/arm/boot/dts/socfpga_arria10.dtsi | 7 +++++++
>>>  1 file changed, 7 insertions(+)
>>>
>> 
>> Applied, thanks!
>
> I don't think we can add these ethernet aliases to the base 
> arria10 dtsi
> file. The reason is that different boards may elect to use other 
> gmacs
> instead of gmac0.
>
> Do you agree?
>

Ack. I was following socfpga.dtsi, but I'm going to fix it instead 
of following it ;-)

Steffen

-- 
Pengutronix e.K.                          | Steffen Trumtrar 
|
Industrial Linux Solutions                | 
http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany| Phone: 
+49-5121-206917-0   |
Amtsgericht Hildesheim, HRA 2686          | Fax: 
+49-5121-206917-5555|