* [PATCH] ARM: dts: socfpga: arria10: add aliases for ethernet
@ 2018-09-28 12:16 Steffen Trumtrar
2018-09-28 15:47 ` Dinh Nguyen
0 siblings, 1 reply; 4+ messages in thread
From: Steffen Trumtrar @ 2018-09-28 12:16 UTC (permalink / raw)
To: linux-arm-kernel
The stmmac driver uses the alias id to enumerate multiple ethernet devices.
Add the aliases for ethernet, so multiple ethernet ports can be enabled
without errors.
Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
---
arch/arm/boot/dts/socfpga_arria10.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/boot/dts/socfpga_arria10.dtsi b/arch/arm/boot/dts/socfpga_arria10.dtsi
index a4dcb68f4322..9d490f907c98 100644
--- a/arch/arm/boot/dts/socfpga_arria10.dtsi
+++ b/arch/arm/boot/dts/socfpga_arria10.dtsi
@@ -21,6 +21,13 @@
#address-cells = <1>;
#size-cells = <1>;
+ aliases {
+ ethernet0 = &gmac0;
+ ethernet1 = &gmac1;
+ ethernet2 = &gmac2;
+ };
+
+
cpus {
#address-cells = <1>;
#size-cells = <0>;
--
2.19.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ARM: dts: socfpga: arria10: add aliases for ethernet
2018-09-28 12:16 [PATCH] ARM: dts: socfpga: arria10: add aliases for ethernet Steffen Trumtrar
@ 2018-09-28 15:47 ` Dinh Nguyen
2018-10-04 14:33 ` Dinh Nguyen
0 siblings, 1 reply; 4+ messages in thread
From: Dinh Nguyen @ 2018-09-28 15:47 UTC (permalink / raw)
To: linux-arm-kernel
On 09/28/2018 07:16 AM, Steffen Trumtrar wrote:
> The stmmac driver uses the alias id to enumerate multiple ethernet devices.
> Add the aliases for ethernet, so multiple ethernet ports can be enabled
> without errors.
>
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
> arch/arm/boot/dts/socfpga_arria10.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
Applied, thanks!
Dinh
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: dts: socfpga: arria10: add aliases for ethernet
2018-09-28 15:47 ` Dinh Nguyen
@ 2018-10-04 14:33 ` Dinh Nguyen
2018-10-08 9:10 ` Steffen Trumtrar
0 siblings, 1 reply; 4+ messages in thread
From: Dinh Nguyen @ 2018-10-04 14:33 UTC (permalink / raw)
To: linux-arm-kernel
On 09/28/2018 10:47 AM, Dinh Nguyen wrote:
>
>
> On 09/28/2018 07:16 AM, Steffen Trumtrar wrote:
>> The stmmac driver uses the alias id to enumerate multiple ethernet devices.
>> Add the aliases for ethernet, so multiple ethernet ports can be enabled
>> without errors.
>>
>> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
>> ---
>> arch/arm/boot/dts/socfpga_arria10.dtsi | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>
> Applied, thanks!
I don't think we can add these ethernet aliases to the base arria10 dtsi
file. The reason is that different boards may elect to use other gmacs
instead of gmac0.
Do you agree?
Dinh
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: dts: socfpga: arria10: add aliases for ethernet
2018-10-04 14:33 ` Dinh Nguyen
@ 2018-10-08 9:10 ` Steffen Trumtrar
0 siblings, 0 replies; 4+ messages in thread
From: Steffen Trumtrar @ 2018-10-08 9:10 UTC (permalink / raw)
To: linux-arm-kernel
Dinh Nguyen <dinguyen@kernel.org> writes:
> On 09/28/2018 10:47 AM, Dinh Nguyen wrote:
>>
>>
>> On 09/28/2018 07:16 AM, Steffen Trumtrar wrote:
>>> The stmmac driver uses the alias id to enumerate multiple
>>> ethernet devices.
>>> Add the aliases for ethernet, so multiple ethernet ports can
>>> be enabled
>>> without errors.
>>>
>>> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
>>> ---
>>> arch/arm/boot/dts/socfpga_arria10.dtsi | 7 +++++++
>>> 1 file changed, 7 insertions(+)
>>>
>>
>> Applied, thanks!
>
> I don't think we can add these ethernet aliases to the base
> arria10 dtsi
> file. The reason is that different boards may elect to use other
> gmacs
> instead of gmac0.
>
> Do you agree?
>
Ack. I was following socfpga.dtsi, but I'm going to fix it instead
of following it ;-)
Steffen
--
Pengutronix e.K. | Steffen Trumtrar
|
Industrial Linux Solutions |
http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany| Phone:
+49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax:
+49-5121-206917-5555|
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-08 9:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-28 12:16 [PATCH] ARM: dts: socfpga: arria10: add aliases for ethernet Steffen Trumtrar
2018-09-28 15:47 ` Dinh Nguyen
2018-10-04 14:33 ` Dinh Nguyen
2018-10-08 9:10 ` Steffen Trumtrar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).