linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Yz.Wu@mediatek.com,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	 Rob Herring <robh+dt@kernel.org>
Cc: Seiya Wang <seiya.wang@mediatek.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
	Andrew-CT Chen <andrew-ct.chen@mediatek.com>
Subject: Re: [PATCH v4 2/2] arm64: dts: mt8192: add eFuse support for MT8192 SoC
Date: Tue, 30 Mar 2021 10:40:06 +0200	[thread overview]
Message-ID: <6dd478f3-d29e-0583-00fd-dc85d5a3a4ff@gmail.com> (raw)
In-Reply-To: <1612151986-19820-3-git-send-email-Yz.Wu@mediatek.com>



On 01/02/2021 04:59, Yz.Wu@mediatek.com wrote:
> From: Ryan Wu <Yz.Wu@mediatek.com>
> 
> Add eFuse node to read Mediatek eFuse
> 
> Signed-off-by: Ryan Wu <Yz.Wu@mediatek.com>
> ---
> This patch dependents on "arm64: dts: Add Mediatek SoC MT8192 and evaluation board dts and Makefile"[1]
> 
> mt8192.dtsi file is needed for this patch.
> Please also accept this patch together with [1].
> 
> [1]http://lists.infradead.org/pipermail/linux-mediatek/2020-November/019378.html
> ---
>  arch/arm64/boot/dts/mediatek/mt8192.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> index 69d45c7..4a0d941 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> @@ -422,6 +422,11 @@
>  			#clock-cells = <1>;
>  		};
>  
> +		efuse: efuse@11c10000 {
> +			compatible = "mediatek,mt8192-efuse",
> +				     "mediatek,efuse";

We are missing
#address-cells = <1>;
#size-cells = <1>;

Regards,
Matthias

> +		};
> +
>  		i2c3: i2c3@11cb0000 {
>  			compatible = "mediatek,mt8192-i2c";
>  			reg = <0 0x11cb0000 0 0x1000>,
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      reply	other threads:[~2021-03-30  8:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-01  3:59 [PATCH v4 0/2] Add Mediatek Efuse Device Node for MT8192 SoC Yz.Wu
2021-02-01  3:59 ` [PATCH v4 1/2] dt-bindings: nvmem: mediatek: add support for MediaTek mt8192 SoC Yz.Wu
2021-02-09 20:41   ` Rob Herring
2021-03-30  8:42   ` Matthias Brugger
2021-02-01  3:59 ` [PATCH v4 2/2] arm64: dts: mt8192: add eFuse support for MT8192 SoC Yz.Wu
2021-03-30  8:40   ` Matthias Brugger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6dd478f3-d29e-0583-00fd-dc85d5a3a4ff@gmail.com \
    --to=matthias.bgg@gmail.com \
    --cc=Yz.Wu@mediatek.com \
    --cc=andrew-ct.chen@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=seiya.wang@mediatek.com \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).