From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A49FC636D6 for ; Thu, 23 Feb 2023 18:13:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g9dLdMBvWwgnhyuftY+XtGgDDj8znTyFQc68l+Fiuj0=; b=IiH7cvmsbHM6DJ AX/szFf6pKedck9DcRZEQRnigckO16LxmhVo9A8hRkZ4kqcqRuNaDMAf45zdFb9hU6oDGVfT3Z4fI gEpqJyYBWPRX+yww60RKATcefo7H7hogSE8EHOdFS0OYPgmLPZNgoxA3ev+lNsYYifalAjqgTWCty 85wAt+LrJ2YltK4q+liJYq6oUPWd5CzUmEm9alAG/NF3+jNqbn4DbEnBUXqiGWsqHzeQWLruuKoGo pTWi4G+WAWoZYz0z4nUJ/LoMJ4nmGTDdyLrYESp/cC0kykbt0Zn+EV5Mwo16++cEfGekLsqk8UUxm vrMFA4mZdOFxAmrMNLIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pVG4y-00HTEP-Kd; Thu, 23 Feb 2023 18:12:28 +0000 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pVG4v-00HTCf-Da for linux-arm-kernel@lists.infradead.org; Thu, 23 Feb 2023 18:12:26 +0000 Received: by mail-ed1-x52e.google.com with SMTP id h16so45516223edz.10 for ; Thu, 23 Feb 2023 10:12:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+XcNcjTbGilqBFvSaP95ds+AOY0Sg3ycWjre6wkeObA=; b=vgTBIVEy5TmD7m/Nin7C3TEn+OkXdt/iTICubDVjjr7vgx8mJNAwWkyk8CdTzKGoxw 62Pc4ghtUJmbrccf791CV/wmpWuK7Tma/NbVNV4Zg2dOLWrd0gMNB4O/i0FwPqFSzG3C 2tcnB7KtfVMa+kYzWEFhGNAkEJtNmS/QXCDreDM9pjeJxEIJIAcegEjKBOQJXDBQx/34 JLk514sQBQcsAs7YpCjNm4NzvBSAhKTLK5EcQkzXIW+sEtkiJk1Ru1d+Rjx5uNxiKIkS 84SrX1A+QeTPFj28+VNrvRZNzBO7j5cD3IKWQPy5FDewbUEkMDOriFiWUB5YUM8C5qoQ 6U5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+XcNcjTbGilqBFvSaP95ds+AOY0Sg3ycWjre6wkeObA=; b=3BLekb8J9bvG6i1wvF2zoHfbms8Am6L57TkZYYG+UJ+JkFUKn9285Zq7xa49ty6s17 pWsIVXQ0ns17iq0k+wSgHp78MOmKmKzBXuHWJ8dC3li0PNsE+tbobBRxRyrprDTAu6hb cVj6RdexYJOwD08Mns/3PMY2c4cSSIFBvXWY7VDmh+kQUOz0hlHUL9gwHT3RiqArSE2a 8V2mKp395BsNtjjkEE0LpBQL3eWdR0hweqJvZf6B2SMRvMdZzouZn2fBPBZTTokRELhU /xti6gFeiRg/lVypTRMyGGW91MNglC13XLeDp+kMB2Bw2dnrfSKYhfiYflvyCuP/wVij IwRw== X-Gm-Message-State: AO0yUKVMJNYEAY5mMRhIiWLFhjnQhXm14ndR2BtIZ/ldykfG2e5rSQDp 087UT0vbi13Mdh1/+i9z0rWwPw== X-Google-Smtp-Source: AK7set/0TI9/IGIRPb7wNuaey7VzvLJXk2ZeAmp0C8JDikvIw28X7Dd+4ZC8Bot5PtmWvbcilYfCsA== X-Received: by 2002:a05:6402:8d0:b0:4ac:be7c:4bf9 with SMTP id d16-20020a05640208d000b004acbe7c4bf9mr11858209edz.10.1677175939608; Thu, 23 Feb 2023 10:12:19 -0800 (PST) Received: from [192.168.1.20] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id u23-20020a50d517000000b004acdf09027esm5360874edi.4.2023.02.23.10.12.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Feb 2023 10:12:19 -0800 (PST) Message-ID: <6dfde695-16d5-57ac-fbdd-b86ec91322a9@linaro.org> Date: Thu, 23 Feb 2023 19:12:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 4/7] dt-bindings: PCI: dwc: add DMA, region mask bits Content-Language: en-US To: Elad Nachman , thomas.petazzoni@bootlin.com, bhelgaas@google.com, lpieralisi@kernel.org, robh@kernel.org, kw@linux.com, krzysztof.kozlowski+dt@linaro.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230223180531.15148-1-enachman@marvell.com> <20230223180531.15148-5-enachman@marvell.com> From: Krzysztof Kozlowski In-Reply-To: <20230223180531.15148-5-enachman@marvell.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230223_101225_490578_56C21DFD X-CRM114-Status: GOOD ( 21.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23/02/2023 19:05, Elad Nachman wrote: > From: Elad Nachman > > Add properties to support configurable DMA mask bits > and region mask bits. > configurable DMA mask bits is needed for Marvell AC5/AC5X SOCs which > have their physical DDR memory start at address 0x2_0000_0000. > Configurable region mask bits is needed for the Marvell Armada > 7020/7040/8040 SOCs when the DT file places the PCIe window above the > 4GB region. > The Synopsis Designware PCIe IP in these SOCs is too old to specify the > highest memory location supported by the PCIe, but practically supports > such locations. Allow these locations to be specified in the DT file. This formatting is so bad it makes difficult to read. Make these proper sentences with proper wrapping. > First DT property is called num-dmamask, > and can range between 33 and 64. Wrong mapping and we see it in the code. No need to code it again in commit msg. Especially that you already said it in the first sentence. > Second DT property is called num-regionmask, > and can range between 33 and 64. > > Signed-off-by: Elad Nachman > --- > .../devicetree/bindings/pci/snps,dw-pcie-common.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml b/Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml > index d87e13496834..a1b06ff19ca7 100644 > --- a/Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml > +++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml > @@ -261,6 +261,16 @@ properties: > > dma-coherent: true > > + num-dmamask: > + description: | > + number of dma mask bits to use, if different than default 32 minimum: 33 (from commit msg) default: 32... which does not make now sense... > + maximum: 64 > + > + num-regionmask: > + description: | > + number of region limit mask bits to use, if different than default 32 > + maximum: 64 > + > additionalProperties: true > > ... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel