From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3251FC433FE for ; Mon, 28 Feb 2022 14:36:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Aic4KDs9joUn39Aez0+FZX8p5iEAltAwzOnMdlMgDPY=; b=yjoR4CETRNsDK5 QQeacw2mq3BI8XC5SImb/60G86nxmgnDV5gwIEVJVjuTZ7SxBLFSKum/t4KD4x8lZ2O2zO7rp8/I3 37JeKTGnSQEuukzq3oDWsHHPRClaJcQRulKi/VaZZhRMJch7ZURImX3UD0nmC2Q3SCAK0SQUxLS5M F6y50GdUZ3l5X5pziNHeSGB4QTUOE9flPOiJ+oZDYKrgQbup43zTo9K6e+YpM+Ty4MrDFWKO96Ygp Vt4QoBl0UfUMBIAWk/08vfN03lpijkOFX828xxtLjMNUvHLRNcJNcHI00ZZN7+ea0uR67utlmAoPB P38Knl9wpHQmnkMJgtyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOh6y-00Cw1Z-20; Mon, 28 Feb 2022 14:34:52 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOgyl-00CsUQ-2p for linux-arm-kernel@lists.infradead.org; Mon, 28 Feb 2022 14:26:29 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9A049D6E; Mon, 28 Feb 2022 06:26:19 -0800 (PST) Received: from [10.57.39.47] (unknown [10.57.39.47]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BE7D03F73D; Mon, 28 Feb 2022 06:26:16 -0800 (PST) Message-ID: <6e14bdd4-5924-dd58-41ef-5bdb5561913b@arm.com> Date: Mon, 28 Feb 2022 14:26:12 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 1/3] dt-bindings: spi: Update clocks property for ARM pl022 Content-Language: en-GB To: Kuldeep Singh , Mark Brown , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Rob Herring , Linus Walleij References: <20220228124345.99474-1-singh.kuldeep87k@gmail.com> <20220228124345.99474-2-singh.kuldeep87k@gmail.com> From: Robin Murphy In-Reply-To: <20220228124345.99474-2-singh.kuldeep87k@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220228_062623_269173_8F572AB8 X-CRM114-Status: GOOD ( 15.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022-02-28 12:43, Kuldeep Singh wrote: > Add missing minItems property to clocks in ARM pl022 bindings. > > This also helps in resolving below dtc warnings: > arch/arm64/boot/dts/amd/amd-overdrive.dt.yaml: spi@e1020000: clocks: [[4]] is too short > From schema: Documentation/devicetree/bindings/spi/spi-pl022.yaml > arch/arm64/boot/dts/amd/amd-overdrive.dt.yaml: spi@e1020000: clock-names: ['apb_pclk'] is too short > From schema: Documentation/devicetree/bindings/spi/spi-pl022.yaml Who says that minItems is missing? Looking at the PL022 TRM[1] it seems clear that SSPCLK is pretty fundamental to useful operation. If that DT ever worked, it must be that the same clock is wired to both inputs, and the fact that that's how the neighbouring PL011 is described is strongly suggestive. If the point of schema is to find errors in DTs, doesn't it make more sense to fix the DTs than to weaken the schema just to shut it up? Of course in this particular case there's also the question of whether the most humane way to "fix" the Seattle DTs is to simply delete them, but that's orthogonal. Robin. [1] https://developer.arm.com/documentation/ddi0194/h/?lang=en > Signed-off-by: Kuldeep Singh > --- > Documentation/devicetree/bindings/spi/spi-pl022.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml > index 6d633728fc2b..7d36e15db5b3 100644 > --- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml > +++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml > @@ -34,6 +34,7 @@ properties: > maxItems: 1 > > clocks: > + minItems: 1 > maxItems: 2 > > clock-names: _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel