From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6EE3DC25B47 for ; Wed, 25 Oct 2023 10:59:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: CC:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JPxnPsDaXsKf4LVVcudru3tJ4I3Bh7G/ano3czko54g=; b=n0Nmd2oMtx70Yu r4uoKd2lVPlxoxoFqeN/PHMMk7god8wVq6xxSFqyg8hc6NmfgjlzX2ZDNu0VysUkByQ+OXfyVsDVd L16yzkwmVyKVvTNUefQ8gO2KklFMOy1uTt+ZpOicetqSPKkBKGVQqaAgQ+K+UunsY3imnH4rZsTh7 DVxH2jQvTShesQPvaexscfNUfh0QvRoePTDQyfO+ZV753na/ORnm5YbGe3mAbV1AMsOb/kt2u57qX owPEcpPW/MPF2frxAZ6NYf+P4G2vtid6TdKWfSnRbIZMGwY51tsvuM/Q0GvnlW/JqveJJW5Puvwer JO2mxn33tRKT9iK4wMPw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qvbb7-00C8KQ-1I; Wed, 25 Oct 2023 10:58:49 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qvbb5-00C8Ix-0K for linux-arm-kernel@lists.infradead.org; Wed, 25 Oct 2023 10:58:48 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 39PAwT3K062646; Wed, 25 Oct 2023 05:58:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1698231509; bh=1TPsUdXjm7Vpn4Ig1Vrcn9B/Y380Qufn7tJcHsIyp4I=; h=Date:CC:Subject:To:References:From:In-Reply-To; b=oGFhvcwjQQwe5uHZEZTOjXNgg5cc0c2fTSQlOXVcJuxTg3ExgRiGITAgNI6fm7kmj 77J2aOqBD2a9CZX7AqYqRf+LE7EmMk8HmppDUhYughb9618nJKPP9UnEm29yAxXpmj QPi4ugf5pO93LEYNujIOeYziWeMpkywV0cRSEksk= Received: from DFLE109.ent.ti.com (dfle109.ent.ti.com [10.64.6.30]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 39PAwTUw062342 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 25 Oct 2023 05:58:29 -0500 Received: from DFLE107.ent.ti.com (10.64.6.28) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 25 Oct 2023 05:58:29 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE107.ent.ti.com (10.64.6.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 25 Oct 2023 05:58:29 -0500 Received: from [172.24.227.9] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 39PAwOBV018686; Wed, 25 Oct 2023 05:58:25 -0500 Message-ID: <6e40c4ee-e549-4b41-8a12-65b474b8ef24@ti.com> Date: Wed, 25 Oct 2023 16:28:23 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird CC: Bjorn Helgaas , Manivannan Sadhasivam , , , , , , , , , , Subject: Re: [PATCH v3] PCI: keystone: Fix pci_ops for AM654x SoC Content-Language: en-US To: Serge Semin References: <20231023212628.GA1627567@bhelgaas> <3szgydgz7ege5h75mwdket5lniwy4oe52dq2uqehf74il5hc5j@oaqcbmfuf6de> From: Siddharth Vadapalli In-Reply-To: <3szgydgz7ege5h75mwdket5lniwy4oe52dq2uqehf74il5hc5j@oaqcbmfuf6de> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231025_035847_223678_15E3B163 X-CRM114-Status: GOOD ( 20.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Serge, On 25/10/23 15:58, Serge Semin wrote: > Hi Siddharth, Bjorn > > On Wed, Oct 25, 2023 at 10:32:50AM +0530, Siddharth Vadapalli wrote: ... >> > >> ks_pcie_probe() >> dw_pcie_host_init() >> pci_host_probe() >> ks_pcie_v3_65_add_bus() > > I guess what Bjorn implied was to add the ks_pcie_v3_65_add_bus() > invocation to the host_init() callback, i.e. in ks_pcie_host_init(). I misunderstood the term "host_init()", and interpret it as "dw_pcie_host_init()", due to which I thought I will add it after dw_pcie_host_init() invocation in ks_pcie_probe. Thank you for clarifying. > Moreover initializing the BARs/MSI after all the PCIe hierarchy has > been probed will eventually cause problems since MSI's won't work > until the ks_pcie_v3_65_add_bus() is called. > >> >> Since the .add_bus() method will be removed following this change, I suppose >> that the patch I post for it can be applied instead of this v3 patch which fixes >> pci_ops. >> > >> The patch I plan to post as a replacement for the current patch which shall also >> remove the ks_pcie_v3_65_add_bus() and the .add_bus() method is: > > Just a note. Seeing the Bjorn's suggestion may cause a regression on > the Keystone PCIe Host v3.65 I would suggest to merge in the original > fix as is and post an additional cleanup patch, like below with proper > modifications, on top of it. Thus we'll minimize a risk to break > things at least on the stable kernels. I will post it as a separate cleanup patch in that case and this v3 patch can be merged independently as you suggested. -- Regards, Siddharth. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel