public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Martin Botka <martin.botka@somainline.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Sudeep Holla <sudeep.holla@arm.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Yangtao Li <tiny.windzz@gmail.com>, Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Samuel Holland <samuel@sholland.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org,
	Andre Przywara <andre.przywara@arm.com>,
	Alan Ma <tech@biqu3d.com>,
	Luke Harrison <bttuniversity@biqu3d.com>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@somainline.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Rogerio Goncalves <rogerlz@gmail.com>,
	Martin Botka <martin@biqu3d.com>
Subject: Re: [PATCH 3/6] dt-bindings: opp: Add compatible for H616
Date: Mon, 4 Sep 2023 21:53:05 +0200	[thread overview]
Message-ID: <6e4cd0a1-43d0-e2e8-7281-e20ae653eae6@linaro.org> (raw)
In-Reply-To: <2C8H0S.90380B1U7TPP3@somainline.org>

On 04/09/2023 21:48, Martin Botka wrote:
> 
> 
> On Mon, Sep 4 2023 at 09:32:44 PM +02:00:00, Krzysztof Kozlowski 
> <krzysztof.kozlowski@linaro.org> wrote:
>> On 04/09/2023 21:31, Krzysztof Kozlowski wrote:
>>>  On 04/09/2023 17:57, Martin Botka wrote:
>>>>  We need to add compatible for H616 to H6 cpufreq driver bindings.
>>>
>>>  Please describe the hardware, not what is needed for drivers.
>>>
>>>>
>>>>  Also enable opp_supported_hw property that will be needed for H616.
>>>>
>>>>  Signed-off-by: Martin Botka <martin.botka@somainline.org>
>>>>  ---
>>>>   .../bindings/opp/allwinner,sun50i-h6-operating-points.yaml        
>>>>   | 6 +++++-
>>>>   1 file changed, 5 insertions(+), 1 deletion(-)
>>>>
>>>>  diff --git 
>>>> a/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml 
>>>> b/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml
>>>>  index 51f62c3ae194..2fa1199f2d23 100644
>>>>  --- 
>>>> a/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml
>>>>  +++ 
>>>> b/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml
>>>>  @@ -23,7 +23,10 @@ allOf:
>>>>
>>>>   properties:
>>>>     compatible:
>>>>  -    const: allwinner,sun50i-h6-operating-points
>>>>  +    contains:
>>>
>>>  This does not look like part of allOf, so contains is no correct 
>>> here.
>>>  This must be specific, so drop contains.
>>
>> BTW, I also do no see it used by the driver at all.
> Function sun50i_cpufreq_get_efuse uses it. It checks for H6 compatible 
> and if that fails we check for H616 compatible.

Such code does no scale. It also does not look reasonable - you cannot
have different compatible there. Device binds to h6 or h616, so you
cannot have OPP table from other devices.

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-09-04 19:53 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-04 15:57 [PATCH 0/6] cpufreq for H616 Martin Botka
2023-09-04 15:57 ` [PATCH 1/6] firmware: smccc: Export revision soc_id function Martin Botka
2023-09-04 15:57 ` [PATCH 2/6] cpufreq: dt-platdev: Blocklist allwinner,h616 SoC Martin Botka
2023-09-04 20:40   ` Andre Przywara
2023-09-06  0:59     ` Icenowy Zheng
2023-09-25  8:59   ` Andre Przywara
2023-09-04 15:57 ` [PATCH 3/6] dt-bindings: opp: Add compatible for H616 Martin Botka
2023-09-04 19:31   ` Krzysztof Kozlowski
2023-09-04 19:32     ` Krzysztof Kozlowski
2023-09-04 19:48       ` Martin Botka
2023-09-04 19:53         ` Krzysztof Kozlowski [this message]
2023-09-04 20:06           ` Martin Botka
2023-09-04 19:52     ` Martin Botka
2023-09-04 15:57 ` [PATCH 4/6] cpufreq: sun50i: Add H616 support Martin Botka
2023-09-04 19:28   ` Martin Botka
2023-09-04 20:41   ` Andre Przywara
2023-09-04 20:44     ` Martin Botka
2023-09-25  8:59   ` Andre Przywara
2023-09-04 15:57 ` [PATCH 5/6] arm64: dts: allwinner: h616: Add CPU Operating Performance Points table Martin Botka
2023-09-04 19:33   ` Krzysztof Kozlowski
2023-09-04 19:43     ` Martin Botka
2023-09-04 15:57 ` [PATCH 6/6] arm64: dts: allwinner: h616: Add cooling cells Martin Botka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e4cd0a1-43d0-e2e8-7281-e20ae653eae6@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=andre.przywara@arm.com \
    --cc=angelogioacchino.delregno@somainline.org \
    --cc=bttuniversity@biqu3d.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=lpieralisi@kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=mark.rutland@arm.com \
    --cc=martin.botka@somainline.org \
    --cc=martin@biqu3d.com \
    --cc=rafael@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=rogerlz@gmail.com \
    --cc=samuel@sholland.org \
    --cc=sudeep.holla@arm.com \
    --cc=tech@biqu3d.com \
    --cc=tiny.windzz@gmail.com \
    --cc=viresh.kumar@linaro.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox