From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89C69C83F33 for ; Mon, 4 Sep 2023 19:53:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=A5G/YMDrcDmewq/v10oQ0EBxTzzRQDlAAgku5HF6rVM=; b=hqDzw7Tkeh/tcj iJpxVKiTsNl8VpnJAk/ybJ82fohEqiCW1TmQhXTBLuW+jQeKazF4vFgqOh6/6OtRd3xsIdgPRPreY 1Fkw49tB81T1M9cm6ce01FwTRJSWnndrZZe2f+2ow+ntb84CMvno0J67+ogwjNamlbtUqxPMPFa0i zYKHiHG8+bT6nhSiaEfWLss9Pco6Bzl6jbYBdfV056p/Ofckjm9W5ykX4JrOcRlONhP1NbpIM2Qcu CyApOE5iP9o6tKv1ROVl+uFjW+914V7JpoZ9bUgX4DnYbjHjA3Mbd794LbtcSTpTiHdwilV8imAxc hp1OeSLVN2jB2jV6Uy+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qdFdV-004imS-1z; Mon, 04 Sep 2023 19:53:25 +0000 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qdFdT-004ilz-0y for linux-arm-kernel@lists.infradead.org; Mon, 04 Sep 2023 19:53:24 +0000 Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2bc63e0d8cdso26895701fa.2 for ; Mon, 04 Sep 2023 12:53:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693857199; x=1694461999; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wvaluZJNHnPZbmcG4bvJEAilbtSGa3vKoc36gbuUccA=; b=aIEOlLk0BqXF+7vv6u0PkYQG5mcMguEu9aiC8JkzSLecgNA8iONYTrtFws/THDFiQC HMFkQ2dOUS1AfWAfvcMtV34wq6uCUiWNHZIKVECkJ5tj9zl34GL8oozmpr+6Qx6It7Vt pzPU1nknGMYpG0TDVT21RmhNGbTaAGV282vf+4tqadxReoV0zuNUOr3mnQzPd8nEVaJa NEP7yQNkx2IrUqlh/oa/SmzTGJ3XQRD+jKAwgLXFuEmzbTH7KcVB7zwp/X8As1HBoOP+ +CGsaTYhTMUnsIX/cCyjl4h46xalu8xZYs16UT/E4oCrKUOwo7nek1VrE2pd8rBPZ4YW fwdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693857199; x=1694461999; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wvaluZJNHnPZbmcG4bvJEAilbtSGa3vKoc36gbuUccA=; b=N3hjQCGvQLabsOsslD9RWUypjgO7A3Gm/AodhIY418xjOm84jakPcGCKysfRBEn+cv AEsGIFYVmasg3F6uWs8EKFKIWjx28QyvruLuTpcVATp2TWusl2CKVsuE6xAmzFS1kNWA T43tVFt2Vfs+PHBWr3Pg60VswP9viZS1meksszSsk6dBybc2gwFH+9RXe9qmundODH0q l6QPNHfUJtVqY2O/EI1AQCwnu/a0dLU14jZZaqlroVWwEkPud9DuinF6Kh1tzMTrJT7X 0DT2CKQQvjyjQGjvgCThvVOX70KkuDCrkoJsZ2LPzKpmWO5gedw7yNVUyOv6BTdYtMWh zTbg== X-Gm-Message-State: AOJu0Yxc4CIJ/MN9ewy6Yk3ApkiqDwWuoMB4KadmAOS2fLpkL0gm4USf McF94m8ft30zwnepaDDIngVfeA== X-Google-Smtp-Source: AGHT+IEfhBCcSQiWoHa2jiOolRPp2v0XsshOTlOP4jb6+QXkRjWKBP4OryeydAehfnhfGWiOqrEa0w== X-Received: by 2002:a2e:6a09:0:b0:2bd:16e6:f07c with SMTP id f9-20020a2e6a09000000b002bd16e6f07cmr7407883ljc.17.1693857198894; Mon, 04 Sep 2023 12:53:18 -0700 (PDT) Received: from [192.168.0.22] (77-252-46-238.static.ip.netia.com.pl. [77.252.46.238]) by smtp.gmail.com with ESMTPSA id o13-20020a17090637cd00b0098e2969ed44sm6475829ejc.45.2023.09.04.12.53.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Sep 2023 12:53:18 -0700 (PDT) Message-ID: <6e4cd0a1-43d0-e2e8-7281-e20ae653eae6@linaro.org> Date: Mon, 4 Sep 2023 21:53:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH 3/6] dt-bindings: opp: Add compatible for H616 To: Martin Botka Cc: Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , "Rafael J. Wysocki" , Viresh Kumar , Yangtao Li , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org, Andre Przywara , Alan Ma , Luke Harrison , Marijn Suijten , AngeloGioacchino Del Regno , Konrad Dybcio , Rogerio Goncalves , Martin Botka References: <20230904-cpufreq-h616-v1-0-b8842e525c43@somainline.org> <20230904-cpufreq-h616-v1-3-b8842e525c43@somainline.org> <2C8H0S.90380B1U7TPP3@somainline.org> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <2C8H0S.90380B1U7TPP3@somainline.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230904_125323_342444_59F8D8B0 X-CRM114-Status: GOOD ( 18.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/09/2023 21:48, Martin Botka wrote: > > > On Mon, Sep 4 2023 at 09:32:44 PM +02:00:00, Krzysztof Kozlowski > wrote: >> On 04/09/2023 21:31, Krzysztof Kozlowski wrote: >>> On 04/09/2023 17:57, Martin Botka wrote: >>>> We need to add compatible for H616 to H6 cpufreq driver bindings. >>> >>> Please describe the hardware, not what is needed for drivers. >>> >>>> >>>> Also enable opp_supported_hw property that will be needed for H616. >>>> >>>> Signed-off-by: Martin Botka >>>> --- >>>> .../bindings/opp/allwinner,sun50i-h6-operating-points.yaml >>>> | 6 +++++- >>>> 1 file changed, 5 insertions(+), 1 deletion(-) >>>> >>>> diff --git >>>> a/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml >>>> b/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml >>>> index 51f62c3ae194..2fa1199f2d23 100644 >>>> --- >>>> a/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml >>>> +++ >>>> b/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml >>>> @@ -23,7 +23,10 @@ allOf: >>>> >>>> properties: >>>> compatible: >>>> - const: allwinner,sun50i-h6-operating-points >>>> + contains: >>> >>> This does not look like part of allOf, so contains is no correct >>> here. >>> This must be specific, so drop contains. >> >> BTW, I also do no see it used by the driver at all. > Function sun50i_cpufreq_get_efuse uses it. It checks for H6 compatible > and if that fails we check for H616 compatible. Such code does no scale. It also does not look reasonable - you cannot have different compatible there. Device binds to h6 or h616, so you cannot have OPP table from other devices. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel