From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6691C43334 for ; Tue, 14 Jun 2022 08:27:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XuCugXSV9/S9i1NA8M/cWoTm7aoPVtnAj0nsqhDPpqM=; b=rlTQ1vv27EbT7a iW31+PLjxK7GPNsUwbkeaCHOsTxpiNcGhAE3Wj1FLr3hFF4g6UJ0WMQIR4bTadDzXVItDZwFOtt93 EY13DukKwUFydp7rac2SmGl6EWOSzudGct8cQI6fKooDzfxTv/Aq1y55XGydcgnxS/Grqz8qj0+jT w55JH0lFDsOPJwRAZDYY3BLt54wX0zLN6/corstlLa8DtxmJar6kePUNFYvf8Lpla6SbGrKHuzuRu gcyLTeg8xHVrg2qSO0L8nGwNYX5VJzTune7gzWxjBeMFuslO+8xqkKZC9HuWqYzD9L3mrkhz6IK5z 1wMQljsPMMopPFvfpY7A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o11sZ-008Evs-BK; Tue, 14 Jun 2022 08:26:27 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o11sU-008EuE-9t for linux-arm-kernel@lists.infradead.org; Tue, 14 Jun 2022 08:26:24 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D479623A; Tue, 14 Jun 2022 01:26:17 -0700 (PDT) Received: from [10.162.40.17] (unknown [10.162.40.17]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BE3213F66F; Tue, 14 Jun 2022 01:26:14 -0700 (PDT) Message-ID: <6e8f4341-6ee5-c2b4-1965-6132927f76a1@arm.com> Date: Tue, 14 Jun 2022 13:56:12 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 From: Anshuman Khandual Subject: Re: [PATCH v4 01/26] arm64: head: move kimage_vaddr variable into C file To: Ard Biesheuvel , linux-arm-kernel@lists.infradead.org Cc: linux-hardening@vger.kernel.org, Marc Zyngier , Will Deacon , Mark Rutland , Kees Cook , Catalin Marinas , Mark Brown References: <20220613144550.3760857-1-ardb@kernel.org> <20220613144550.3760857-2-ardb@kernel.org> Content-Language: en-US In-Reply-To: <20220613144550.3760857-2-ardb@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220614_012622_447542_545C0585 X-CRM114-Status: GOOD ( 14.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/13/22 20:15, Ard Biesheuvel wrote: > This variable definition does not need to be in head.S so move it out. > > Signed-off-by: Ard Biesheuvel Reviewed-by: Anshuman Khandual > --- > arch/arm64/kernel/head.S | 7 ------- > arch/arm64/mm/mmu.c | 3 +++ > 2 files changed, 3 insertions(+), 7 deletions(-) > > diff --git a/arch/arm64/kernel/head.S b/arch/arm64/kernel/head.S > index 6a98f1a38c29..1cdecce552bb 100644 > --- a/arch/arm64/kernel/head.S > +++ b/arch/arm64/kernel/head.S > @@ -469,13 +469,6 @@ SYM_FUNC_START_LOCAL(__primary_switched) > ASM_BUG() > SYM_FUNC_END(__primary_switched) > > - .pushsection ".rodata", "a" > -SYM_DATA_START(kimage_vaddr) > - .quad _text > -SYM_DATA_END(kimage_vaddr) > -EXPORT_SYMBOL(kimage_vaddr) > - .popsection > - > /* > * end early head section, begin head code that is also used for > * hotplug and needs to have the same protections as the text region > diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c > index c5563ff990da..7148928e3932 100644 > --- a/arch/arm64/mm/mmu.c > +++ b/arch/arm64/mm/mmu.c > @@ -49,6 +49,9 @@ u64 idmap_ptrs_per_pgd = PTRS_PER_PGD; > u64 __section(".mmuoff.data.write") vabits_actual; > EXPORT_SYMBOL(vabits_actual); > > +u64 kimage_vaddr __ro_after_init = (u64)&_text; > +EXPORT_SYMBOL(kimage_vaddr); > + > u64 kimage_voffset __ro_after_init; > EXPORT_SYMBOL(kimage_voffset); > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel