From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7880C433DF for ; Sun, 18 Oct 2020 06:03:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F4BD2087C for ; Sun, 18 Oct 2020 06:03:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ylfdc3uI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F4BD2087C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=zju.edu.cn Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:MIME-Version:References:In-Reply-To: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4U3Hr1NEyagfDt9vK3Nz6+UBPNu8D7Ig6dHQmpaHbI4=; b=ylfdc3uIUdeZFmJq7xsWYMR/B UvhMQS+YYnHMf13NhYx5EbTEhOvNpqHng69ngo+qRtWiUWa06IC3QdmBsfVldiroJTdXVsU3sr8bW iuFDVkP7zF4Q1bAYDXrXbgegT7/TB28IILmE5E3BZqkjQ9PP3/CBegTgkjzeFopuiB1gFmU0SmUHH LvA58HrbuZVN+5J1bdeoRQ6OXbM++udORo7DzrzdhzpOwrqN0TbBZYjsXW/u0iQ0XICVmppPEtk9b E48XlKMIghTZzlp7LE6ypRgQIQ1tx/E93hVYBNOaUFxUYntD2q/UfbA9AypULQjqqxK8h5KyKKBof Bb522GslA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kU1ko-0003s0-Vl; Sun, 18 Oct 2020 06:01:17 +0000 Received: from spam.zju.edu.cn ([61.164.42.155] helo=zju.edu.cn) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kU1kZ-0003qs-Sk for linux-arm-kernel@lists.infradead.org; Sun, 18 Oct 2020 06:01:13 +0000 Received: by ajax-webmail-mail-app3 (Coremail) ; Sun, 18 Oct 2020 14:00:41 +0800 (GMT+08:00) X-Originating-IP: [10.192.85.18] Date: Sun, 18 Oct 2020 14:00:41 +0800 (GMT+08:00) X-CM-HeaderCharset: UTF-8 From: dinghao.liu@zju.edu.cn To: "Alexandre Belloni" Subject: Re: Re: Re: [PATCH] rtc: sun6i: Fix memleak in sun6i_rtc_clk_init X-Priority: 3 X-Mailer: Coremail Webmail Server Version XT5.0.12 build 20200616(0f5d8152) Copyright (c) 2002-2020 www.mailtech.cn zju.edu.cn In-Reply-To: <20201009205744.GA849573@piout.net> References: <20200823075815.23457-1-dinghao.liu@zju.edu.cn> <6de4a430.8e03.17429fa786d.Coremail.dinghao.liu@zju.edu.cn> <20201009205744.GA849573@piout.net> MIME-Version: 1.0 Message-ID: <6ea00d70.3f76.1753a4bb59b.Coremail.dinghao.liu@zju.edu.cn> X-Coremail-Locale: zh_CN X-CM-TRANSID: cC_KCgB3GWgJ2otftqgZAA--.3185W X-CM-SenderInfo: qrrzjiaqtzq6lmxovvfxof0/1tbiAg4PBlZdtQccYQAEsF X-Coremail-Antispam: 1Ur529EdanIXcx71UUUUU7IcSsGvfJTRUUUblCS07vEb7Iv0x C_Ar1lV2xY67kC6x804xWlV2xY67CY07I20VC2zVCF04k26cxKx2IYs7xG6rWj6s0DMIAI bVAFxVCF77xC64kEw24lV2xY67C26IkvcIIF6IxKo4kEV4ylV2xY628lY4IE4IxF12IF4w CS07vE84x0c7CEj48ve4kI8wCS07vE84ACjcxK6xIIjxv20xvE14v26w1j6s0DMIAIbVA2 z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVW8Jr0_Cr1UMIAIbVA2z4x0Y4vEx4A2jsIE14v26r xl6s0DMIAIbVA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1lV2xY62AIxVAIcxkEcVAq 07x20xvEncxIr21lV2xY6c02F40EFcxC0VAKzVAqx4xG6I80ewCS07vEYx0E2Ix0cI8IcV AFwI0_Jr0_Jr4lV2xY6cIj6I8E87Iv67AKxVWUJVW8JwCS07vEOx8S6xCaFVCjc4AY6r1j 6r4UMIAIbVCjxxvEw4WlV2xY6xkI7II2jI8vz4vEwIxGrwCS07vE42xK82IY6x8ErcxFaV Av8VW8uw4UJr1UMIAIbVCF72vE77IF4wCS07vE4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lV2xY 6I8I3I0E5I8CrVAFwI0_Jr0_Jr4lV2xY6I8I3I0E7480Y4vE14v26r106r1rMIAIbVC2zV AF1VAY17CE14v26r1q6r43MIAIbVCI42IY6xIIjxv20xvE14v26r1j6r1xMIAIbVCI42IY 6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lV2xY6IIF0xvE42xK8VAvwI8IcIk0rVWrZr1j6s 0DMIAIbVCI42IY6I8E87Iv67AKxVWUJVW8JwCS07vEIxAIcVC2z280aVCY1x0267AKxVWU JVW8JbIYCTnIWIevJa73U X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201018_020108_938842_4A036DF1 X-CRM114-Status: GOOD ( 10.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rtc@vger.kernel.org, Alessandro Zummo , Kangjie Lu , linux-kernel , Maxime Ripard , Chen-Yu Tsai , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > On 26/08/2020 16:55:14+0800, dinghao.liu@zju.edu.cn wrote: > > > On Sun, Aug 23, 2020 at 3:59 PM Dinghao Liu wrote: > > > > > > > > When clk_hw_register_fixed_rate_with_accuracy() fails, > > > > clk_data should be freed. It's the same for the subsequent > > > > error paths. > > > > > > I suppose you should also unregister the already registered clocks > > > in the latter two error paths? > > > > > > > Sounds reasonable. But I find that the existing kernel code takes different > > strategies for this case. of_sama5d4_sckc_setup() uses clk_hw_unregister() > > after clk_hw_register_fixed_rate_with_accuracy(), while _of_fixed_clk_setup() > > uses clk_hw_unregister_fixed_rate(). But at91sam926x_pmc_setup() just does > > nothing in this case. > > I guess you should use clk_hw_unregister_fixed_rate after > clk_hw_register_fixed_rate_with_accuracy. clk_hw_unregister will leak > the struct clk_fixed_rate. It doesn't matter too much for > of_sama5d4_sckc_setup and at91sam926x_pmc_setup because if th clock > can't be registered, the platform will not boot. Thank you for your advice! I will submit a new patch soon. Regards, Dinghao _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel