From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6658EC61DA4 for ; Thu, 9 Feb 2023 15:52:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1E171fDniFOz+0RTfVTAH0Ytk6dgRTG+2AAZ2jFz+YA=; b=nyaK72cxcMCmip 1hTf0gxb8quJZGTwSrv9mOItxjAtR0AB+t2frDQBJ3aNxk0cEdxtk3BUXT+XIrGcW6x0YgS46Y4X7 Ncjc/bWAV484ScI6Zwtkq8fvF9dcUsUs0FvYDXbLI1DLRhiffdR2RQPPyWTMh3JSoQ80fV0zoaKj4 Ssua0l9peMiaFvv5Zpel+k6hzqQTGZQyP0HGEdoN5kHe3bmLujOrfcI+CNfgbLJJSvv5VGVd6BwKB GgmaCaNeYB3IAqd9svWGJWt4tgIPK30sgpVRYEjMrov3UODxkglCQOOnmKRK5ZE8G5NGiSj7fEGV/ 2mVBMD2q/QoKseFnvtGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pQ9CN-002IPN-W6; Thu, 09 Feb 2023 15:51:00 +0000 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pQ9CK-002INT-Jp for linux-arm-kernel@lists.infradead.org; Thu, 09 Feb 2023 15:50:58 +0000 Received: by mail-wr1-x431.google.com with SMTP id bk16so2199952wrb.11 for ; Thu, 09 Feb 2023 07:50:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=y41lQosy76/yd9ref3+nY9Q/B9QUKYofOTeSAFeUKd8=; b=op7Ecgx+UGtYR0W7tsKb33AnkDioq7r+B763L2/dKL79TbMfnSRDVKtNNYl/Y5WHEg yKoeCU8emBxORGaZE13irxCi8wrsKhfuoFvkfcJPqerIyLvvpgrs3/ShXiB8FBmLcmkl KscxaMtFH43h2OPlKBvizUO30BAUgAWk8vc/qHLbqm7Y2xnaAwBdcE8TgWkyX0Jdwa7b 2+q1JQUwZWFoukHaWJeLypMORBLSL4VoZLDvJ+cs+/CrwAHY6u/tkiVZDdHBbkb1Y3GE 1hCOJPo8NrCPix003k2Fv2pyqDZkGFEIHkS1Zz4aOJ6nQyXL+OQiGbu1qf1BvTR5mLhb dChA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=y41lQosy76/yd9ref3+nY9Q/B9QUKYofOTeSAFeUKd8=; b=BSsJzldw+SkmicOVEDKJ+M4EYVXjsvzS2MEGH73ZDhcXguU2pAzWPYm9ymUZy26rxq OZvi1qkPU4PSeYUCdmM2fstEVDsckHLZIVydALD+NO7h9L3lp5VI8akU0oLQgrafk+Bv gKesBPfl1EaniezszUe8KQOIM1LcQq+wWsPDqPiXRR0DYdNzMTpwrTR4mV99rAawNopB zqmReBxIS60SOXK/1CGSdFIEKzLpibCpvnxb8aZcDQdBE7UliqvefWhTx3x/BtwCLWjk 9JQMfMjxdfPtw/D+Tetw0rJfx5/DSOJcUm2f+7az0IvqWZetaCFPxuDpBM5VR4A9OfsS qwQA== X-Gm-Message-State: AO0yUKVVQA/fy6bPAsiQ6svg+e8qO3wSA3lixI+dt8NZQcj61z2RTMvH dVAbZt/4YSfmCZKIBzLOY3d2Ug== X-Google-Smtp-Source: AK7set+rlrXad6Dg6sDEUQG+buCHs3h5raoC/DQhwWKs+hgdPlWUZxs2FHzaC/cvLHJAmhjTmmmjqw== X-Received: by 2002:a05:6000:18cf:b0:2c4:8ea:bfd4 with SMTP id w15-20020a05600018cf00b002c408eabfd4mr3694049wrq.33.1675957851853; Thu, 09 Feb 2023 07:50:51 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id f13-20020a5d568d000000b002bfb8f829eesm1494122wrv.71.2023.02.09.07.50.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Feb 2023 07:50:51 -0800 (PST) Message-ID: <6edc8fcd-d6d3-916d-c2f4-a44b8485ab77@linaro.org> Date: Thu, 9 Feb 2023 16:50:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 2/2] pinctrl: at91: adding new macros Content-Language: en-US To: Ryan.Wanner@microchip.com, ludovic.desroches@microchip.com, linus.walleij@linaro.org, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, claudiu.beznea@microchip.com Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, manikandan.M@microchip.com References: <20230209154544.535136-1-Ryan.Wanner@microchip.com> <20230209154544.535136-3-Ryan.Wanner@microchip.com> From: Krzysztof Kozlowski In-Reply-To: <20230209154544.535136-3-Ryan.Wanner@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230209_075056_675072_843A565E X-CRM114-Status: GOOD ( 15.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/02/2023 16:45, Ryan.Wanner@microchip.com wrote: > From: Ryan Wanner Use subject prefixes matching the subsystem (which you can get for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching). > > Adding macros for sama7g drive strength. > > Signed-off-by: Ryan Wanner > --- > include/dt-bindings/pinctrl/at91.h | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/include/dt-bindings/pinctrl/at91.h b/include/dt-bindings/pinctrl/at91.h > index e8e117306b1b..fd0a389b2a0f 100644 > --- a/include/dt-bindings/pinctrl/at91.h > +++ b/include/dt-bindings/pinctrl/at91.h > @@ -42,8 +42,14 @@ > #define AT91_PERIPH_C 3 > #define AT91_PERIPH_D 4 > > -#define ATMEL_PIO_DRVSTR_LO 1 That's an ABI break, so no. You need to keep it. > +#define ATMEL_PIO_DRVSTR_LO_0 0 > +#define ATMEL_PIO_DRVSTR_LO_1 1 > #define ATMEL_PIO_DRVSTR_ME 2 > #define ATMEL_PIO_DRVSTR_HI 3 > > +#define ATMEL_PIO_DRVSTR_LO_D 0 > +#define ATMEL_PIO_DRVSTR_HI_A 1 > +#define ATMEL_PIO_DRVSTR_LO_C 2 > +#define ATMEL_PIO_DRVSTR_LO_B 3 Explanation for all of these would be useful, it's a bit of cryptic. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel