From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8C10C54E60 for ; Tue, 19 Mar 2024 08:27:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2oYR8M1F4b5umeovUT3n/H9JgxV/Trqqsk5FaCNvdjs=; b=uK0JvaWNoOQ+OP 67cXuXBxPSUn81pSZ9hl34BzszwIiDU+ir1ZPCk7eST1xMsiW3upPujWmwt1386Zs4GBYgOoU4xm3 mGzmbkzJj4UaTDg2WzFPrthYx25n0tH9e4QgeEQqXgV5VaMbJvOSUnEoPrKl2loGCd6pJ6G4AuVcY 5HiuwEgWrT+cyKKHS7RcQXvII6fvOst1SISj/wIUIZ+IsHwIoth2PQrzKBTXbH4Ul2QTK6uIPayO5 EvD9OoRvB/Lk68sQB+q0lo8o9/Zp3jhyDdXWFytLo/RKnvIq7d7i8tk1VR7WLQ4oQi3L2Hy3Q5c/U f5pVZq3+CjAXJIVztDcw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmUoD-0000000BuHL-06TT; Tue, 19 Mar 2024 08:26:57 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmUo9-0000000BuEi-0uTj for linux-arm-kernel@lists.infradead.org; Tue, 19 Mar 2024 08:26:55 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 42J8QbiB090324; Tue, 19 Mar 2024 03:26:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1710836797; bh=Oz20PFNHtij4CjpERCZKBDH6sdX95lWDbXHhrBALB3Y=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=Vv39uHjK3U/KoMzTdnafeFXWGNP57XS6IUbkMztSozHy0OQakUx8I1j1K8HD4dnJd tCg3CFq5eQBQQsMsr53lDr5lNuuIAs1WNHTk5iaPIQiF4dU4ziKFdPtp0TAGYtuMvG zArp4WiwB5tI3QUGBUh77iI3Qe7WNl7FjsVFAVYo= Received: from DFLE105.ent.ti.com (dfle105.ent.ti.com [10.64.6.26]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 42J8Qbi1072590 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 19 Mar 2024 03:26:37 -0500 Received: from DFLE101.ent.ti.com (10.64.6.22) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 19 Mar 2024 03:26:36 -0500 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DFLE101.ent.ti.com (10.64.6.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 19 Mar 2024 03:26:36 -0500 Received: from [10.24.69.142] ([10.24.69.142]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 42J8QTSH052033; Tue, 19 Mar 2024 03:26:30 -0500 Message-ID: <6eff590b-3f4a-4824-95e7-b2a94656408b@ti.com> Date: Tue, 19 Mar 2024 13:56:29 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/5] greybus: Add mikroBUS manifest types Content-Language: en-US To: Ayush Singh , open list CC: , , , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Mark Brown , Johan Hovold , Alex Elder , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/TEXAS INSTRUMENTS K3 ARCHITECTURE" , "open list:SPI SUBSYSTEM" , "moderated list:GREYBUS SUBSYSTEM" , Vaishnav M A References: <20240317193714.403132-1-ayushdevel1325@gmail.com> <20240317193714.403132-4-ayushdevel1325@gmail.com> From: Vaishnav Achath In-Reply-To: <20240317193714.403132-4-ayushdevel1325@gmail.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240319_012653_549600_07BB6B5C X-CRM114-Status: GOOD ( 38.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 18/03/24 01:07, Ayush Singh wrote: > DONOTMERGE > Why? > mikroBUS addon boards allow using same mikroBUS connector for a wide > range of peripherals. It is also possible for the addon board not to use > all the pins in mikroBUS socket (marked by NC or Not Connected). This > would require the need to create an almost new overlays for each > permutation of the hardware. > > To overcome this, a manifest format based on Greybus manifest > specification was created which allows describing mikroBUS addon boards. > The reason for choosing greybus manifest for the identifier is that so far > we discussed only about physical mikroBUS ports on the board, but we can you will need to reword the commit message properly in imperative mood, here and in multiple other places. > also have mikroBUS ports on a remote microcontroller appearing on host > over greybus and there a device tree overlay solution does not work as the > standard identifier mechanism. > > The patch introduces 3 new greybus descriptor types: > 1. mikrobus-descriptor: > Is a fixed-length descriptor (12 bytes), and the manifest shall have > precisely one mikroBUS descriptor. Each byte describes a configuration > of the corresponding pin on the mikroBUS addon board in a clockwise > direction starting from the PWM pin omitting power (VCC and ground) > pins as same as the default state of the pin. > There are mikroBUS addon boards that use some dedicated SPI, UART, PWM, > and I2C pins as GPIO pins, so it is necessary to redefine the default > pin configuration of that pins on the host system. Also, sometimes it is > required the pull-up on the host pin for correct functionality > 2. property-descriptor: > Are used to pass named properties or named GPIOs to the host. The host > system uses this information to properly configure specific board > drivers by passing the properties and GPIO name. There can be multiple > instances of property descriptors per add-on board manifest. > 3. device-descriptor: > Describes a device on the mikroBUS port. The device descriptor is a > fixed-length descriptor, and there can be multiple instances of device > descriptors in an add-on board manifest in cases where the add-on board > presents more than one device to the host. > > New mikroBUS addon boards also sometimes contain a 1-wire EEPROM with > the mikroBUS manifest, thus enabling plug and play support. > new mikroBUS sometimes contain an EEPROM? aren't these called Click ID compliant add-on boards? there should be clarity in the commit message. > I have also created PR to add mikrobus descriptors in Greybus spec and I > think the old PR on manifesto by Vaishnav should also work. However, > both of these repositories seem to be inactive. I am guessing the > greybus mailing list can provide more information on how I should go > about these. Why is information like these inside the commit message, these go below the tear line. > > Here is a sample mikroBUS manifest: > ``` > ;; > ; PRESSURE CLICK > ; https://www.mikroe.com/pressure-click > ; CONFIG_IIO_ST_PRESS > ; > ; Copyright 2020 BeagleBoard.org Foundation > ; Copyright 2020 Texas Instruments > ; > > [manifest-header] > version-major = 0 > version-minor = 1 > > [interface-descriptor] > vendor-string-id = 1 > product-string-id = 2 > > [string-descriptor 1] > string = MIKROE > > [string-descriptor 2] > string = Pressure > > [mikrobus-descriptor] > pwm-state = 4 > int-state = 1 > rx-state = 7 > tx-state = 7 > scl-state = 6 > sda-state = 6 > mosi-state = 5 > miso-state = 5 > sck-state = 5 > cs-state = 5 > rst-state = 2 > an-state = 1 > > [device-descriptor 1] > driver-string-id = 3 > protocol = 0x3 > reg = 0x5d > > [string-descriptor 3] > string = lps331ap > ``` > > Link: https://www.mikroe.com/clickid ClickID > Link: > https://docs.beagleboard.org/latest/projects/beagleconnect/index.html > beagleconnect > Link: https://github.com/projectara/greybus-spec Greybus Spec > Link: https://github.com/projectara/greybus-spec/pull/4 Greybus Spec PR > Link: https://github.com/projectara/manifesto/pull/2 manifesto PR > The manifesto PR might not be updated. Thanks and Regards, Vaishnav > Co-developed-by: Vaishnav M A > Signed-off-by: Vaishnav M A > Signed-off-by: Ayush Singh > --- > include/linux/greybus/greybus_manifest.h | 49 ++++++++++++++++++++++++ > 1 file changed, 49 insertions(+) > > diff --git a/include/linux/greybus/greybus_manifest.h b/include/linux/greybus/greybus_manifest.h > index bef9eb2093e9..83241e19d9b3 100644 > --- a/include/linux/greybus/greybus_manifest.h > +++ b/include/linux/greybus/greybus_manifest.h > @@ -23,6 +23,9 @@ enum greybus_descriptor_type { > GREYBUS_TYPE_STRING = 0x02, > GREYBUS_TYPE_BUNDLE = 0x03, > GREYBUS_TYPE_CPORT = 0x04, > + GREYBUS_TYPE_MIKROBUS = 0x05, > + GREYBUS_TYPE_PROPERTY = 0x06, > + GREYBUS_TYPE_DEVICE = 0x07, > }; > > enum greybus_protocol { > @@ -151,6 +154,49 @@ struct greybus_descriptor_cport { > __u8 protocol_id; /* enum greybus_protocol */ > } __packed; > > +/* > + * A mikrobus descriptor is used to describe the details > + * about the bus ocnfiguration for the add-on board > + * connected to the mikrobus port. > + */ > +struct greybus_descriptor_mikrobus { > + __u8 pin_state[12]; > +} __packed; > + > +/* > + * A property descriptor is used to pass named properties > + * to device drivers through the unified device properties > + * interface under linux/property.h > + */ > +struct greybus_descriptor_property { > + __u8 length; > + __u8 id; > + __u8 propname_stringid; > + __u8 type; > + __u8 value[]; > +} __packed; > + > +/* > + * A device descriptor is used to describe the > + * details required by a add-on board device > + * driver. > + */ > +struct greybus_descriptor_device { > + __u8 id; > + __u8 driver_stringid; > + __u8 protocol; > + __u8 reg; > + __le32 max_speed_hz; > + __u8 irq; > + __u8 irq_type; > + __u8 mode; > + __u8 prop_link; > + __u8 gpio_link; > + __u8 reg_link; > + __u8 clock_link; > + __u8 pad[1]; > +} __packed; > + > struct greybus_descriptor_header { > __le16 size; > __u8 type; /* enum greybus_descriptor_type */ > @@ -164,6 +210,9 @@ struct greybus_descriptor { > struct greybus_descriptor_interface interface; > struct greybus_descriptor_bundle bundle; > struct greybus_descriptor_cport cport; > + struct greybus_descriptor_mikrobus mikrobus; > + struct greybus_descriptor_property property; > + struct greybus_descriptor_device device; > }; > } __packed; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel