From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6837BC433FE for ; Wed, 5 Oct 2022 15:04:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sd1+stacU+KjRPD5B3IvX8cQ+sbWEm2zS1KBH1GWUQQ=; b=2L+uHidOpEylR/ uFdLU8K69fIB0z5SpaO/JphmpF9WdWHX123MkTQQyfdZQHcnWSrhgtGdLR22gHi/KDZqzYTEHOoFu TsTL18UeNJcEEKLZmcEoMVXFl2VYmtEnNLkqlCPwvF3krdF6q2eyqIxXXlevyPXkcIPicRLlzIClI j6uqx5t4gb7oEFZk54X6yrScT/jR4tE9x2zTniAkzjP/pO6W74Fl+tG9DaxIATjRfPJF9rvm6S74H 2Am3eSE/lIIZbStTJ4iA/zMH/CJeMCtqpBBX5t3kz8/PuYGHHXx6cyr46D/b1Xr7Hz/2FyfpboHLs mO8oHZ227yZY6lNwymrA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1og5vH-00Ek5f-QY; Wed, 05 Oct 2022 15:02:59 +0000 Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1og5vE-00Ek2M-2i for linux-arm-kernel@lists.infradead.org; Wed, 05 Oct 2022 15:02:57 +0000 Received: by mail-lf1-x133.google.com with SMTP id z4so25960905lft.2 for ; Wed, 05 Oct 2022 08:02:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=94mwMcPTU0fA4GC+JR+9ZWgjXzSQUOmYw33Hhdzn4ZY=; b=utnjQ6UduXlYMm84LFM1+C53Zd4+3CYWVgEibonC+mKvHo+QrpQNKpr6nfrkn3pdY+ 7sOsaDoI5FAkzd40PI7MUVWG8C8wk+ON1W4Fygngosg8LU5l5LSA0nSk0jisnnansQgh Ov3PcDgglKHzvxqQS+INU8gDqGh1Z1XW/YXM7EtBHQ8e4i43HqL9FxitMtXNyZTNIsV/ RFhNp/wQwfBveHuDbg3wlzSU+M2tVoFdX4lm9uZtvd+Zj1gSnlT8rBnb6LoNTi2om1Z3 AWVcHcEnJOoMkFI+n04+VIwVz1cMlasKLKrLjgHv7xf1B2QfnPTTOwTe/q+yLPedGquv /F3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=94mwMcPTU0fA4GC+JR+9ZWgjXzSQUOmYw33Hhdzn4ZY=; b=mLZy6yI4NFyb4gYTXBhLZjH5PFbqbNdm/3GZ/pSNBYq1aHGf5R/ItWMA6CdRiUDt23 q6qXb516FJ1BWQgErWlRFGhTEzAZK+oGvv7VWl7/hoN2DJc4kh0yTasHOgsFyZ4rA0iZ Diw7CBLUPywmLakPph3aoYV2MMF1mHa9O3mAE5mQ640WAii1jlNGjENlNGBi+4UeuU6P 2uUYkd9/HG0vQkttTgI0+rmL/aTw7tScjU6ZObyq+n7Q6T1uJg34narBY76KL5l/jIpE eaSPs6JHy8rPOYeSr7uUxiNh2P/MYXKmJr7J4NQZhK2lsbGAOOmP956IVa0KZ9OmpOd2 onCQ== X-Gm-Message-State: ACrzQf0ikapUfVphlGw8mdF4r68ffGge70VxjCwIXBRfaskj/7jK5YH4 7TLvoSJmgrsCO6asbyhXbCnkQA== X-Google-Smtp-Source: AMsMyM68CmHG8MAbjGQCkuqDxcQYTAxCVd79Bsg/zhnTRlr1jiMxC2JAlMKCjvGfJEcUGXlkG0MctA== X-Received: by 2002:ac2:5b10:0:b0:4a2:5c4b:100c with SMTP id v16-20020ac25b10000000b004a25c4b100cmr91556lfn.406.1664982167969; Wed, 05 Oct 2022 08:02:47 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id k6-20020a2eb746000000b0026a92616cd2sm887853ljo.35.2022.10.05.08.02.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Oct 2022 08:02:47 -0700 (PDT) Message-ID: <6f11e588-c899-8d5d-1ef1-22535d251901@linaro.org> Date: Wed, 5 Oct 2022 17:02:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH] greatlakes: dts: Add Facebook greatlakes (AST2600) BMC Content-Language: en-US To: Delphine_CC_Chiu/WYHQ/Wiwynn , "joel@jms.id.au" Cc: "patrickw3@fb.com" , "garnermic@fb.com" , Delphine Chiu/WYHQ/Wiwynn , Arnd Bergmann , Olof Johansson , "soc@kernel.org" , Rob Herring , Krzysztof Kozlowski , Andrew Jeffery , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-aspeed@lists.ozlabs.org" , Bonnie Lo/WYHQ/Wiwynn References: <20220915072304.1438-1-Bonnie_Lo@Wiwynn.com> <10176630-3ff7-54f7-8836-779e5a2bf6d4@linaro.org> <61de4c6c-84e9-345a-495d-4d44d9351d84@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221005_080256_197074_21D63A3A X-CRM114-Status: GOOD ( 14.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05/10/2022 10:43, Delphine_CC_Chiu/WYHQ/Wiwynn wrote: >> On 20/09/2022 09:45, Bonnie Lo/WYHQ/Wiwynn wrote: >>> Hi Krzysztof, >>> >>> I revise the device tree as following and resend the mail. >>> It create a new mail thread " [PATCH] ARM: dts: aspeed: greatlakes: Add >> Facebook greatlakes (AST2600) BMC". >>> Kindly to correct me, if there is any problem. >>> >>>> Use subject prefixes matching the subsystem (git log --oneline -- ...). >>>> >>>>> >>>>> Add linux device tree entry related to greatlakes specific devices >>>>> connected to BMC SoC. >>>> >>>> Please wrap commit message according to Linux coding style / >>>> submission >>>> process: >>>> https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Feli >>>> >> xir.b%2F&data=05%7C01%7CBonnie_Lo%40wiwynn.com%7Ca2eecb3c2d >> ff4eff >>>> >> 361b08da9ae190fd%7Cda6e0628fc834caf9dd273061cbab167%7C0%7C0%7C6 >> 379925 >>>> >> 90848633103%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQI >> joiV2luM >>>> >> zIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=MJn >> u2iv19 >>>> dvbcMH7SJSExKOFV18dUtGRFSKO6Au2tFg%3D&reserved=0 >>>> >> ootlin.com%2Flinux%2Fv5.18-rc4%2Fsource%2FDocumentation%2Fprocess%2 >>>> >> Fsubmitting-patches.rst%23L586&data=05%7C01%7CBonnie_Lo%40wiw >>>> >> ynn.com%7C1dee8dcb540a49522fb608da98cdba6f%7Cda6e0628fc834caf9dd >>>> >> 273061cbab167%7C0%7C0%7C637990306620286314%7CUnknown%7CTWFp >>>> >> bGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI >>>> >> 6Mn0%3D%7C3000%7C%7C%7C&sdata=mC2E3dJbuYgXklS%2Fw8s2w%2 >>>> BKH%2BZ3CsZSndFTgPBjyvpw%3D&reserved=0 >>>> >>> >>> I have add " ARM: dts: aspeed: greatlakes:". >>> >>>>> >>>>> Signed-off-by: Bonnie Lo >>>>> --- >>>>> arch/arm/boot/dts/Makefile | 1 + >>>>> .../dts/aspeed-bmc-facebook-greatlakes.dts | 248 >>>> ++++++++++++++++++ >>>> >>>> Missing documentation of board compatible (bindings) as first patch. >> >> Why did you ignore it? > > We need to look at this more. There might be something under the Documentation tree. > Could you guide us an example for adding the document? https://lore.kernel.org/all/?q=s%3A%22dt-bindings%3A+arm%3A%22 Fix your email server so it won't add footers making open-source collaboration not possible. You said that this email "contains proprietary or confidential information", therefore it is not suitable for open-source discussions. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel