From: Mike Leach <mike.leach@arm.com>
To: Rob Herring <robh@kernel.org>, Karl Mehltretter <kmehltretter@gmail.com>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>,
James Clark <james.clark@linaro.org>, Leo Yan <leo.yan@arm.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
nd@arm.com
Subject: Re: [PATCH] dt-bindings: arm: Fix CoreSight CTI Kconfig symbol
Date: Wed, 23 Sep 2026 11:34:33 +0100 [thread overview]
Message-ID: <6f30e580-6ef6-48cc-ba3c-f6c48dc72b38@arm.com> (raw)
In-Reply-To: <20260916195703.GA1353861-robh@kernel.org>
On 9/16/26 20:57, Rob Herring wrote:
> On Sat, Aug 22, 2026 at 10:19:12AM +0200, Karl Mehltretter wrote:
>> The option exposing CoreSight CTI integration registers is
>> CONFIG_CORESIGHT_CTI_INTEGRATION_REGS, not
>> CONFIG_CORESIGHT_CTI_INTEGRATION_TEST.
>
> DT bindings should not be referring to kernel kconfig symbols (or
> anything else in the kernel) in the first place.
>
Agreed - the comment in general is correct but the last sentence in the
paragraph should drop the config reference. e.g.
"This information might be found by using the CTI Integration Test
registers to explore the trigger connections between CTI and other
CoreSight components."
The coresight/KConfig file itself adequately documents adding this
support and the perils therein.
Mike
> Rob
prev parent reply other threads:[~2026-09-23 10:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-22 8:19 [PATCH] dt-bindings: arm: Fix CoreSight CTI Kconfig symbol Karl Mehltretter
2026-09-16 19:57 ` Rob Herring
2026-09-23 10:34 ` Mike Leach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f30e580-6ef6-48cc-ba3c-f6c48dc72b38@arm.com \
--to=mike.leach@arm.com \
--cc=conor+dt@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=james.clark@linaro.org \
--cc=kmehltretter@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=leo.yan@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nd@arm.com \
--cc=robh@kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox