From: Krzysztof Kozlowski <krzk@kernel.org>
To: Pritam Manohar Sutar <pritam.sutar@samsung.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
alim.akhtar@samsung.com
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
rosa.pila@samsung.com, dev.tailor@samsung.com,
faraz.ata@samsung.com, muhammed.ali@samsung.com,
selvarasu.g@samsung.com
Subject: Re: [PATCH v2 3/3] arm64: dts: exynos: ExynosAutov920: Enable USB nodes
Date: Thu, 22 Jan 2026 14:35:03 +0100 [thread overview]
Message-ID: <6f381f88-3a51-4fc8-844c-41b167b07628@kernel.org> (raw)
In-Reply-To: <20260122130721.205664-4-pritam.sutar@samsung.com>
On 22/01/2026 14:07, Pritam Manohar Sutar wrote:
> Enable USB PHY and DWC3 USB controllers' nodes.
>
> Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com>
> ---
> .../boot/dts/exynos/exynosautov920-sadk.dts | 21 +++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> index f90f7704597c..5896dd69334a 100644
> --- a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> +++ b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> @@ -160,15 +160,20 @@ &xtcxo {
> &usbdrd31_ssphy {
> dvdd-supply = <&dummy_regulator>;
> vdd18-supply = <&dummy_regulator>;
> + status = "okay";
You just added the node in the previous patch, so why it cant be enavled
there?
> };
>
> &usbdrd31_hsphy {
> dvdd-supply = <&dummy_regulator>;
> vdd18-supply = <&dummy_regulator>;
> vdd33-supply = <&dummy_regulator>;
> + status = "okay";
> };
>
> &usbdrd31_dwc3 {
> + dr_mode = "otg";
> + usb-role-switch;
> + role-switch-default-mode = "peripheral";
Why did you add incomplete node in previous commit?
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-01-22 13:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20260122125130epcas5p4ac37f540c609f3016ff02f5708e897a2@epcas5p4.samsung.com>
2026-01-22 13:07 ` [PATCH v2 0/3] Add and enable USB nodes for ExynosAutov920 SoC Pritam Manohar Sutar
2026-01-22 13:07 ` [PATCH v2 1/3] arm64: dts: exynos: ExynosAutov920: Add USB and USB-phy nodes Pritam Manohar Sutar
2026-01-22 13:07 ` [PATCH v2 2/3] arm64: dts: exynos: ExynosAutov920: Add regulators for the USB Pritam Manohar Sutar
2026-01-22 13:34 ` Krzysztof Kozlowski
2026-02-12 11:37 ` pritam.sutar
2026-02-15 8:57 ` Krzysztof Kozlowski
2026-02-18 9:28 ` pritam.sutar
2026-02-18 19:54 ` Krzysztof Kozlowski
2026-03-04 7:46 ` pritam.sutar
2026-03-04 8:08 ` Krzysztof Kozlowski
2026-01-22 13:07 ` [PATCH v2 3/3] arm64: dts: exynos: ExynosAutov920: Enable USB nodes Pritam Manohar Sutar
2026-01-22 13:35 ` Krzysztof Kozlowski [this message]
2026-01-23 7:29 ` Pritam Manohar Sutar
2026-01-23 7:59 ` Pritam Manohar Sutar
2026-01-23 8:05 ` Krzysztof Kozlowski
2026-02-12 11:40 ` pritam.sutar
2026-01-28 7:36 ` Krzysztof Kozlowski
2026-02-12 11:42 ` pritam.sutar
2026-01-22 17:15 ` [PATCH v2 0/3] Add and enable USB nodes for ExynosAutov920 SoC Rob Herring
2026-01-23 6:23 ` Pritam Manohar Sutar
2026-01-23 7:31 ` Krzysztof Kozlowski
2026-02-12 11:48 ` pritam.sutar
2026-01-28 7:38 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f381f88-3a51-4fc8-844c-41b167b07628@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=dev.tailor@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=faraz.ata@samsung.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=muhammed.ali@samsung.com \
--cc=pritam.sutar@samsung.com \
--cc=robh@kernel.org \
--cc=rosa.pila@samsung.com \
--cc=selvarasu.g@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox