From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E25BC433F5 for ; Wed, 20 Oct 2021 02:37:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 103D7604E9 for ; Wed, 20 Oct 2021 02:37:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 103D7604E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GooGJkv5Z6FIEn6Pkzs3rAabkAk6vIKRlBvRc6r9lOA=; b=p7mqHQysBfHnU+ ZVEC9IJIpgVEBQ98jQYCSsNOfz4dlbeoGmPUfnku2yFmcIfkI0fknoWOCulE0dY2XZl6zpfqIL0du esiECNzzY/hfSfatQktVNe3PJ8keH3mJL8lbYgrb9PRs//HgCYfkeB7ABBAanyT3qQtO159cm4Bo/ 62NeFZ2NC0OXxSzDrI5c8kgfaNoztE4zixcEQNtIGyvAgxC8M2jYeaamNkEntw1mGO2Zf1pFihqxN ZrK7FM+DlmSS8mGTH3yRzt1PA52vxkP2Pkeo+AKfopEzGTWeZM8yJx+QcuaLlZlTjeS3Amlge2VO4 p9SP6bSOBeybencQLSOA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1md1S7-003GjG-Fq; Wed, 20 Oct 2021 02:35:39 +0000 Received: from out30-57.freemail.mail.aliyun.com ([115.124.30.57]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1md1S3-003Gid-IJ for linux-arm-kernel@lists.infradead.org; Wed, 20 Oct 2021 02:35:37 +0000 X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R741e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=e01e04426; MF=xuesong.chen@linux.alibaba.com; NM=1; PH=DS; RN=14; SR=0; TI=SMTPD_---0Ut.30UJ_1634697329; Received: from 30.225.212.40(mailfrom:xuesong.chen@linux.alibaba.com fp:SMTPD_---0Ut.30UJ_1634697329) by smtp.aliyun-inc.com(127.0.0.1); Wed, 20 Oct 2021 10:35:30 +0800 Message-ID: <6f6c2933-b0a7-4fac-6342-3860f022229f@linux.alibaba.com> Date: Wed, 20 Oct 2021 10:35:29 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v3 2/2] ACPI: APEI: Filter the PCI MCFG address with an arch-agnostic method To: Bjorn Helgaas Cc: catalin.marinas@arm.com, lorenzo.pieralisi@arm.com, james.morse@arm.com, will@kernel.org, rafael@kernel.org, tony.luck@intel.com, bp@alien8.de, mingo@kernel.org, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20211019150405.GA2338201@bhelgaas> From: Xuesong Chen In-Reply-To: <20211019150405.GA2338201@bhelgaas> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211019_193535_816307_9C3DD7CB X-CRM114-Status: GOOD ( 26.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 19/10/2021 23:04, Bjorn Helgaas wrote: > On Tue, Oct 19, 2021 at 12:50:33PM +0800, Xuesong Chen wrote: >> The commit d91525eb8ee6 ("ACPI, EINJ: Enhance error injection tolerance >> level") fixes the issue that the ACPI/APEI can not access the PCI MCFG >> address on x86 platform, but this issue can also happen on other >> architectures, for instance, we got below error message on arm64 platform: >> ... >> APEI: Can not request [mem 0x50100000-0x50100003] for APEI EINJ Trigger registers >> ... >> >> This patch will try to handle this case in a more common way instead of the >> original 'arch' specific solution, which will be beneficial to all the >> APEI-dependent platforms after that. >> >> Signed-off-by: Xuesong Chen >> Reported-by: kernel test robot > > The purpose of this patch is not to fix a problem reported by the > kernel test robot, so remove this tag. Yes, will do > > I know the robot found a problem with a previous version of this > patch, but we treat that the same as a code review comment. We > normally don't explicitly credit reviewers unless it was something > major, and then it would go in the commit log, not a "Reported-by" > tag. > > It makes sense to credit the kernel test robot for things found in > Linus' tree, but it's a little too aggressive about suggesting the tag > for problems with unmerged changes. > >> Reviewed-by: Lorenzo Pieralisi > > This tag can only be added when Lorenzo explicitly supplies it > himself. I do not see that on the mailing list, so please remove this > tag as well. After Lorenzo supplies it, you can include it in future > postings as long as you don't make significant changes to the patch. En, Lorenzo does have comments on the patch#2 and I also update that patch according to his feedback, so why the tag is here. OK, I'll add this tag if Lorenzo can supply it explicitly before I send the next version. > > Bjorn > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel