* [PATCH v2 0/3] Update MT8188 OVL compatible from MT8183 to MT8195
@ 2024-12-13 9:50 Jason-JH.Lin
2024-12-13 9:50 ` [PATCH v2 1/3] dt-bindings: display: mediatek: ovl: Modify rules for MT8195/MT8188 Jason-JH.Lin
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Jason-JH.Lin @ 2024-12-13 9:50 UTC (permalink / raw)
To: Chun-Kuang Hu, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Matthias Brugger, AngeloGioacchino Del Regno, Jason-JH . Lin,
Singo Chang, Nancy Lin, Shawn Sung, dri-devel, linux-mediatek,
devicetree, linux-kernel, linux-arm-kernel,
Project_Global_Chrome_Upstream_Group, Fei Shao, Pin-yen Lin
This patch series updates the compatible strings for the MediaTek OVL
in the MT8188 dts and the corresponding dt-binding.
The changes ensure that the MT8188 OVL device is correctly identified
and managed by the appropriate drivers.
The 1st patch is resending the reviewed and acked patch from:
- https://lore.kernel.org/all/5d9e6f6c-604d-4e2d-a448-fc5b8bd24a75@collabora.com/
and rebase it to the latest linux-next-20241212.
The 2nd and the 3rd patches are updating the mt8188.dtsi and mt8195.dtsi
according to the 1st patch.
---
Change in v2:
1. Add missing mt8195 compatible in the beginning of compatible property.
2. Add fix patch to mt8195.
---
Hsiao Chien Sung (1):
dt-bindings: display: mediatek: ovl: Modify rules for MT8195/MT8188
Jason-JH.Lin (2):
dts: arm64: mediatek: mt8188: Update OVL compatible from MT8183 to
MT8195
dts: arm64: mediatek: mt8195: Remove MT8183 compatible for OVL
.../bindings/display/mediatek/mediatek,ovl.yaml | 9 ++++-----
arch/arm64/boot/dts/mediatek/mt8188.dtsi | 2 +-
arch/arm64/boot/dts/mediatek/mt8195.dtsi | 2 +-
3 files changed, 6 insertions(+), 7 deletions(-)
--
2.43.0
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2 1/3] dt-bindings: display: mediatek: ovl: Modify rules for MT8195/MT8188
2024-12-13 9:50 [PATCH v2 0/3] Update MT8188 OVL compatible from MT8183 to MT8195 Jason-JH.Lin
@ 2024-12-13 9:50 ` Jason-JH.Lin
2024-12-19 11:09 ` AngeloGioacchino Del Regno
2024-12-19 11:45 ` AngeloGioacchino Del Regno
2024-12-13 9:50 ` [PATCH v2 2/3] dts: arm64: mediatek: mt8188: Update OVL compatible from MT8183 to MT8195 Jason-JH.Lin
2024-12-13 9:50 ` [PATCH v2 3/3] dts: arm64: mediatek: mt8195: Remove MT8183 compatible for OVL Jason-JH.Lin
2 siblings, 2 replies; 11+ messages in thread
From: Jason-JH.Lin @ 2024-12-13 9:50 UTC (permalink / raw)
To: Chun-Kuang Hu, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Matthias Brugger, AngeloGioacchino Del Regno, Jason-JH . Lin,
Singo Chang, Nancy Lin, Shawn Sung, dri-devel, linux-mediatek,
devicetree, linux-kernel, linux-arm-kernel,
Project_Global_Chrome_Upstream_Group, Fei Shao, Pin-yen Lin
From: Hsiao Chien Sung <shawn.sung@mediatek.com>
Modify rules for both MT8195 and MT8188.
Hardware capabilities include color formats and AFBC are
changed since MT8195, stop using the settings of MT8183.
Acked-by: Rob Herring <robh@kernel.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com>
Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
---
.../bindings/display/mediatek/mediatek,ovl.yaml | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml
index 9ea796a033b2..8ca8e5966b9a 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml
@@ -26,6 +26,7 @@ properties:
- mediatek,mt8173-disp-ovl
- mediatek,mt8183-disp-ovl
- mediatek,mt8192-disp-ovl
+ - mediatek,mt8195-disp-ovl
- mediatek,mt8195-mdp3-ovl
- items:
- enum:
@@ -36,16 +37,14 @@ properties:
- enum:
- mediatek,mt6795-disp-ovl
- const: mediatek,mt8173-disp-ovl
- - items:
- - enum:
- - mediatek,mt8188-disp-ovl
- - mediatek,mt8195-disp-ovl
- - const: mediatek,mt8183-disp-ovl
- items:
- enum:
- mediatek,mt8186-disp-ovl
- mediatek,mt8365-disp-ovl
- const: mediatek,mt8192-disp-ovl
+ - items:
+ - const: mediatek,mt8188-disp-ovl
+ - const: mediatek,mt8195-disp-ovl
reg:
maxItems: 1
--
2.43.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v2 2/3] dts: arm64: mediatek: mt8188: Update OVL compatible from MT8183 to MT8195
2024-12-13 9:50 [PATCH v2 0/3] Update MT8188 OVL compatible from MT8183 to MT8195 Jason-JH.Lin
2024-12-13 9:50 ` [PATCH v2 1/3] dt-bindings: display: mediatek: ovl: Modify rules for MT8195/MT8188 Jason-JH.Lin
@ 2024-12-13 9:50 ` Jason-JH.Lin
2024-12-13 10:26 ` Pin-yen Lin
2024-12-13 9:50 ` [PATCH v2 3/3] dts: arm64: mediatek: mt8195: Remove MT8183 compatible for OVL Jason-JH.Lin
2 siblings, 1 reply; 11+ messages in thread
From: Jason-JH.Lin @ 2024-12-13 9:50 UTC (permalink / raw)
To: Chun-Kuang Hu, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Matthias Brugger, AngeloGioacchino Del Regno, Jason-JH . Lin,
Singo Chang, Nancy Lin, Shawn Sung, dri-devel, linux-mediatek,
devicetree, linux-kernel, linux-arm-kernel,
Project_Global_Chrome_Upstream_Group, Fei Shao, Pin-yen Lin
The OVL hardware capabilities have changed starting from MT8195,
making the MT8183 compatible no longer applicable.
Therefore, it is necessary to update the OVL compatible from MT8183 to
MT8195.
Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
---
arch/arm64/boot/dts/mediatek/mt8188.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8188.dtsi b/arch/arm64/boot/dts/mediatek/mt8188.dtsi
index faccc7f16259..23ec3ff6cad9 100644
--- a/arch/arm64/boot/dts/mediatek/mt8188.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8188.dtsi
@@ -2488,7 +2488,7 @@ jpeg_decoder: jpeg-decoder@1a040000 {
};
ovl0: ovl@1c000000 {
- compatible = "mediatek,mt8188-disp-ovl", "mediatek,mt8183-disp-ovl";
+ compatible = "mediatek,mt8188-disp-ovl", "mediatek,mt8195-disp-ovl";
reg = <0 0x1c000000 0 0x1000>;
clocks = <&vdosys0 CLK_VDO0_DISP_OVL0>;
interrupts = <GIC_SPI 636 IRQ_TYPE_LEVEL_HIGH 0>;
--
2.43.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v2 3/3] dts: arm64: mediatek: mt8195: Remove MT8183 compatible for OVL
2024-12-13 9:50 [PATCH v2 0/3] Update MT8188 OVL compatible from MT8183 to MT8195 Jason-JH.Lin
2024-12-13 9:50 ` [PATCH v2 1/3] dt-bindings: display: mediatek: ovl: Modify rules for MT8195/MT8188 Jason-JH.Lin
2024-12-13 9:50 ` [PATCH v2 2/3] dts: arm64: mediatek: mt8188: Update OVL compatible from MT8183 to MT8195 Jason-JH.Lin
@ 2024-12-13 9:50 ` Jason-JH.Lin
2024-12-13 10:27 ` Pin-yen Lin
2 siblings, 1 reply; 11+ messages in thread
From: Jason-JH.Lin @ 2024-12-13 9:50 UTC (permalink / raw)
To: Chun-Kuang Hu, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Matthias Brugger, AngeloGioacchino Del Regno, Jason-JH . Lin,
Singo Chang, Nancy Lin, Shawn Sung, dri-devel, linux-mediatek,
devicetree, linux-kernel, linux-arm-kernel,
Project_Global_Chrome_Upstream_Group, Fei Shao, Pin-yen Lin
The OVL hardware capabilities have changed starting from MT8195,
making the MT8183 compatible no longer applicable.
Therefore, it is necessary to remove the MT8183 compatible for OVL.
Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
---
arch/arm64/boot/dts/mediatek/mt8195.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
index ade685ed2190..137ee8929e01 100644
--- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
@@ -3138,7 +3138,7 @@ larb20: larb@1b010000 {
};
ovl0: ovl@1c000000 {
- compatible = "mediatek,mt8195-disp-ovl", "mediatek,mt8183-disp-ovl";
+ compatible = "mediatek,mt8195-disp-ovl";
reg = <0 0x1c000000 0 0x1000>;
interrupts = <GIC_SPI 636 IRQ_TYPE_LEVEL_HIGH 0>;
power-domains = <&spm MT8195_POWER_DOMAIN_VDOSYS0>;
--
2.43.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v2 2/3] dts: arm64: mediatek: mt8188: Update OVL compatible from MT8183 to MT8195
2024-12-13 9:50 ` [PATCH v2 2/3] dts: arm64: mediatek: mt8188: Update OVL compatible from MT8183 to MT8195 Jason-JH.Lin
@ 2024-12-13 10:26 ` Pin-yen Lin
2024-12-13 10:33 ` AngeloGioacchino Del Regno
0 siblings, 1 reply; 11+ messages in thread
From: Pin-yen Lin @ 2024-12-13 10:26 UTC (permalink / raw)
To: Jason-JH.Lin
Cc: Chun-Kuang Hu, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Matthias Brugger, AngeloGioacchino Del Regno, Singo Chang,
Nancy Lin, Shawn Sung, dri-devel, linux-mediatek, devicetree,
linux-kernel, linux-arm-kernel,
Project_Global_Chrome_Upstream_Group, Fei Shao
Hi Jason,
On Fri, Dec 13, 2024 at 5:50 PM Jason-JH.Lin <jason-jh.lin@mediatek.com> wrote:
>
> The OVL hardware capabilities have changed starting from MT8195,
> making the MT8183 compatible no longer applicable.
> Therefore, it is necessary to update the OVL compatible from MT8183 to
> MT8195.
This probably doesn't need an (immediate) respin, but this patch needs:
Fixes: 7075b21d1a8e ("arm64: dts: mediatek: mt8188: Add display nodes
for vdosys0")
>
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8188.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8188.dtsi b/arch/arm64/boot/dts/mediatek/mt8188.dtsi
> index faccc7f16259..23ec3ff6cad9 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8188.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8188.dtsi
> @@ -2488,7 +2488,7 @@ jpeg_decoder: jpeg-decoder@1a040000 {
> };
>
> ovl0: ovl@1c000000 {
> - compatible = "mediatek,mt8188-disp-ovl", "mediatek,mt8183-disp-ovl";
> + compatible = "mediatek,mt8188-disp-ovl", "mediatek,mt8195-disp-ovl";
> reg = <0 0x1c000000 0 0x1000>;
> clocks = <&vdosys0 CLK_VDO0_DISP_OVL0>;
> interrupts = <GIC_SPI 636 IRQ_TYPE_LEVEL_HIGH 0>;
> --
> 2.43.0
>
Regards,
Pin-yen
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 3/3] dts: arm64: mediatek: mt8195: Remove MT8183 compatible for OVL
2024-12-13 9:50 ` [PATCH v2 3/3] dts: arm64: mediatek: mt8195: Remove MT8183 compatible for OVL Jason-JH.Lin
@ 2024-12-13 10:27 ` Pin-yen Lin
2024-12-13 10:33 ` AngeloGioacchino Del Regno
0 siblings, 1 reply; 11+ messages in thread
From: Pin-yen Lin @ 2024-12-13 10:27 UTC (permalink / raw)
To: Jason-JH.Lin
Cc: Chun-Kuang Hu, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Matthias Brugger, AngeloGioacchino Del Regno, Singo Chang,
Nancy Lin, Shawn Sung, dri-devel, linux-mediatek, devicetree,
linux-kernel, linux-arm-kernel,
Project_Global_Chrome_Upstream_Group, Fei Shao
Hi Jason,
On Fri, Dec 13, 2024 at 5:50 PM Jason-JH.Lin <jason-jh.lin@mediatek.com> wrote:
>
> The OVL hardware capabilities have changed starting from MT8195,
> making the MT8183 compatible no longer applicable.
> Therefore, it is necessary to remove the MT8183 compatible for OVL.
Similar to patch 2/3, we need a:
Fixes: b852ee68fd72 ("arm64: dts: mt8195: Add display node for vdosys0")
>
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8195.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> index ade685ed2190..137ee8929e01 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> @@ -3138,7 +3138,7 @@ larb20: larb@1b010000 {
> };
>
> ovl0: ovl@1c000000 {
> - compatible = "mediatek,mt8195-disp-ovl", "mediatek,mt8183-disp-ovl";
> + compatible = "mediatek,mt8195-disp-ovl";
> reg = <0 0x1c000000 0 0x1000>;
> interrupts = <GIC_SPI 636 IRQ_TYPE_LEVEL_HIGH 0>;
> power-domains = <&spm MT8195_POWER_DOMAIN_VDOSYS0>;
> --
> 2.43.0
>
Regards,
Pin-yen
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 2/3] dts: arm64: mediatek: mt8188: Update OVL compatible from MT8183 to MT8195
2024-12-13 10:26 ` Pin-yen Lin
@ 2024-12-13 10:33 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 11+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-12-13 10:33 UTC (permalink / raw)
To: Pin-yen Lin, Jason-JH.Lin
Cc: Chun-Kuang Hu, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Matthias Brugger, Singo Chang, Nancy Lin, Shawn Sung, dri-devel,
linux-mediatek, devicetree, linux-kernel, linux-arm-kernel,
Project_Global_Chrome_Upstream_Group, Fei Shao
Il 13/12/24 11:26, Pin-yen Lin ha scritto:
> Hi Jason,
>
> On Fri, Dec 13, 2024 at 5:50 PM Jason-JH.Lin <jason-jh.lin@mediatek.com> wrote:
>>
>> The OVL hardware capabilities have changed starting from MT8195,
>> making the MT8183 compatible no longer applicable.
>> Therefore, it is necessary to update the OVL compatible from MT8183 to
>> MT8195.
>
> This probably doesn't need an (immediate) respin, but this patch needs:
>
> Fixes: 7075b21d1a8e ("arm64: dts: mediatek: mt8188: Add display nodes
> for vdosys0")
No, because the binding must otherwise get a Fixes tag.
This is not a fix anyway, and is technically adding new features to the MT8188
OVL; without the additional features, the MT8188 is still compatible with the
MT8183 OVL, as much as MT8195.
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>>
>> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
>> ---
>> arch/arm64/boot/dts/mediatek/mt8188.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8188.dtsi b/arch/arm64/boot/dts/mediatek/mt8188.dtsi
>> index faccc7f16259..23ec3ff6cad9 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8188.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8188.dtsi
>> @@ -2488,7 +2488,7 @@ jpeg_decoder: jpeg-decoder@1a040000 {
>> };
>>
>> ovl0: ovl@1c000000 {
>> - compatible = "mediatek,mt8188-disp-ovl", "mediatek,mt8183-disp-ovl";
>> + compatible = "mediatek,mt8188-disp-ovl", "mediatek,mt8195-disp-ovl";
>> reg = <0 0x1c000000 0 0x1000>;
>> clocks = <&vdosys0 CLK_VDO0_DISP_OVL0>;
>> interrupts = <GIC_SPI 636 IRQ_TYPE_LEVEL_HIGH 0>;
>> --
>> 2.43.0
>>
>
> Regards,
> Pin-yen
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 3/3] dts: arm64: mediatek: mt8195: Remove MT8183 compatible for OVL
2024-12-13 10:27 ` Pin-yen Lin
@ 2024-12-13 10:33 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 11+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-12-13 10:33 UTC (permalink / raw)
To: Pin-yen Lin, Jason-JH.Lin
Cc: Chun-Kuang Hu, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Matthias Brugger, Singo Chang, Nancy Lin, Shawn Sung, dri-devel,
linux-mediatek, devicetree, linux-kernel, linux-arm-kernel,
Project_Global_Chrome_Upstream_Group, Fei Shao
Il 13/12/24 11:27, Pin-yen Lin ha scritto:
> Hi Jason,
>
> On Fri, Dec 13, 2024 at 5:50 PM Jason-JH.Lin <jason-jh.lin@mediatek.com> wrote:
>>
>> The OVL hardware capabilities have changed starting from MT8195,
>> making the MT8183 compatible no longer applicable.
>> Therefore, it is necessary to remove the MT8183 compatible for OVL.
>
> Similar to patch 2/3, we need a:
>
> Fixes: b852ee68fd72 ("arm64: dts: mt8195: Add display node for vdosys0")
>
No, we don't, for reasons that are similar to the ones that I explained in the
MT8188 commit.
Besides, this one was already featureful before this commit, so really this is
not worth backporting at all.
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>>
>> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
>> ---
>> arch/arm64/boot/dts/mediatek/mt8195.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
>> index ade685ed2190..137ee8929e01 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
>> @@ -3138,7 +3138,7 @@ larb20: larb@1b010000 {
>> };
>>
>> ovl0: ovl@1c000000 {
>> - compatible = "mediatek,mt8195-disp-ovl", "mediatek,mt8183-disp-ovl";
>> + compatible = "mediatek,mt8195-disp-ovl";
>> reg = <0 0x1c000000 0 0x1000>;
>> interrupts = <GIC_SPI 636 IRQ_TYPE_LEVEL_HIGH 0>;
>> power-domains = <&spm MT8195_POWER_DOMAIN_VDOSYS0>;
>> --
>> 2.43.0
>>
>
> Regards,
> Pin-yen
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: display: mediatek: ovl: Modify rules for MT8195/MT8188
2024-12-13 9:50 ` [PATCH v2 1/3] dt-bindings: display: mediatek: ovl: Modify rules for MT8195/MT8188 Jason-JH.Lin
@ 2024-12-19 11:09 ` AngeloGioacchino Del Regno
2024-12-19 17:26 ` Jason-JH Lin (林睿祥)
2024-12-19 11:45 ` AngeloGioacchino Del Regno
1 sibling, 1 reply; 11+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-12-19 11:09 UTC (permalink / raw)
To: Jason-JH.Lin, Chun-Kuang Hu, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Matthias Brugger, Singo Chang, Nancy Lin, Shawn Sung, dri-devel,
linux-mediatek, devicetree, linux-kernel, linux-arm-kernel,
Project_Global_Chrome_Upstream_Group, Fei Shao, Pin-yen Lin
Il 13/12/24 10:50, Jason-JH.Lin ha scritto:
> From: Hsiao Chien Sung <shawn.sung@mediatek.com>
>
> Modify rules for both MT8195 and MT8188.
> Hardware capabilities include color formats and AFBC are
> changed since MT8195, stop using the settings of MT8183.
>
> Acked-by: Rob Herring <robh@kernel.org>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Reviewed-by: CK Hu <ck.hu@mediatek.com>
> Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com>
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> ---
> .../bindings/display/mediatek/mediatek,ovl.yaml | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml
> index 9ea796a033b2..8ca8e5966b9a 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml
> @@ -26,6 +26,7 @@ properties:
> - mediatek,mt8173-disp-ovl
> - mediatek,mt8183-disp-ovl
> - mediatek,mt8192-disp-ovl
> + - mediatek,mt8195-disp-ovl
> - mediatek,mt8195-mdp3-ovl
> - items:
> - enum:
> @@ -36,16 +37,14 @@ properties:
> - enum:
> - mediatek,mt6795-disp-ovl
> - const: mediatek,mt8173-disp-ovl
> - - items:
> - - enum:
> - - mediatek,mt8188-disp-ovl
> - - mediatek,mt8195-disp-ovl
> - - const: mediatek,mt8183-disp-ovl
> - items:
> - enum:
> - mediatek,mt8186-disp-ovl
> - mediatek,mt8365-disp-ovl
> - const: mediatek,mt8192-disp-ovl
> + - items:
> + - const: mediatek,mt8188-disp-ovl
> + - const: mediatek,mt8195-disp-ovl
>
> reg:
> maxItems: 1
Jason, while doing MDP3 bindings for MT8188, I noticed that the binding for OVL is
missing; can you please add a commit on top of this series adding the following
snippet?
- items:
- const: mediatek,mt8188-mdp3-ovl
- const: mediatek,mt8195-mdp3-ovl
...with a suggested-by tag it's going to be fine :-)
P.S.: Please refer to
https://lore.kernel.org/r/20241218105320.38980-1-angelogioacchino.delregno@collabora.com
Thanks,
Angelo
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: display: mediatek: ovl: Modify rules for MT8195/MT8188
2024-12-13 9:50 ` [PATCH v2 1/3] dt-bindings: display: mediatek: ovl: Modify rules for MT8195/MT8188 Jason-JH.Lin
2024-12-19 11:09 ` AngeloGioacchino Del Regno
@ 2024-12-19 11:45 ` AngeloGioacchino Del Regno
1 sibling, 0 replies; 11+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-12-19 11:45 UTC (permalink / raw)
To: Jason-JH.Lin, Chun-Kuang Hu, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Matthias Brugger, Singo Chang, Nancy Lin, Shawn Sung, dri-devel,
linux-mediatek, devicetree, linux-kernel, linux-arm-kernel,
Project_Global_Chrome_Upstream_Group, Fei Shao, Pin-yen Lin
Il 13/12/24 10:50, Jason-JH.Lin ha scritto:
> From: Hsiao Chien Sung <shawn.sung@mediatek.com>
>
> Modify rules for both MT8195 and MT8188.
> Hardware capabilities include color formats and AFBC are
> changed since MT8195, stop using the settings of MT8183.
>
> Acked-by: Rob Herring <robh@kernel.org>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Reviewed-by: CK Hu <ck.hu@mediatek.com>
> Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com>
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
CK, can you please Ack this so that I can make it go through the mediatek tree
along with the devicetree changes?
Thanks,
Angelo
> ---
> .../bindings/display/mediatek/mediatek,ovl.yaml | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml
> index 9ea796a033b2..8ca8e5966b9a 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml
> @@ -26,6 +26,7 @@ properties:
> - mediatek,mt8173-disp-ovl
> - mediatek,mt8183-disp-ovl
> - mediatek,mt8192-disp-ovl
> + - mediatek,mt8195-disp-ovl
> - mediatek,mt8195-mdp3-ovl
> - items:
> - enum:
> @@ -36,16 +37,14 @@ properties:
> - enum:
> - mediatek,mt6795-disp-ovl
> - const: mediatek,mt8173-disp-ovl
> - - items:
> - - enum:
> - - mediatek,mt8188-disp-ovl
> - - mediatek,mt8195-disp-ovl
> - - const: mediatek,mt8183-disp-ovl
> - items:
> - enum:
> - mediatek,mt8186-disp-ovl
> - mediatek,mt8365-disp-ovl
> - const: mediatek,mt8192-disp-ovl
> + - items:
> + - const: mediatek,mt8188-disp-ovl
> + - const: mediatek,mt8195-disp-ovl
>
> reg:
> maxItems: 1
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: display: mediatek: ovl: Modify rules for MT8195/MT8188
2024-12-19 11:09 ` AngeloGioacchino Del Regno
@ 2024-12-19 17:26 ` Jason-JH Lin (林睿祥)
0 siblings, 0 replies; 11+ messages in thread
From: Jason-JH Lin (林睿祥) @ 2024-12-19 17:26 UTC (permalink / raw)
To: robh@kernel.org, krzk+dt@kernel.org, AngeloGioacchino Del Regno,
chunkuang.hu@kernel.org, conor+dt@kernel.org
Cc: linux-mediatek@lists.infradead.org,
Singo Chang (張興國),
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Shawn Sung (宋孝謙),
Nancy Lin (林欣螢),
dri-devel@lists.freedesktop.org,
Project_Global_Chrome_Upstream_Group,
linux-arm-kernel@lists.infradead.org, matthias.bgg@gmail.com,
fshao@chromium.org, treapking@chromium.org
On Thu, 2024-12-19 at 12:09 +0100, AngeloGioacchino Del Regno wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>
>
> Il 13/12/24 10:50, Jason-JH.Lin ha scritto:
> > From: Hsiao Chien Sung <shawn.sung@mediatek.com>
> >
> > Modify rules for both MT8195 and MT8188.
> > Hardware capabilities include color formats and AFBC are
> > changed since MT8195, stop using the settings of MT8183.
> >
> > Acked-by: Rob Herring <robh@kernel.org>
> > Reviewed-by: AngeloGioacchino Del Regno <
> > angelogioacchino.delregno@collabora.com>
> > Reviewed-by: CK Hu <ck.hu@mediatek.com>
> > Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com>
> > Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> > ---
> > .../bindings/display/mediatek/mediatek,ovl.yaml | 9
> > ++++-----
> > 1 file changed, 4 insertions(+), 5 deletions(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.y
> > aml
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.y
> > aml
> > index 9ea796a033b2..8ca8e5966b9a 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.y
> > aml
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.y
> > aml
> > @@ -26,6 +26,7 @@ properties:
> > - mediatek,mt8173-disp-ovl
> > - mediatek,mt8183-disp-ovl
> > - mediatek,mt8192-disp-ovl
> > + - mediatek,mt8195-disp-ovl
> > - mediatek,mt8195-mdp3-ovl
> > - items:
> > - enum:
> > @@ -36,16 +37,14 @@ properties:
> > - enum:
> > - mediatek,mt6795-disp-ovl
> > - const: mediatek,mt8173-disp-ovl
> > - - items:
> > - - enum:
> > - - mediatek,mt8188-disp-ovl
> > - - mediatek,mt8195-disp-ovl
> > - - const: mediatek,mt8183-disp-ovl
> > - items:
> > - enum:
> > - mediatek,mt8186-disp-ovl
> > - mediatek,mt8365-disp-ovl
> > - const: mediatek,mt8192-disp-ovl
> > + - items:
> > + - const: mediatek,mt8188-disp-ovl
> > + - const: mediatek,mt8195-disp-ovl
> >
> > reg:
> > maxItems: 1
>
>
> Jason, while doing MDP3 bindings for MT8188, I noticed that the
> binding for OVL is
> missing; can you please add a commit on top of this series adding the
> following
> snippet?
>
> - items:
> - const: mediatek,mt8188-mdp3-ovl
> - const: mediatek,mt8195-mdp3-ovl
>
> ...with a suggested-by tag it's going to be fine :-)
>
Sure, I'll add one more patch for this in the top of v3.
Regards,
Jason-JH.Lin
> P.S.: Please refer to
>
https://lore.kernel.org/r/20241218105320.38980-1-angelogioacchino.delregno@collabora.com
>
> Thanks,
> Angelo
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2024-12-19 17:29 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-13 9:50 [PATCH v2 0/3] Update MT8188 OVL compatible from MT8183 to MT8195 Jason-JH.Lin
2024-12-13 9:50 ` [PATCH v2 1/3] dt-bindings: display: mediatek: ovl: Modify rules for MT8195/MT8188 Jason-JH.Lin
2024-12-19 11:09 ` AngeloGioacchino Del Regno
2024-12-19 17:26 ` Jason-JH Lin (林睿祥)
2024-12-19 11:45 ` AngeloGioacchino Del Regno
2024-12-13 9:50 ` [PATCH v2 2/3] dts: arm64: mediatek: mt8188: Update OVL compatible from MT8183 to MT8195 Jason-JH.Lin
2024-12-13 10:26 ` Pin-yen Lin
2024-12-13 10:33 ` AngeloGioacchino Del Regno
2024-12-13 9:50 ` [PATCH v2 3/3] dts: arm64: mediatek: mt8195: Remove MT8183 compatible for OVL Jason-JH.Lin
2024-12-13 10:27 ` Pin-yen Lin
2024-12-13 10:33 ` AngeloGioacchino Del Regno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox