From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A8E35C433EF for ; Wed, 8 Jun 2022 19:35:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject:From: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rmUaQYE54DBL3jAoCgZ7ORd7Sjdi8UTD31BZWEZZMWE=; b=JNMC7faFPL8udX 9/TAGPnnwPrkgDQ877aVLZQPyJq8/F4AnS4RuQ7di4VupiU6Q/paUXtokXi4eBEmiIN6PG7u6qwQg XeKeSc6hqVauzBprA+eTbhZt0ZMtTrvvWckv0aW8V1VU4QpFmDtTazZxOsgR9kKWAl8D/J+gAVA60 aFU5TSatU1HVd0P3ozu+GmsfuK/x04h1Hzmv6oIihH3Yrtw8iwz6k7pHrrZ94sHDwr9Pb+MPSvoNf tKRKdzgzLRvMpCEiHqKUUhk5Ly80WAUpdcYu5qIXDwr88e95Lqf2b+9uUrmLFQW5B0Ur9vEvU3Q2g S5NeBnjzeSE2DGgmksUg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nz1R5-00Eo26-7R; Wed, 08 Jun 2022 19:33:47 +0000 Received: from linux.microsoft.com ([13.77.154.182]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nz1R2-00Eo1g-Tq for linux-arm-kernel@lists.infradead.org; Wed, 08 Jun 2022 19:33:46 +0000 Received: from [10.16.8.184] (unknown [131.107.147.184]) by linux.microsoft.com (Postfix) with ESMTPSA id A896E20BE665; Wed, 8 Jun 2022 12:33:41 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com A896E20BE665 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1654716821; bh=9VPqD11Y0U15W613gU8t13a2O2PKBaCp3UdzdYQ4GpQ=; h=Date:From:Subject:To:Cc:References:In-Reply-To:From; b=WhxkAlfE/Arw1RbLOc7GEnlQmI2Ol2oj9XSLISpdfl1thZVJCkxMpYubDUAIfp6gg qzT1HybGTMPU538EVfXltAv3LCVgFXVxdeKXiiAmKKD3USU/q0s8/vVNvxd6sOBC9s 6eAoj0OttVQQb2g3fgR8EyvCwRtYvdmQyszSk3gk= Message-ID: <6f9e1481-db9c-cd5f-c38d-bdcd3040315f@linux.microsoft.com> Date: Wed, 8 Jun 2022 12:33:41 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 From: Dhananjay Phadke Subject: Re: [PATCH 5/5] crypto: aspeed: add HACE crypto driver To: Neal Liu , Herbert Xu , "David S . Miller" , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Johnny Huang Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-crypto@vger.kernel.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20220601054204.1522976-1-neal_liu@aspeedtech.com> <20220601054204.1522976-6-neal_liu@aspeedtech.com> Content-Language: en-US In-Reply-To: <20220601054204.1522976-6-neal_liu@aspeedtech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220608_123345_034652_EB7E3669 X-CRM114-Status: UNSURE ( 5.34 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/6/2022 8:43 PM, Neal Liu wrote: >>> +struct aspeed_hace_alg { >>> + struct aspeed_hace_dev *hace_dev; >>> + union { >>> + struct skcipher_alg skcipher; >>> + struct aead_alg aead; >>> + struct ahash_alg ahash; >>> + struct kpp_alg kpp; >>> + struct akcipher_alg akcipher; >> >> Your patch dont do any kpp or akcipher (and aead/skcipher also). >> Please drop this. > > I miss this part, I'll revise it in next patch, thanks. Hi Neal, Are you planning to submit aead separately? HW programming interface for aes-gcm is almost same as other aes modes except extra regs/fields for tag etc. Thanks, Dhananjay _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel