From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B02DC83F12 for ; Mon, 28 Aug 2023 15:36:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Message-ID:MIME-Version:To:Cc: Date:In-Reply-To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=bWtKxoIggWBbvWWg4sO/DE3PQGsYCbvSt+sTJGe3TUg=; b=svNaPOBBANpPXC KWUUcM1AXsqM2pRoakIqpXZiYRZ+T/Ki8l/vYydc9e/EsRjqf8cuukMNrWNMt1uhC06FhT5cPjj/0 79U0vtcfpR653GIHPwkRNzAyALaZBYF3sb0UOWNwPHmTERVM5IM27uUVF6LU/a3BPVhSRbyCvEiU0 GtSQLBbowOvWcEvM4Vyw3I1NJ6cfjUqVB47/4DyMQiiIZWPSiT+B7lBlzJeWFLG/CAfiJCYdKCgJ5 CnPp0C8wJnnKj4wnJblnw1wCthGxkTvwVK7zWnkVDFeocGOp500aQBpQG1H6cvgfPWlWXcUi7oEMH Ae6WttyqBEW8Q4f2lhcQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qaeHJ-009o4H-34; Mon, 28 Aug 2023 15:35:45 +0000 Received: from madras.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e5ab]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qaeHF-009o3c-0P for linux-arm-kernel@lists.infradead.org; Mon, 28 Aug 2023 15:35:44 +0000 Received: from hamburger.collabora.co.uk (hamburger.collabora.co.uk [IPv6:2a01:4f8:1c1c:f269::1]) by madras.collabora.co.uk (Postfix) with ESMTP id 033C0660716E; Mon, 28 Aug 2023 16:35:36 +0100 (BST) From: "Helen Mae Koike Fornazier" In-Reply-To: <20230825-it66121_edid-v1-1-3ab54923e472@ti.com> X-Forward: 127.0.0.1 Date: Mon, 28 Aug 2023 16:35:36 +0100 Cc: "Phong LE" , "Neil Armstrong" , "Andrzej Hajda" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "David Airlie" , "Daniel Vetter" , "Nicolas Belin" , =?utf-8?q?Andy=2EHsieh?= , nm@ti.com, "Aradhya Bhatia" , devarsht@ti.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org To: "Jai Luthra" MIME-Version: 1.0 Message-ID: <6fd4-64ecbf00-7-213b7840@157890373> Subject: =?utf-8?q?Re=3A?= [PATCH] =?utf-8?q?drm=3A?==?utf-8?q?_bridge=3A?= =?utf-8?q?_it66121=3A?= Fix invalid connector dereference User-Agent: SOGoMail 5.8.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230828_083542_975625_1DC900C4 X-CRM114-Status: GOOD ( 12.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Friday, August 25, 2023 08:02 -03, Jai Luthra wrote: > Fix the NULL pointer dereference when no monitor is connected, and the > sound card is opened from userspace. > > Instead return an error as EDID information cannot be provided to > the sound framework if there is no connector attached. > > Fixes: e0fd83dbe924 ("drm: bridge: it66121: Add audio support") > Reported-by: Nishanth Menon > Closes: https://lore.kernel.org/all/20230825105849.crhon42qndxqif4i@gondola/ > Signed-off-by: Jai Luthra Reviewed-by: Helen Koike > --- > drivers/gpu/drm/bridge/ite-it66121.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c > index 466641c77fe9..d6fa00dea464 100644 > --- a/drivers/gpu/drm/bridge/ite-it66121.c > +++ b/drivers/gpu/drm/bridge/ite-it66121.c > @@ -1446,6 +1446,11 @@ static int it66121_audio_get_eld(struct device *dev, void *data, > { > struct it66121_ctx *ctx = dev_get_drvdata(dev); > > + if (!ctx->connector) { > + dev_dbg(dev, "No connector present, cannot provide EDID data"); > + return -EINVAL; > + } > + > mutex_lock(&ctx->lock); > > memcpy(buf, ctx->connector->eld, > > --- > base-commit: 6269320850097903b30be8f07a5c61d9f7592393 > change-id: 20230825-it66121_edid-6ee98517808b > > Best regards, > -- > Jai Luthra > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel