From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A0DDC31E46 for ; Wed, 12 Jun 2019 12:30:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CFE2F20874 for ; Wed, 12 Jun 2019 12:30:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OgXDjSBp"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=st.com header.i=@st.com header.b="mjxkuclj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CFE2F20874 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:To:From:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vYnG3GgnIn1xjb5ar3+NIIHHo198vRvkYp07sRk8XyQ=; b=OgXDjSBp1w7A79 zAp8ZTdor5InJN0M56dqGggl9aNODw05ZpqdpdJMlcvKhXQF+QZ3k7YTa/RCcq1r67oDhwuLrVT4B Huwf0ZNzAHVCGnZ6yvE7lTYeovyqmASXppBBXbX7bQCwj+Od9X4G+p9N9wdX2X2eFIekZ868qf0it LqXyouRHew0qJAgBuZLDaWHxrJirXTuIMyQn6hdUftUkXEpI1Lkx6cjAPs+4+7bSlOg609nquKHv1 v24RhONMR/W11ol53+02pYgXJzceTzVh8R9N4lNEohSHZ6wSztjqIMn5tmChsfSItyebLZ60P1yYf hMOgbYSHhFzQdkrhMrDA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hb2OI-0001zB-5W; Wed, 12 Jun 2019 12:30:10 +0000 Received: from mx07-00178001.pphosted.com ([62.209.51.94]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hb2OE-0000ja-0i for linux-arm-kernel@lists.infradead.org; Wed, 12 Jun 2019 12:30:08 +0000 Received: from pps.filterd (m0046037.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x5CCLeHk031270; Wed, 12 Jun 2019 14:30:00 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=subject : from : to : cc : references : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=STMicroelectronics; bh=uzCtDAjBrL+1vZ61l6aZvXQ4DLiHhDO5NcE7f5ZHrV4=; b=mjxkucljzxAUHj2FgtiNV1hqjOQZJlu5AT7lQvpD9DL415dfBHy3T26A9vzP7rPEFQwp i85TbeaRuAW4ihjecSNylDmocBdjY5MbLdAX3D0q2roChQg63/iwRIA0i1Q0BQvCsub8 j0dlY3HyL9IEmVAA46N8aLAQUFhmNerrtp4ME5wXtBUmsPn1NNUFWX1uEqxhhULJUXp5 DJo2ThnnvzFzyPRPTdu0wTLyujCU/juTlitsLqr0fDJP4mNenKVwmnaeI3vzsi06xl2V zjfRDFE4ZckshHoHz0uar2gVlgnVhnihDpEQSBS2bWM79PtchXVjkCcf8HrnKKU1479q rg== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 2t2k3c41wm-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 12 Jun 2019 14:30:00 +0200 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 67EF538; Wed, 12 Jun 2019 12:29:59 +0000 (GMT) Received: from Webmail-eu.st.com (sfhdag5node3.st.com [10.75.127.15]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 494E82963; Wed, 12 Jun 2019 12:29:59 +0000 (GMT) Received: from [10.48.0.167] (10.75.127.49) by SFHDAG5NODE3.st.com (10.75.127.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 12 Jun 2019 14:29:58 +0200 Subject: Re: [PATCH v2] i2c: i2c-stm32f7: fix the get_irq error cases From: Fabrice Gasnier To: , References: <1558020594-1498-1-git-send-email-fabrice.gasnier@st.com> Message-ID: <6fe9c4cc-d7ed-aad8-b8f8-240a4888aaa8@st.com> Date: Wed, 12 Jun 2019 14:29:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <1558020594-1498-1-git-send-email-fabrice.gasnier@st.com> Content-Language: en-US X-Originating-IP: [10.75.127.49] X-ClientProxiedBy: SFHDAG5NODE2.st.com (10.75.127.14) To SFHDAG5NODE3.st.com (10.75.127.15) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-06-12_07:, , signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190612_053006_563841_AAA801E5 X-CRM114-Status: GOOD ( 20.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.torgue@st.com, marc.w.gonzalez@free.fr, linux-kernel@vger.kernel.org, fabien.dessenne@st.com, linux-i2c@vger.kernel.org, mcoquelin.stm32@gmail.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/16/19 5:29 PM, Fabrice Gasnier wrote: > During probe, return the "get_irq" error value instead of -EINVAL which > allows the driver to be deferred probed if needed. > Fix also the case where of_irq_get() returns a negative value. > Note : > On failure of_irq_get() returns 0 or a negative value while > platform_get_irq() returns a negative value. > > Fixes: aeb068c57214 ("i2c: i2c-stm32f7: add driver") > > Reviewed-by: Pierre-Yves MORDRET > Signed-off-by: Fabien Dessenne > Signed-off-by: Fabrice Gasnier > --- > Changes in v2: > - Also check for irq == 0 that means "does not exist" as pointed out by > Marc Hi Wolfram, all, Gentle ping on this patch Best Regards, Fabrice > --- > drivers/i2c/busses/i2c-stm32f7.c | 26 ++++++++++++++------------ > 1 file changed, 14 insertions(+), 12 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c > index 4284fc9..d7d7dd7 100644 > --- a/drivers/i2c/busses/i2c-stm32f7.c > +++ b/drivers/i2c/busses/i2c-stm32f7.c > @@ -25,7 +25,6 @@ > #include > #include > #include > -#include > #include > #include > #include > @@ -1812,15 +1811,14 @@ static struct i2c_algorithm stm32f7_i2c_algo = { > > static int stm32f7_i2c_probe(struct platform_device *pdev) > { > - struct device_node *np = pdev->dev.of_node; > struct stm32f7_i2c_dev *i2c_dev; > const struct stm32f7_i2c_setup *setup; > struct resource *res; > - u32 irq_error, irq_event, clk_rate, rise_time, fall_time; > + u32 clk_rate, rise_time, fall_time; > struct i2c_adapter *adap; > struct reset_control *rst; > dma_addr_t phy_addr; > - int ret; > + int irq_error, irq_event, ret; > > i2c_dev = devm_kzalloc(&pdev->dev, sizeof(*i2c_dev), GFP_KERNEL); > if (!i2c_dev) > @@ -1832,16 +1830,20 @@ static int stm32f7_i2c_probe(struct platform_device *pdev) > return PTR_ERR(i2c_dev->base); > phy_addr = (dma_addr_t)res->start; > > - irq_event = irq_of_parse_and_map(np, 0); > - if (!irq_event) { > - dev_err(&pdev->dev, "IRQ event missing or invalid\n"); > - return -EINVAL; > + irq_event = platform_get_irq(pdev, 0); > + if (irq_event <= 0) { > + if (irq_event != -EPROBE_DEFER) > + dev_err(&pdev->dev, "Failed to get IRQ event: %d\n", > + irq_event); > + return irq_event ? irq_event : -ENODEV; > } > > - irq_error = irq_of_parse_and_map(np, 1); > - if (!irq_error) { > - dev_err(&pdev->dev, "IRQ error missing or invalid\n"); > - return -EINVAL; > + irq_error = platform_get_irq(pdev, 1); > + if (irq_error <= 0) { > + if (irq_error != -EPROBE_DEFER) > + dev_err(&pdev->dev, "Failed to get IRQ error: %d\n", > + irq_error); > + return irq_error ? irq_error : -ENODEV; > } > > i2c_dev->clk = devm_clk_get(&pdev->dev, NULL); > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel