Re: [PATCH v2 2/4] dt-bindings: gpio: realtek: Add realtek,rtd1625-gpio

Krzysztof Kozlowski
2026-04-09T07:44:04Z

On Wed, Apr 08, 2026 at 10:52:41AM +0800, Yu-Chun Lin wrote:
> +maintainers:
> + - Tzuyi Chang <tychang@realtek.com>
> +
> +description: |
> + GPIO controller for the Realtek RTD1625 SoC, featuring a per-pin register
> + architecture that differs significantly from earlier RTD series controllers.
> + Each GPIO has dedicated registers for configuration (direction, input/output
> + values, debounce), and interrupt control supporting edge and level detection
> + modes.
> +
> +properties:
> + compatible:
> + enum:
> + - realtek,rtd1625-iso-gpio
> + - realtek,rtd1625-isom-gpio
> +
> + reg:
> + maxItems: 1
> + description: |
> + Memory region containing both interrupt control and GPIO
> + configuration registers in a contiguous address space.
> +
> + For realtek,rtd1625-iso-gpio:
> + - Base + 0x0 ~ 0xff: Interrupt control registers
> + - Base + 0x100 ~ 0x397: GPIO configuration registers
> +
> + For realtek,rtd1625-isom-gpio:
> + - Base + 0x0 ~ 0x1f: Interrupt control registers
> + - Base + 0x20 ~ 0x2f: GPIO configuration registers

Drop description, you are duplicating here DTS. Bindings do not need to
serve as reference manual for the device.

However when you state them like this and give them names, I have the
same concerns as last time - please consult your datasheet whether this
is really one address space.

With description dropped:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof