From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 698E8C83F26 for ; Tue, 29 Jul 2025 15:16:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1woUM6253HhOkGOXmV7WBVDROMJIvM70GbXNiLz7AlI=; b=g/SomAXjOPoA5XnKGQkScNooqk cEZlRMymTIU703MOY5vEiZ/Es7ZMlkLC1f8EOjfq7nVyLzGrFsN+kD+gpRGoP5kewCmrrSYkNa9+e 0UlqcIbLpXhcspkNdHcLES3OoDvEULXOtlHTLqKRKsfFsFR6qkVOzi1iirZKFIKJ9zMbrsqtAwzPh kAvywe66L5NHWQYf/xv324ikDtK5B+nIwpssnwKf7OUZvFTNdZXAwzJJ+v0Fp9HUmcOJCZ1yJXrXj tCdwfFIJbDT7wFqdBT2O082/9ky0gdAHcJL+wt8f9T7oAs7/V9Wds7czK7AWNP3nLO0B7Boygct3z hLxqqkYg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1ugm3W-0000000H7oX-1kWf; Tue, 29 Jul 2025 15:15:54 +0000 Received: from sender4-pp-f112.zoho.com ([136.143.188.112]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uglz4-0000000H7RA-2c8i; Tue, 29 Jul 2025 15:11:19 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1753801866; cv=none; d=zohomail.com; s=zohoarc; b=I56SF7F8z0bftueuem2tXLE+H6F91SCaEV+NE9hW3wiT5EqdLzT/i/5fRw4EbdZhIBu8wVkuVNiGVfov48igPOySmhbUaeMcVKqnCEzhzz6+oTLt7SJfvj05p7f8INJMwbbbNlaiG22il07NqskLW3/GJy22Qg1PnAO/HH8pFgE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753801866; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=1woUM6253HhOkGOXmV7WBVDROMJIvM70GbXNiLz7AlI=; b=YbhPvWFI40ZiKciiAUcrc4LJf7aANyld2oVX/kSMcu/DO+ZBcnC1JFlpc5iF9owlEpNME1DTCB7TIvR6f62ZTYJdz6LaFHPdkG4GN72zu/WQbTbOjlZX3S0gawuIIT+VG01aZ1oU/17zvr4+2EZL7hKe5UHFQP+0l7T8bHeL8fY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=sebastian.reichel@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1753801866; s=zohomail; d=collabora.com; i=sebastian.reichel@collabora.com; h=Date:Date:From:From:To:To:Cc:Cc:Subject:Subject:Message-ID:References:MIME-Version:Content-Type:In-Reply-To:Message-Id:Reply-To; bh=1woUM6253HhOkGOXmV7WBVDROMJIvM70GbXNiLz7AlI=; b=PH9Y0+bJwXcLfbZFjBJfgzeJY/fpEAwyZETJV1X6XPkxdNg7c06qXhWekSfXCSBK BGSgiIL+038tdrFL0QLEMUxFfH83mTDMH77CAoJnEgkQ1xJFO2POlzZXKp7qQ2RFjOk wueHp8kwLhLWyYZ6cVqCa434bWsoeG2enepZ3Qxc= Received: by mx.zohomail.com with SMTPS id 1753801864766949.2085212725262; Tue, 29 Jul 2025 08:11:04 -0700 (PDT) Received: by venus (Postfix, from userid 1000) id 02441180F0B; Tue, 29 Jul 2025 17:10:59 +0200 (CEST) Date: Tue, 29 Jul 2025 17:10:59 +0200 From: Sebastian Reichel To: Andy Yan Cc: dmitry.baryshkov@oss.qualcomm.com, heiko@sntech.de, hjc@rock-chips.com, mripard@kernel.org, naoki@radxa.com, stephen@radxa.com, cristian.ciocaltea@collabora.com, neil.armstrong@linaro.org, Laurent.pinchart@ideasonboard.com, yubing.zhang@rock-chips.com, krzk+dt@kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, robh@kernel.org, Andy Yan Subject: Re: [PATCH v6 08/10] arm64: dts: rockchip: Add DP1 for rk3588 Message-ID: <6jd6atu7q3ler2irnn5thut5thmpco6pnevkvus3rkhimebfo4@rrtqdk5xtxaw> References: <20250728082846.3811429-1-andyshrk@163.com> <20250728082846.3811429-9-andyshrk@163.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="skirinnxkmu7ofhk" Content-Disposition: inline In-Reply-To: <20250728082846.3811429-9-andyshrk@163.com> X-Zoho-Virus-Status: 1 X-Zoho-Virus-Status: 1 X-Zoho-AV-Stamp: zmail-av-1.4.3/253.35.66 X-ZohoMailClient: External X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250729_081118_720814_4B9F0678 X-CRM114-Status: GOOD ( 15.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --skirinnxkmu7ofhk Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v6 08/10] arm64: dts: rockchip: Add DP1 for rk3588 MIME-Version: 1.0 Hi, On Mon, Jul 28, 2025 at 04:28:33PM +0800, Andy Yan wrote: > From: Andy Yan >=20 > The DP1 is compliant with the DisplayPort Specification > Version 1.4, and share the USBDP combo PHY1 with USB 3.1 > HOST1 controller. >=20 > Signed-off-by: Andy Yan > --- The description matches the TRM: Reviewed-by: Sebastian Reichel Greetings, -- Sebastian >=20 > (no changes since v1) >=20 > .../arm64/boot/dts/rockchip/rk3588-extra.dtsi | 30 +++++++++++++++++++ > 1 file changed, 30 insertions(+) >=20 > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi b/arch/arm64/= boot/dts/rockchip/rk3588-extra.dtsi > index 90414486e466f..691fe941d53a1 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi > @@ -210,6 +210,36 @@ i2s10_8ch: i2s@fde00000 { > status =3D "disabled"; > }; > =20 > + dp1: dp@fde60000 { > + compatible =3D "rockchip,rk3588-dp"; > + reg =3D <0x0 0xfde60000 0x0 0x4000>; > + interrupts =3D ; > + clocks =3D <&cru PCLK_DP1>, <&cru CLK_AUX16M_1>, > + <&cru CLK_DP1>, <&cru MCLK_I2S8_8CH_TX>, > + <&cru MCLK_SPDIF5_DP1>; > + clock-names =3D "apb", "aux", "hdcp", "i2s", "spdif"; > + assigned-clocks =3D <&cru CLK_AUX16M_1>; > + assigned-clock-rates =3D <16000000>; > + resets =3D <&cru SRST_DP1>; > + phys =3D <&usbdp_phy1 PHY_TYPE_DP>; > + power-domains =3D <&power RK3588_PD_VO0>; > + #sound-dai-cells =3D <0>; > + status =3D "disabled"; > + > + ports { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + dp1_in: port@0 { > + reg =3D <0>; > + }; > + > + dp1_out: port@1 { > + reg =3D <1>; > + }; > + }; > + }; > + > hdmi1: hdmi@fdea0000 { > compatible =3D "rockchip,rk3588-dw-hdmi-qp"; > reg =3D <0x0 0xfdea0000 0x0 0x20000>; > --=20 > 2.43.0 >=20 --skirinnxkmu7ofhk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmiI5IMACgkQ2O7X88g7 +pqoyRAAnJKXg8MAqWvb5Ci4nsCz0DWsb3MIFBHOuYG/A+M6maRcDmzCxJebVcNt Wbp+X9x5iDrRdYG3wL2XY3QQEVhodMBQXuMSELlDaJxCjsW8T/b1gdEGQcl4+a3L Iy5HHi9AOzfhPqFwpu1um4fTbjx9BYycvudTUhCuCg3PdQJ8hpuRV25VXBWlOUJA SFpB+Z0xOvDMjAS7QIaCHWp6kRnJ2SJRo165xfMlolQJxbfSFXJpLVEA2RUE9t7A YQC40TvANVAASWbzHvlO5aawsisuR3qrieZSJhJHo/dPKRD6dJ7wAGSzzTAr+f9s N6ubB8SFzJa5e41SOykTnlBlt6dYdm5veoKzu+7SXmu9zDrtiupCP42TvvfvOShh FobaNilhrFORFrUIrTDVLvEobFYWDboFPp8ER+ke//8Pp2Ys4QNFS0mfEKIlEjKn 0NNHM1SAMWdUSC8ySXLHW/lW6QQN/Uz2VycJurX/SiyGVgLjPY0oj+nrm8VXGhMx EkI2PkxLNoNebHL3Dz4KbprFC63gSb2IwAqs4ROonXfWM60yn0egJOr5if21dAC8 EiP9BKuY4u6Jpb7oNeaRXikzZpVmfiV76JRBOFofTI7T3Wbyq+JM04JzlnrptY0X wYhT8mNt+KmTQRdv1Mfz+lAzBj7TWfZhr7zUih2rjQV8OfjciP4= =ZleG -----END PGP SIGNATURE----- --skirinnxkmu7ofhk--