From: Steen Hegelund <steen.hegelund@microchip.com>
To: <baomingtong001@208suo.com>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<lars.povlsen@microchip.com>, <daniel.machon@microchip.com>,
<UNGLinuxDriver@microchip.com>, <horatiu.vultur@microchip.com>
Cc: <netdev@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>
Subject: Re: Fwd: [PATCH] net: microchip: sparx5: Remove unneeded variable
Date: Wed, 14 Jun 2023 13:29:52 +0200 [thread overview]
Message-ID: <700342a6747c9fdf5a80ec37070576ba9da1d9eb.camel@microchip.com> (raw)
In-Reply-To: <d70ab6d10972330290c4c810d61df193@208suo.com>
Hi Bao,
I could not apply your patch as there seems to be no message id in the mail
headers. I also could not find it on patchwork, so it seems like it has been
ignored there.
Could you please resend this with the proper details - otherwise the change
looks good to me.
BR
Steen
On Tue, 2023-06-13 at 17:53 +0800, baomingtong001@208suo.com wrote:
>
> You don't often get email from baomingtong001@208suo.com. Learn why this is
> important
>
>
>
>
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
>
> Fix the following coccicheck warning:
>
> drivers/net/ethernet/microchip/sparx5/sparx5_tc_flower.c:1435:5-8: Unneeded
> variable: "err".
>
> Signed-off-by: Mingtong Bao <baomingtong001@208suo.com>
> ---
> drivers/net/ethernet/microchip/sparx5/sparx5_tc_flower.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_tc_flower.c
> b/drivers/net/ethernet/microchip/sparx5/sparx5_tc_flower.c
> index 3f87a5285a6d..03a9b226c9c5 100644
> --- a/drivers/net/ethernet/microchip/sparx5/sparx5_tc_flower.c
> +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_tc_flower.c
> @@ -1432,7 +1432,6 @@ static int sparx5_tc_flower_template_destroy(struct
> net_device *ndev,
> {
> struct sparx5_port *port = netdev_priv(ndev);
> struct sparx5_tc_flower_template *ftp, *tmp;
> - int err = -ENOENT;
>
> /* Rules using the template are removed by the tc framework */
> list_for_each_entry_safe(ftp, tmp, &port->tc_templates, list) {
> @@ -1447,7 +1446,7 @@ static int sparx5_tc_flower_template_destroy(struct
> net_device *ndev,
> kfree(ftp);
> break;
> }
> - return err;
> + return -ENOENT;
> }
>
> int sparx5_tc_flower(struct net_device *ndev, struct flow_cls_offload *fco,
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
parent reply other threads:[~2023-06-14 11:30 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <d70ab6d10972330290c4c810d61df193@208suo.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=700342a6747c9fdf5a80ec37070576ba9da1d9eb.camel@microchip.com \
--to=steen.hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=baomingtong001@208suo.com \
--cc=daniel.machon@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horatiu.vultur@microchip.com \
--cc=kuba@kernel.org \
--cc=lars.povlsen@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).