From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F31CC4345F for ; Fri, 3 May 2024 09:08:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=j1p7+zXwYX+c5oUNqZhgV5tll0rim6OpAD6i+/hX5Ag=; b=mS6b75lQpAKs8L qvf/uhnLx8owbOF42++LZ584uR9gLK7R9a+0YlQ9nNWI7NJ4OTon5bEg8aNaM+rNnBC8RwQJXEqoD 1zCH4IXOEXCduzHiUf7mQKeWHbCBTCCEmkcuvpae1VylmSsY+VntziKCpCq4ZP2P2F2i37Upc0u5f 0vC0ACn2i9U885SC9yiSLWI48NwQU7TwAkmnN6iI659nlW95Z62FX2yb4/ijrk1QPa7JK7HR0gw16 ANtRlPntkZEowf98tcSo5dqkzKc9V3mg7mkoAn/NacU6+NRJ91EOJffGezohkAclebMy6hqb7tU9i ThqMkMat61h8ZtAFBlyg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2otc-0000000FmST-3GdL; Fri, 03 May 2024 09:08:00 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2otZ-0000000FmRo-1Cgq for linux-arm-kernel@lists.infradead.org; Fri, 03 May 2024 09:07:59 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2200D2F4; Fri, 3 May 2024 02:08:19 -0700 (PDT) Received: from [10.163.34.188] (unknown [10.163.34.188]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9EE153F73F; Fri, 3 May 2024 02:07:48 -0700 (PDT) Message-ID: <7008cd0c-5b65-4289-9015-434cbe3d7e21@arm.com> Date: Fri, 3 May 2024 14:37:45 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] arm64/arch_timer: include Content-Language: en-US To: Puranjay Mohan , Catalin Marinas , Will Deacon , Sumit Garg , Stephen Boyd , Douglas Anderson , "Peter Zijlstra (Intel)" , Thomas Gleixner , Mark Rutland , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Cc: puranjay12@gmail.com References: <20240502123449.2690-1-puranjay@kernel.org> From: Anshuman Khandual In-Reply-To: <20240502123449.2690-1-puranjay@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240503_020757_407972_99E8F7C9 X-CRM114-Status: GOOD ( 15.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/2/24 18:04, Puranjay Mohan wrote: > arch_timer.h includes linux/smp.h to use DEFINE_PER_CPU() and it works > because smp.h includes percpu.h. The next commit will remove percpu.h > from smp.h and it will break this usage. > > Explicitly include percpu.h and remove smp.h But this particular change does not seem to be necessary for changing raw_smp_processor_id() as current_thread_info()->cpu being done in the later patch ? You might still leave header inclusion in arch/arm64/include/asm/smp.h while dropping the per cpu cpu_number ? > > Signed-off-by: Puranjay Mohan > --- > arch/arm64/include/asm/arch_timer.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/include/asm/arch_timer.h b/arch/arm64/include/asm/arch_timer.h > index 934c658ee947..f5794d50f51d 100644 > --- a/arch/arm64/include/asm/arch_timer.h > +++ b/arch/arm64/include/asm/arch_timer.h > @@ -15,7 +15,7 @@ > #include > #include > #include > -#include > +#include > #include > > #include _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel