From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08C9DC001DB for ; Tue, 8 Aug 2023 14:49:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XmdU6Gg6vQSAqc5jPXy8hdcgEjudA53MxawMjrcuM8w=; b=rx6jmOD0ddRuTH Cnd7R27MjD3HGo/NUOeON7qafDzBOesMfWgocY991Qf2cY/pWc3kEXCuU5X9UrUzULvpV6/iU/Au4 8pyW9BGkxQSv3kmPOrYD6dD7VeM0il1dk05ggyy5IIr3g2h3M5ARQasD39YdUsv+TBj2r/eQC6Sio EEUPEPBUoACYbueuZ8lOUWaERjH7R3IMfxMb23sapTdqv7cX3LE0wKkVpbBFyDT+kXv90+iHFnPZv OEQITYe8qL0THUZfWvyi14Lp0omgEfmSizDtQlqNIOtWk61Eeao7/MDt2lT0kiyC4egQ/9DS6gsah fyF2Vdq+zhlZLyz77jxA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qTO1D-002m4g-0R; Tue, 08 Aug 2023 14:49:07 +0000 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qTO19-002m4J-1b for linux-arm-kernel@lists.infradead.org; Tue, 08 Aug 2023 14:49:05 +0000 Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-99c93638322so936870166b.1 for ; Tue, 08 Aug 2023 07:49:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691506141; x=1692110941; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Q24TuyQPIV9JKdXRN8c9UpIkwf6u74tQnVD/uWybcPY=; b=MQoWOmEJBUXFEJt8JuwXZ6O6JkbPdusUwzfJR3Y44NasCqrliPfCWg+s3nwoyy5KqL 8HRY1VNnRjpgqZ/yNvyQYEcOVOSMc/wuGTrXyKugVqm9mdr41Xd+m6arKhY37mFIB8GZ rl855lesaC8F7Jr4DbpMTHc7c3La1iw50Bd6uNBhY1TIw4K6kvAf2NayOkmPuDFDaczx n9KLNfL2xvueGgmJEOZ43CqWmcPPIoMyXhbm+yDmzPm27Qzbz7gn+azdqw7VNhpQ1dw3 Jl/phcNF4kKIKYtiaTa/OVQAsxwnT103VJ16oAvggSdBf11qQZykEOGSNPVI8RtLzoRs 7RHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691506141; x=1692110941; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Q24TuyQPIV9JKdXRN8c9UpIkwf6u74tQnVD/uWybcPY=; b=BfJzu1rAthh2P7uzfY1+k3aQ0ASgIERRjkLnKh+h5Ko/noMO1/Jhs1+VHFPP6poJlp SwIa9a5E9D73pmS8OF+Lfig1kMjk4Zk++YnyT8lfaneRqQ0vwb8w0sfuScTP0lKMwtSE VijY0bfcevRDpr0HQeve+9x0SDI8gAjwIYSnM65smRkuK54ylu23ZfS5IIZrPproA0PN Rgg2sLP/cYI/s4H2c6/C1ZpwD4rjteeps41znw4CxsWran+Aw3xwFEwDXCHJNKacEl18 CTt9uR0BAkTGMEnf0DNaLAwKTRXsQIrEwSyJ8YQEG8kAmF62YDySS600dLbuk8LrikiC gQwA== X-Gm-Message-State: AOJu0Yxh3DKFoGPBZmXZ2lefs0EDN+w8JReLdJHf1IbwlrftLYn3Afuf SHLEGZ4wR4S/t76uaJrfhPZitA== X-Google-Smtp-Source: AGHT+IH+83IRgkTcHHxGdoUT4Se5hAS8eTHNASuvSJa4UvMYgg41Fn4+QsSO9CRbFeCN7dZHSqw6Rg== X-Received: by 2002:a17:906:31d2:b0:99b:50ea:2f96 with SMTP id f18-20020a17090631d200b0099b50ea2f96mr68317ejf.12.1691506140661; Tue, 08 Aug 2023 07:49:00 -0700 (PDT) Received: from [192.168.1.20] ([178.197.222.113]) by smtp.gmail.com with ESMTPSA id le3-20020a170907170300b0099cf840527csm812527ejc.153.2023.08.08.07.48.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Aug 2023 07:49:00 -0700 (PDT) Message-ID: <701ad779-0d1e-e8e6-8eba-294452cfb0bc@linaro.org> Date: Tue, 8 Aug 2023 16:48:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [EXT] Re: [PATCH v4 2/7] arm64: dts: imx8ulp-evk: added nxp secure enclave firmware Content-Language: en-US To: Pankaj Gupta , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "clin@suse.com" , "conor+dt@kernel.org" , "pierre.gondois@arm.com" , Jacky Bai , Clark Wang , Wei Fang , Peng Fan , Bough Chen , "festevam@gmail.com" , dl-linux-imx , "davem@davemloft.net" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Gaurav Jain , "alexander.stein@ew.tq-group.com" , Sahil Malhotra , Aisheng Dong , Varun Sethi References: <20230712121219.2654234-1-pankaj.gupta@nxp.com> <20230712121219.2654234-3-pankaj.gupta@nxp.com> <1ac2fb68-02e0-ddfe-87aa-fcd093779009@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230808_074903_556214_B4FDCE86 X-CRM114-Status: GOOD ( 18.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/08/2023 13:07, Pankaj Gupta wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski >> Sent: Thursday, July 13, 2023 12:08 AM >> To: Pankaj Gupta ; shawnguo@kernel.org; >> s.hauer@pengutronix.de; kernel@pengutronix.de; clin@suse.com; >> conor+dt@kernel.org; pierre.gondois@arm.com; Jacky Bai >> ; Clark Wang ; Wei Fang >> ; Peng Fan ; Bough Chen >> ; festevam@gmail.com; dl-linux-imx > imx@nxp.com>; davem@davemloft.net; robh+dt@kernel.org; >> krzysztof.kozlowski+dt@linaro.org; linux-arm-kernel@lists.infradead.org; >> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Gaurav Jain >> ; alexander.stein@ew.tq-group.com; Sahil Malhotra >> ; Aisheng Dong ; Varun >> Sethi >> Subject: [EXT] Re: [PATCH v4 2/7] arm64: dts: imx8ulp-evk: added nxp secure >> enclave firmware >> >> Caution: This is an external email. Please take care when clicking links or >> opening attachments. When in doubt, report the message using the 'Report >> this email' button >> >> >> On 12/07/2023 14:12, Pankaj Gupta wrote: >>> Added support for NXP secure enclave called EdgeLock Enclave firmware >>> (se-fw) for imx8ulp-evk. >>> >>> Signed-off-by: Pankaj Gupta >>> --- >>> arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 12 +++++++++++- >>> 1 file changed, 11 insertions(+), 1 deletion(-) >>> >>> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi >>> b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi >>> index 3ddc0f3125b3..10ed31974a6f 100644 >>> --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi >>> +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi >>> @@ -114,7 +114,7 @@ sosc: clock-sosc { >>> #clock-cells = <0>; >>> }; >>> >>> - sram@2201f000 { >>> + sram0: sram@2201f000 { >>> compatible = "mmio-sram"; >>> reg = <0x0 0x2201f000 0x0 0x1000>; >>> >>> @@ -161,6 +161,16 @@ s4muap: mailbox@27020000 { >>> #mbox-cells = <2>; >>> }; >>> >>> + ele_fw: se-fw { >>> + compatible = "fsl,imx-ele"; >>> + mboxes = <&s4muap 0 0 &s4muap 1 0>; >>> + mbox-names = "tx", "rx"; >>> + fsl,mu-did = <7>; >>> + fsl,mu-id = <2>; >>> + sram-pool = <&sram0>; >> >> It does not look like you tested the DTS against bindings. Please run `make >> dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst or >> https://www.li/ >> naro.org%2Fblog%2Ftips-and-tricks-for-validating-devicetree-sources-with- >> the-devicetree- >> schema%2F&data=05%7C01%7Cpankaj.gupta%40nxp.com%7Cd13d0b68d01c >> 4d10d8cb08db83070ed2%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0% >> 7C0%7C638247838553225400%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC >> 4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7 >> C%7C%7C&sdata=pO6dnz4aPqVejRNDR0OU4n04hXebyqgrNKg4DPhahI0%3D >> &reserved=0 >> for instructions). > > Tested. Before submitting the patch. > [Pankaj] Accepted. You really tested that patch? Before I waste my time on proving it was not, are you 100% sure that you tested that patch and no new warnings are printed? Or are you just agreeing with me that this time you will test? > Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel