| Refresh |
This website lore-kernel.gnuweeb.org/linux-arm-kernel/7025557.qur2fOT79A@wuerfel/ is currently offline. Cloudflare\'s Always Online™ shows a snapshot of this web page from the Internet Archive\'s Wayback Machine. To check for the live version, click Refresh. |
From: arnd@arndb.de (Arnd Bergmann) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] mtd: cfi: don't warn about broken geometry for !CONFIG_MTD Date: Tue, 24 Nov 2015 23:09:02 +0100 [thread overview] Message-ID: <7025557.qur2fOT79A@wuerfel> (raw) In-Reply-To: <4492128.vrqmf1niG3@wuerfel> The linux/mtd/map.h header file is included by a couple of platform specific files that are built even when CONFIG_MTD is disabled, and we always get warning "No CONFIG_MTD_MAP_BANK_WIDTH_xx selected. No NOR chip support can work" in that case. This adds an #ifdef around the pointless warning, as everything is really fine when we don't build the drivers anyway. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- > I'm actually still getting the warnings for any file that includes <linux/mtd/map.h> > while CONFIG_MTD is disabled. I have a fix now that I'm testing overnight > and plan to post tomorrow, then we can decide whether it should be part of > the same patch, or we should have two separate patches. The patch fixes the remaining warnings I see on ARM randconfigs in this file, and I think it makes sense to keep it as a separate patch, as these are really distinct problems even thought the symptom is the same. Please apply both. diff --git a/include/linux/mtd/map.h b/include/linux/mtd/map.h index 366cf77953b5..58f3ba709ade 100644 --- a/include/linux/mtd/map.h +++ b/include/linux/mtd/map.h @@ -142,7 +142,9 @@ #endif #ifndef map_bankwidth +#ifdef CONFIG_MTD #warning "No CONFIG_MTD_MAP_BANK_WIDTH_xx selected. No NOR chip support can work" +#endif static inline int map_bankwidth(void *map) { BUG();
next prev parent reply other threads:[~2015-11-24 22:09 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-11-23 13:39 [PATCH] mtd: cfi: enforce valid geometry configuration Arnd Bergmann 2015-11-23 22:12 ` Arnd Bergmann 2015-11-24 22:09 ` Arnd Bergmann [this message] 2015-11-30 20:55 ` [PATCH] mtd: cfi: don't warn about broken geometry for !CONFIG_MTD Brian Norris 2015-11-30 21:41 ` Arnd Bergmann 2015-11-30 20:44 ` [PATCH] mtd: cfi: enforce valid geometry configuration Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7025557.qur2fOT79A@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox