From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC0C1E75455 for ; Tue, 3 Oct 2023 12:48:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pj2t18LZuKumcnFghNUJtKYEak1ClgUXolqOS9KGBco=; b=CFfac8oMi83Xam FfCjSKdCQfeTT0dKCeqzCm3gSGuP3Aiu7/qcmWhlH9YGOionKOME3Ucg5dyvgpzAVAdbvUA5WeF1I 19MTMMXHNC2wkzqyMKbVR+lANlJ9/nRH9plnlB71aRjWAeOoltIisisBwPxqXPJC8f40mUMnMZVhe Ul74W/yJg5McJJMHojH3LUvZ/RXaf0KMIJm7j1fl+HYZEbnXzBB30qYkiu/AT/LDhrrytWUQ4JkKj knpU8KAqPkfOaORlcaZ84TtyPts/o/1N1RlFk3Js6lPXbghLOeEOaU8evFeP0R8Ji8meVaP2Y3xvM 0aB9ZYXIsOwdBGQVDVMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qneoh-00Ee39-0j; Tue, 03 Oct 2023 12:47:59 +0000 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qneoe-00Ee26-0L for linux-arm-kernel@lists.infradead.org; Tue, 03 Oct 2023 12:47:57 +0000 Received: by mail-pg1-x532.google.com with SMTP id 41be03b00d2f7-5890aa0573aso468098a12.1 for ; Tue, 03 Oct 2023 05:47:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696337274; x=1696942074; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Vjl1Ep1JqHB2U/AgaW1DmtTzRpgVOsnx8TJ7GUMj9hQ=; b=JCA7MosC+QAVHmDH4aKJ7Yr3ImbLExgOfo6Pqg9a+/BO6rx4/Dp8m6A/JizK7q3eQb zxpm/uY5RSV/qGq/PdxEhg2vQ/Slxd5/GWgCU9acxoZQBsiI/E8rr7pMBYZejo6vYenV Djd2a4Ve+/42agaJ9EYePyGsxIR1J+WeGTP/8UGreoEbfV3BCkjgxxisdF+Fvpga/62X 82T2Tcv8/DBva2Hiq/XjCjWhdjMdZDweVAXLi+XV54U5ajSn9CxNwttgFQsMdpf+vxp/ BMedmb9imG+w+NAd9sG20EtxVshRZ6Nh4GYLu/TFqFrfK0SMGr772A2DM5vh8hhfE1Fm 960w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696337274; x=1696942074; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Vjl1Ep1JqHB2U/AgaW1DmtTzRpgVOsnx8TJ7GUMj9hQ=; b=W5CHD55hnFVUCDg5BZF6cr8S4yZ34K3/QWMHeIfo76IxH6Flf8L5I6dhK01KZiGBlo BZBxp3zJbtJRVwiCQiZaE45+SLR+IxD2ENEDsZqTUK37zceyY58oKjS8j26lYXEC3Hum JB+MXWFfXnsCHNbOhk2SlB/JbZjGfo66Dy0SJCY/b1qZbmFQ4M792UwbV+pB670UToEc FUBfR3Chru3yKG1IweWNABUtxxPLJF23MQrY+ZObAplzCVur/SwCeT7VtdryXZLAAKMz wFbaV7r3z8GCnORbiDdRq5fHX7v/twWHmCItmnSX7Egwo1pluofOqhiRLjL2Xao1vYzk mdXQ== X-Gm-Message-State: AOJu0YwHpAeqTYao3YkJ5YabVPCwG7ctcItDx+fayQVIE/16cxnx8+V6 RO+G+6caqO1eudhKLbZYV60= X-Google-Smtp-Source: AGHT+IGXpyVVBkt4ltfXSecY1pXkuWIkChNBZU/8K5myl+wp5qa4gSCF4OHfYwz2XfejSCpnSGjJmQ== X-Received: by 2002:a05:6a20:1008:b0:14d:cca3:a100 with SMTP id gs8-20020a056a20100800b0014dcca3a100mr11444815pzc.36.1696337273833; Tue, 03 Oct 2023 05:47:53 -0700 (PDT) Received: from [172.16.116.58] ([103.15.228.93]) by smtp.gmail.com with ESMTPSA id u11-20020a170902b28b00b001b890009634sm1436879plr.139.2023.10.03.05.47.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Oct 2023 05:47:53 -0700 (PDT) Message-ID: <706a8f30-847c-2641-aeee-6c4d4692e573@gmail.com> Date: Tue, 3 Oct 2023 18:17:48 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v6 1/3] dt-bindings: Add beaglecc1352 Content-Language: en-US To: Nishanth Menon Cc: greybus-dev@lists.linaro.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, vaishnav@beagleboard.org, jkridner@beagleboard.org, krzysztof.kozlowski+dt@linaro.org, vigneshr@ti.com, kristo@kernel.org, robh+dt@kernel.org, conor+dt@kernel.org, linux-arm-kernel@lists.infradead.org References: <20231002182454.211165-1-ayushdevel1325@gmail.com> <20231002182454.211165-2-ayushdevel1325@gmail.com> <20231003113017.z3yyjscvvinwnyy7@putdown> From: Ayush Singh In-Reply-To: <20231003113017.z3yyjscvvinwnyy7@putdown> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231003_054756_144723_9B914A11 X-CRM114-Status: GOOD ( 13.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org >> + >> + reset-gpios: >> + maxItems: 1 >> + >> + power-gpios: >> + maxItems: 3 >> + description: >> + The device has three power rails that are exposed on external pins VDDS, >> + VDDR and DCOUPL. > Shouldn't these be regulators? The power rails are input to the MCU, > correct? > The properties should be something like: > vdds-supply > vddr-supply > dcoupl-supply ? (not sure what dcoupl is, but description should provide > that info). > > the gpio controls for those can be modelled by regulator-gpio ? I picked up power lines from "CC13xx/CC26xx Hardware Configuration and PCB Design Considerations Application Report" present under "8.14 Network Processor" of CC1352P7 data sheet. But now looking closer, it doesn't seem like DCOUPL can be supplied externally for CC1352P7 and thus should probably be removed. Also, it seems like for CC1352P7, VDDR must always be supplied internally (The data sheet states: "Internal supply, must be powered from the internal DC/DC converter or the internal LDO"). Thus, it should be safe to remove VDDR as well. That means only VDDS needs to be present for power line. CC13xx/CC26xx Hardware Configuration and PCB Design Considerations Application Report: https://www.ti.com/lit/pdf/swra640 CC1352P7 Data sheet: https://www.ti.com/lit/gpn/CC1352P7 Sincerely, Ayush Singh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel