From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18265E9A762 for ; Tue, 24 Mar 2026 11:10:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ATjFSYCcu4BJBlm0ZzGR/qHWqPTMf4tN63aPgcoL1c8=; b=mf5zX5yrEn35RtFey3poNjri4V SN2cOPRbAqWHGq9Nj1u38vh5r4ag2Cgu2Oy5JJi7gx3NRjEdiwDLNK2wYkCsyOe2FVvGkEcYIVg+1 b9VTlwkn+wapLz/O27rp69bBaIQVuJ+454NNkDJDaMqZjbch2q9cKMm95KgVWNlwYjvo7ZsQeCnnQ 4siACGPCsZKK2nyGHWE2FSMejUMQWq9gUS58jfRXZF62gy1zLKxCWSoerllbHY06FvoC24XbjWJjw eTkGmMczjA9ROLfcKgrHrm+CB/+t/DXEANBB/TOMJgXKvphjUWEMSLv2UTZT4A8gqrPZ513HAfxCh foMZcbsQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w4zdz-00000001G3x-2ZkJ; Tue, 24 Mar 2026 11:09:55 +0000 Received: from fanzine2.igalia.com ([213.97.179.56]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1w4zdw-00000001G2y-2616; Tue, 24 Mar 2026 11:09:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ATjFSYCcu4BJBlm0ZzGR/qHWqPTMf4tN63aPgcoL1c8=; b=GRXHg8IePTtouM+vfGTKaOI4c0 7I7IxhwsAPoTINFRPHSPojPtvLHD/upj9MQ2q+XtQn9DGCp+fF6RhPUkZHeIF1MM4u95xaFD8yLZX /xY8hBjfJ+fpIY1tYXcYlyXEemi43e29kMKPcO0LpqZq7TGdAA0Mp+qVRpQhNRkvdaCsIv8flxJ5f jOBqICo8RHcUnpQGUW7KEaQC8WTgZlQnytFH3XM3pmmw/eZeplvhHiwJP+A82d+n30HA7rhwktHBV AS42MUExSEyVkZ0/RtJ9wKTQMIdoryAxkRjxN3UQw9UXzCewaV7ikWaffuMLr5Ba7LUumwIdjvkxT gguYk8eA==; Received: from [189.7.87.169] (helo=[192.168.0.2]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1w4zda-005J3Y-4l; Tue, 24 Mar 2026 12:09:30 +0100 Message-ID: <707d805f-09bb-46f8-a3a4-d7630028ea2a@igalia.com> Date: Tue, 24 Mar 2026 08:09:22 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 1/5] clk: bcm: rpi: Manage clock rate in prepare/unprepare callbacks To: Stephen Boyd , Chema Casanova , Dave Stevenson , Florian Fainelli , Iago Toral Quiroga , Maxime Ripard , Melissa Wen , Michael Turquette , Nicolas Saenz Julienne , Philipp Zabel , Stefan Wahren Cc: linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Broadcom internal kernel review list , kernel-dev@igalia.com References: <20260312-v3d-power-management-v7-0-9f006a1d4c55@igalia.com> <20260312-v3d-power-management-v7-1-9f006a1d4c55@igalia.com> <177431178481.5403.10860855444629990495@lazor> From: =?UTF-8?Q?Ma=C3=ADra_Canal?= Content-Language: en-US Autocrypt: addr=mcanal@igalia.com; keydata= xsBNBGcCwywBCADgTji02Sv9zjHo26LXKdCaumcSWglfnJ93rwOCNkHfPIBll85LL9G0J7H8 /PmEL9y0LPo9/B3fhIpbD8VhSy9Sqz8qVl1oeqSe/rh3M+GceZbFUPpMSk5pNY9wr5raZ63d gJc1cs8XBhuj1EzeE8qbP6JAmsL+NMEmtkkNPfjhX14yqzHDVSqmAFEsh4Vmw6oaTMXvwQ40 SkFjtl3sr20y07cJMDe++tFet2fsfKqQNxwiGBZJsjEMO2T+mW7DuV2pKHr9aifWjABY5EPw G7qbrh+hXgfT+njAVg5+BcLz7w9Ju/7iwDMiIY1hx64Ogrpwykj9bXav35GKobicCAwHABEB AAHNIE1hw61yYSBDYW5hbCA8bWNhbmFsQGlnYWxpYS5jb20+wsCRBBMBCAA7FiEE+ORdfQEW dwcppnfRP/MOinaI+qoFAmcCwywCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQ P/MOinaI+qoUBQgAqz2gzUP7K3EBI24+a5FwFlruQGtim85GAJZXToBtzsfGLLVUSCL3aF/5 O335Bh6ViSBgxmowIwVJlS/e+L95CkTGzIIMHgyUZfNefR2L3aZA6cgc9z8cfow62Wu8eXnq GM/+WWvrFQb/dBKKuohfBlpThqDWXxhozazCcJYYHradIuOM8zyMtCLDYwPW7Vqmewa+w994 7Lo4CgOhUXVI2jJSBq3sgHEPxiUBOGxvOt1YBg7H9C37BeZYZxFmU8vh7fbOsvhx7Aqu5xV7 FG+1ZMfDkv+PixCuGtR5yPPaqU2XdjDC/9mlRWWQTPzg74RLEw5sz/tIHQPPm6ROCACFls7A TQRnAsMsAQgAxTU8dnqzK6vgODTCW2A6SAzcvKztxae4YjRwN1SuGhJR2isJgQHoOH6oCItW Xc1CGAWnci6doh1DJvbbB7uvkQlbeNxeIz0OzHSiB+pb1ssuT31Hz6QZFbX4q+crregPIhr+ 0xeDi6Mtu+paYprI7USGFFjDUvJUf36kK0yuF2XUOBlF0beCQ7Jhc+UoI9Akmvl4sHUrZJzX LMeajARnSBXTcig6h6/NFVkr1mi1uuZfIRNCkxCE8QRYebZLSWxBVr3h7dtOUkq2CzL2kRCK T2rKkmYrvBJTqSvfK3Ba7QrDg3szEe+fENpL3gHtH6h/XQF92EOulm5S5o0I+ceREwARAQAB wsB2BBgBCAAgFiEE+ORdfQEWdwcppnfRP/MOinaI+qoFAmcCwywCGwwACgkQP/MOinaI+qpI zQf+NAcNDBXWHGA3lgvYvOU31+ik9bb30xZ7IqK9MIi6TpZqL7cxNwZ+FAK2GbUWhy+/gPkX it2gCAJsjo/QEKJi7Zh8IgHN+jfim942QZOkU+p/YEcvqBvXa0zqW0sYfyAxkrf/OZfTnNNE Tr+uBKNaQGO2vkn5AX5l8zMl9LCH3/Ieaboni35qEhoD/aM0Kpf93PhCvJGbD4n1DnRhrxm1 uEdQ6HUjWghEjC+Jh9xUvJco2tUTepw4OwuPxOvtuPTUa1kgixYyG1Jck/67reJzMigeuYFt raV3P8t/6cmtawVjurhnCDuURyhUrjpRhgFp+lW8OGr6pepHol/WFIOQEg== In-Reply-To: <177431178481.5403.10860855444629990495@lazor> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260324_040952_840287_BBAA86D1 X-CRM114-Status: UNSURE ( 7.46 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Stephen, On 23/03/26 21:23, Stephen Boyd wrote: > Quoting Maíra Canal (2026-03-12 14:34:23) >> On current firmware versions, RPI_FIRMWARE_SET_CLOCK_STATE doesn't >> actually power off the clock. To achieve meaningful power savings, the >> clock rate must be set to the minimum before disabling. This might be >> fixed in future firmware releases. >> >> Rather than pushing rate management to clock consumers, handle it >> directly in the clock framework's prepare/unprepare callbacks. In >> unprepare, set the rate to the minimum before disabling the clock. >> In prepare, for clocks marked with `maximize` (currently v3d), >> restore the rate to the maximum after enabling. >> >> Signed-off-by: Maíra Canal >> --- > > Acked-by: Stephen Boyd When possible, could you apply this patch to clk-next? Thank you and Maxime for the reviews! Best regards, - Maíra