From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7637DC7618A for ; Sun, 19 Mar 2023 12:42:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RQ3kIMUbUWrKEOq6icqPDHBakSqZPdTZNV118w7Z7tc=; b=mnxHGOyBiB0kyv E2Ac3SavgR/Qd0jdbbEi57VHopJLVXAxBAlqlSUtcw5GU2HG8W73TJiUmwhV2K7yk7lYXsmxxhFpK 86H+cir2Ovd2gPYH0vyyIQklAIMMe3sXJLR7NUej9dibJndrJNrwx87/eGQNTEYtYqfx8Is1ZlyrO iBSNZZqB/hL0W+kiH/zhrvLNPi+kn3/Ap+u31FFas6UqZNCiy9DebhJ5szq8mKCDWGFX4RK2jolBu p2/cVcwMhMOb94Cr2L9yVs6adqOLbhDoHyveWovtJit/UFuF0S2ODXgHsn26kcgSAoEiRr3MyfDPx O6LyekY8NhUy+ZTM5J3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pdsLJ-006hyL-17; Sun, 19 Mar 2023 12:40:57 +0000 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pdsLE-006hxu-2t for linux-arm-kernel@lists.infradead.org; Sun, 19 Mar 2023 12:40:54 +0000 Received: by mail-ed1-x52e.google.com with SMTP id w9so37010481edc.3 for ; Sun, 19 Mar 2023 05:40:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679229651; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oolnoui9bwD72saRuWz2eUL7PghL9zZD0Mg8CNmPTv8=; b=TU4fToK9xe5RwL9b/rKxUGlthV1NWIQ7hzk1PZnj0tao9+WMFpR0JmIU36YK0ECFK2 GeR1qwIQI5eWG+OlHulbySE96Q9h3EcUUD5+TYc6NgCMu0G7ZkH3CAh6hwYXDERGtBAq Eb/275avjh10RRenfGcJZrR7mq0L2V1ix0oONTR+CliZ1/ZomY0lToOcTsPvzZYP6G9I sogM+TaTXZd1ODii5kGR6C/tk5RfHV5dBf8tpmcUNLm1WDTKUOGF5REN8Xk+HVHq1/fH dW3A41ot2SpKd0T/W50dYuL+Vhq4Vhl4g0kKImCvxixBgiWEglqWy6+CGHYECic3020U iQLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679229651; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oolnoui9bwD72saRuWz2eUL7PghL9zZD0Mg8CNmPTv8=; b=gZzxHIvS+fXRDVyHAmrbs+SHoJV8fjiRXyi+xanlM/BuvezRPgGq2z0nWAaOHmrYyr krmpUyWZexmUzxsu2a8QuXKd0CMnCRZm0Tkng3XyDummULc+663pIiK7vjBcgU+3rs3r 6QN8Q5sO84ypl9G9QZqe3eaiCsKkGwYu7Huau4g+J6lucobTFEHSXsEI4cexXvpyqxme uIpO6mT68HE9ei+Kf6XvCyPXzG1zyAOyLpoJjJNgprum8xZPx1fbTFMCb1f5jwjIAJHo vEupdPalpKhXEYX0LSZ+oVZ9uhAaUAKFJAnjK5a2UN3QXkPOSzL6jX2YNdPlYBEv5v2V sqLA== X-Gm-Message-State: AO0yUKVewot4gPd9J14BjQH+PvCfSh3SlXxox91OKUVCSlP85FnTupvY AAf+cLgLj+g18iQB6PfNOPWBXQ== X-Google-Smtp-Source: AK7set8no1xdwXSt61q0acLXah4PhkPn/qpNih1kHxFoOM8Dm3h51+p3tGWlnneauNyuCVN/2xpqkQ== X-Received: by 2002:aa7:cac8:0:b0:500:4c0e:cb8d with SMTP id l8-20020aa7cac8000000b005004c0ecb8dmr6412475edt.5.1679229651181; Sun, 19 Mar 2023 05:40:51 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:5b5f:f22b:a0b:559d? ([2a02:810d:15c0:828:5b5f:f22b:a0b:559d]) by smtp.gmail.com with ESMTPSA id u4-20020a17090626c400b00924916f9c21sm3182394ejc.87.2023.03.19.05.40.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Mar 2023 05:40:50 -0700 (PDT) Message-ID: <708b63c9-d2b6-c65f-0112-8f50173c0bca@linaro.org> Date: Sun, 19 Mar 2023 13:40:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH V2 4/8] dt-bindings: iio: st-sensors: Add IIS328DQ accelerometer To: Jonathan Cameron , Stefan Wahren Cc: Rob Herring , Krzysztof Kozlowski , Lars-Peter Clausen , Arnd Bergmann , Olof Johansson , Evgeniy Polyakov , Shawn Guo , Sascha Hauer , Fabio Estevam , linux-imx@nxp.com, Li Yang , Denis Ciocca , soc@kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, stefan.wahren@i2se.com References: <20230317103323.7741-1-stefan.wahren@chargebyte.com> <20230317103323.7741-5-stefan.wahren@chargebyte.com> <20230318155534.16b47583@jic23-huawei> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <20230318155534.16b47583@jic23-huawei> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230319_054052_965369_4D5C301F X-CRM114-Status: GOOD ( 19.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 18/03/2023 16:55, Jonathan Cameron wrote: > On Fri, 17 Mar 2023 11:33:19 +0100 > Stefan Wahren wrote: > >> The ST IIS328DQ is an accelerometer sensor, which is compatible with >> the already supported ST H3LIS331DL. So add the new compatible >> with a fallback to the ST sensor binding. >> >> Link: https://lore.kernel.org/linux-iio/2bac9ecf-9d2e-967e-9020-1c950487d781@i2se.com/ >> Suggested-by: Jonathan Cameron >> Signed-off-by: Stefan Wahren >> --- >> Documentation/devicetree/bindings/iio/st,st-sensors.yaml | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/iio/st,st-sensors.yaml b/Documentation/devicetree/bindings/iio/st,st-sensors.yaml >> index c6201976378f..5eb71b24a7cb 100644 >> --- a/Documentation/devicetree/bindings/iio/st,st-sensors.yaml >> +++ b/Documentation/devicetree/bindings/iio/st,st-sensors.yaml >> @@ -48,6 +48,9 @@ properties: >> - st,lsm330d-accel >> - st,lsm330dl-accel >> - st,lsm330dlc-accel >> + - items: >> + - const: st,iis328dq >> + - const: st,h3lis331dl-accel > > Hmm. So this separates the particular 'oneOf' group from the description > associated with the ST accelerometers. > > DT experts, is there a better way to do this? Ideally we'd also associate > other similar groups going forwards so it might become less and less obvious > how the groupings work. (bit late for the many groups that exist > already in that list above this point). If by "grouping" you mean how the oneOf items are organized with descriptions, I wouldn't put too much attention to it. You can add some '#' comments to separate the groups, but for me this is still readable. Acked-by: Krzysztof Kozlowski Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel