From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Herve Codina <herve.codina@bootlin.com>,
Qiang Zhao <qiang.zhao@nxp.com>, Arnd Bergmann <arnd@arndb.de>
Cc: linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] soc: fsl: qe: ucc: Export ucc_mux_set_grant_tsa_bkpt
Date: Thu, 5 Sep 2024 09:31:45 +0200 [thread overview]
Message-ID: <7091c023-c7e6-4b3a-b306-12d73b8f6698@csgroup.eu> (raw)
In-Reply-To: <20240905072215.337010-1-herve.codina@bootlin.com>
Le 05/09/2024 à 09:22, Herve Codina a écrit :
> When TSA is compiled as module the following error is reported:
> "ucc_mux_set_grant_tsa_bkpt" [drivers/soc/fsl/qe/tsa.ko] undefined!
>
> Indeed, the ucc_mux_set_grant_tsa_bkpt symbol is not exported.
>
> Simply export ucc_mux_set_grant_tsa_bkpt.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202409051409.fszn8rEo-lkp@intel.com/
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Acked-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Arnd, it is ok for you to take this patch directly ?
Thanks
Christophe
> ---
> drivers/soc/fsl/qe/ucc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soc/fsl/qe/ucc.c b/drivers/soc/fsl/qe/ucc.c
> index 21dbcd787cd5..892aa5931d5b 100644
> --- a/drivers/soc/fsl/qe/ucc.c
> +++ b/drivers/soc/fsl/qe/ucc.c
> @@ -114,6 +114,7 @@ int ucc_mux_set_grant_tsa_bkpt(unsigned int ucc_num, int set, u32 mask)
>
> return 0;
> }
> +EXPORT_SYMBOL(ucc_mux_set_grant_tsa_bkpt);
>
> int ucc_set_qe_mux_rxtx(unsigned int ucc_num, enum qe_clock clock,
> enum comm_dir mode)
next prev parent reply other threads:[~2024-09-05 7:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 7:22 [PATCH] soc: fsl: qe: ucc: Export ucc_mux_set_grant_tsa_bkpt Herve Codina
2024-09-05 7:31 ` Christophe Leroy [this message]
2024-09-05 9:23 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7091c023-c7e6-4b3a-b306-12d73b8f6698@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=arnd@arndb.de \
--cc=herve.codina@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkp@intel.com \
--cc=qiang.zhao@nxp.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox