From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 635D6C433E2 for ; Tue, 14 Jul 2020 11:45:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 33A6D2220C for ; Tue, 14 Jul 2020 11:45:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jos9HrU8"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="mMHZutoF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 33A6D2220C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Mrl+1AgUwscgryXo8hCF25nM+MgwOYTce/5SrcUKnYE=; b=jos9HrU8ZpRMleFU3gjuBcwQ4 YyxorF0Nvf0PXoWdWIp8jK/7h+gdyhEA5JdgV/d+FaCUrjwH/yNt9S1hEHVKWzMS4P/M6/E/4ZG7p blIlw5kmJkO6qb6yfuAialk2HGIO/HTbLw2tCVrwl0b6g/9WJQZJOLzwqyWR5Vb2Hc6uk53lve2wF mOhRGdGhhdGiy/7jwAX3MxcMIEG+3E+XLRnDs8rPHgWWHylYwOW7kVxqH091Q7tDtOKkJv0Zyibcd 0G2qHCGcLsC3psLGhnwudEtwvmcdZm9FCkVhLYgvhD7HM10jfl25tZUvcFPuwvTft06WQUO/NRd8L Uc5zlcfgw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvJLv-0003Kj-IJ; Tue, 14 Jul 2020 11:44:03 +0000 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvJLt-0003Jy-9f for linux-arm-kernel@lists.infradead.org; Tue, 14 Jul 2020 11:44:02 +0000 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 14 Jul 2020 04:43:47 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Tue, 14 Jul 2020 04:43:59 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 14 Jul 2020 04:43:59 -0700 Received: from [10.24.37.103] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 14 Jul 2020 11:43:51 +0000 Subject: Re: [TEGRA194_CPUFREQ PATCH v5 1/4] dt-bindings: arm: Add t194 ccplex compatible and bpmp property To: Rob Herring References: <1594649209-29394-1-git-send-email-sumitg@nvidia.com> <1594649209-29394-2-git-send-email-sumitg@nvidia.com> <20200713164214.GA341271@bogus> From: Sumit Gupta Message-ID: <70a0a8ee-b79a-2a05-5150-2ee0faaf2730@nvidia.com> Date: Tue, 14 Jul 2020 17:13:47 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200713164214.GA341271@bogus> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1594727027; bh=UrDpE1YD14GDWCNhmIrtodld5JLaTd22aLzUVIM8f98=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=mMHZutoFQHCAIoy3C50Yj8sRZfz8bUZeBCDekvCUEPPE8fsSz4fwzSQExX22vT/cZ CflAgHY7F7DJQ0Ib4eEEBXTwMFoxODxAFuZ7sqHypnZdLsr1h4XhH0RpEetY5HUKUq dpdSChmaeb86JPmxsDAXX5wUYvBjjNXhm6RcDVwsF0ZUP0UzXoU78qq0SEFs+zR/Ak KPnQHXDPepa0yEXM9VUFQMFH/fIJIQfTam+Zy1qhexBLYqL8k6s2t6w8P2vQ65lKZJ m67IHksK0pXbcM+jcJ+j556VUZyo8+yLif9IcjmoS32tdNUvZbpy57tu1db+VDf5g0 mRMvlTySolpVA== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200714_074401_444054_EF6A2E61 X-CRM114-Status: GOOD ( 17.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, mperttunen@nvidia.com, linux-pm@vger.kernel.org, viresh.kumar@linaro.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, mirq-linux@rere.qmqm.pl, talho@nvidia.com, thierry.reding@gmail.com, bbasu@nvidia.com, catalin.marinas@arm.com, linux-tegra@vger.kernel.org, Sumit Gupta , jonathanh@nvidia.com, will@kernel.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > On Mon, Jul 13, 2020 at 07:36:46PM +0530, Sumit Gupta wrote: >> To do frequency scaling on all CPUs within T194 CPU Complex, we need >> to query BPMP for data on valid operating points. Document a compatible >> string under 'cpus' node to represent the CPU Complex for binding drivers >> like cpufreq which don't have their node or CPU Complex node to bind to. >> Also, document a property to point to the BPMP device that can be queried >> for all CPUs. > > The cpus.yaml binding documents what's in 'cpu' nodes, not 'cpus' > node. AIUI, the latter is what you want. You should do your own schema > file here. > Do you mean to change existing file name from 'cpus.yaml' to 'cpu.yaml' and create new 'cpus.yaml' file? I think it's better to incorporate the change in existing 'cpus.yaml' file to keep both cpu@X and cpus node details together. Please suggest. >> >> Signed-off-by: Sumit Gupta >> --- >> Documentation/devicetree/bindings/arm/cpus.yaml | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml >> index a018147..9b328e3 100644 >> --- a/Documentation/devicetree/bindings/arm/cpus.yaml >> +++ b/Documentation/devicetree/bindings/arm/cpus.yaml >> @@ -162,6 +162,7 @@ properties: >> - nvidia,tegra132-denver >> - nvidia,tegra186-denver >> - nvidia,tegra194-carmel >> + - nvidia,tegra194-ccplex > > Tegra194 has 2 different CPUs? > No, T194 SOC has homogeneous architecture with four clusters where each cluster has two symmetric cores. 'nvidia,tegra194-carmel' compatible string represents each cpu. 'nvidia,tegra194-ccplex' string represents the CPU Complex to bind cpufreq driver. The change was done as per discussion [1] >> - qcom,krait >> - qcom,kryo >> - qcom,kryo260 >> @@ -255,6 +256,15 @@ properties: >> >> where voltage is in V, frequency is in MHz. >> >> + nvidia,bpmp: >> + $ref: '/schemas/types.yaml#/definitions/phandle' >> + description: | >> + Specifies the bpmp node that needs to be queried to get >> + operating point data for all CPUs. >> + >> + Optional for systems that have a "compatible" >> + property value of "nvidia,tegra194-ccplex". >> + >> power-domains: >> $ref: '/schemas/types.yaml#/definitions/phandle-array' >> description: >> @@ -340,6 +350,7 @@ required: >> >> dependencies: >> rockchip,pmu: [enable-method] >> + nvidia,bpmp: [compatible] >> >> examples: >> - | >> -- >> 2.7.4 >> [1] https://marc.info/?l=linux-arm-kernel&m=158999171528418&w=2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel