From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A697C54E64 for ; Thu, 28 Mar 2024 08:56:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QjP2NSCkb+DNCYIkYvEN++zhK1qgvyI5x8ZBYkVCA2U=; b=nrucBMkKoy/VgS aP9E/Zpd7xpwjKtxnHH0xCY+ZzjsEBNWocboH4mW/NhMUBcZxiCtQ1kFhd8987ynT1UG1Xpe8Xlr1 Q8rGyymMvFX5eVsmyAECeFdrro4GYQqzF3Q+544UOpMyHmjFrp3caX3pkk0Sic0VjYHcZMAg8dwpX 6tLQ+n0fqn44dhOtYKUg0nJixlssvgZUfo/S6sIOQ9UEtEmiRn7ev/aonbWuuokCyckWYqUXUwQAS nY/OgQ16xYSH+R3AS6vYIj59a/rGWgpyRbWBUiOaYA39zJO5Z7vtMubQHpnal7XicF8iMXwBgv+Es 2Z1CsPGL4zGPTUQbslRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rplYH-0000000DBzH-3ugK; Thu, 28 Mar 2024 08:56:01 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rplYE-0000000DBxt-3BIX for linux-arm-kernel@lists.infradead.org; Thu, 28 Mar 2024 08:56:00 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 42S8tgAX014998; Thu, 28 Mar 2024 03:55:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1711616142; bh=nermr1aimNjYdldtEPQ8fIB5KlP9vorwtOZqf6DA1/E=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=iuXj09aVZaOoqrGOU8cTd5WFAe1jMZRPLDPzZzbku5KxYrdEIxYinYhCyx11atzuj rJoht2CQBPSm3wJP/66GBDFoQMb4haNjImJor1gljkiAAqN6NkchXBd/GHzw5Nk0XU f9WzaOg+dV5B56IAPnxFhH2EACOkTfbCmTe687jQ= Received: from DLEE112.ent.ti.com (dlee112.ent.ti.com [157.170.170.23]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 42S8tfc1085259 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 28 Mar 2024 03:55:42 -0500 Received: from DLEE108.ent.ti.com (157.170.170.38) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Thu, 28 Mar 2024 03:55:41 -0500 Received: from fllvsmtp8.itg.ti.com (10.64.41.158) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Thu, 28 Mar 2024 03:55:41 -0500 Received: from localhost (uda0492258.dhcp.ti.com [172.24.227.9]) by fllvsmtp8.itg.ti.com (8.15.2/8.15.2) with ESMTP id 42S8te7U011065; Thu, 28 Mar 2024 03:55:41 -0500 Date: Thu, 28 Mar 2024 14:25:40 +0530 From: Siddharth Vadapalli To: Bjorn Helgaas CC: Siddharth Vadapalli , , , , , , , , , , , , , , Subject: Re: [PATCH v6] PCI: keystone: Fix pci_ops for AM654x SoC Message-ID: <70ace5d8-1a84-492e-b5af-8b6899dfbace@ti.com> References: <20240326144258.2404433-1-s-vadapalli@ti.com> <20240326232403.GA1502764@bhelgaas> <49077b26-9ca3-4ef7-8b25-8c58adf95f5d@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <49077b26-9ca3-4ef7-8b25-8c58adf95f5d@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240328_015558_925338_00B0092F X-CRM114-Status: GOOD ( 20.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 27, 2024 at 03:01:08PM +0530, Siddharth Vadapalli wrote: > On Tue, Mar 26, 2024 at 06:24:03PM -0500, Bjorn Helgaas wrote: > > On Tue, Mar 26, 2024 at 08:12:58PM +0530, Siddharth Vadapalli wrote: > > > In the process of converting .scan_bus() callbacks to .add_bus(), the > > > ks_pcie_v3_65_scan_bus() function was changed to ks_pcie_v3_65_add_bus(). > > > The .scan_bus() method belonged to ks_pcie_host_ops which was specific > > > to controller version 3.65a, while the .add_bus() method had been added > > > to ks_pcie_ops which is shared between the controller versions 3.65a and > > > 4.90a. Neither the older ks_pcie_v3_65_scan_bus() method, nor the newer > > > ks_pcie_v3_65_add_bus() method is applicable to the controller version > > > 4.90a which is present in AM654x SoCs. > > > > > > Thus, as a fix, move the contents of "ks_pcie_v3_65_add_bus()" to the > > > .msi_init callback "ks_pcie_msi_host_init()" which is specific to the > > > 3.65a controller. Also, move the definitions of ks_pcie_set_dbi_mode() > > > and ks_pcie_clear_dbi_mode() above ks_pcie_msi_host_init() in order to > > > avoid forward declaration. > > > > If it's possible to split this into two patches (one that strictly > > *moves* the code without otherwise changing it, and another that makes > > the actual fix), it would be easier to review the fix. It's a pain to > > have to compare the code in the old location with that in the new > > location. > > Sure. I will do so and post the v7 patch. I have posted the v7 series at: https://lore.kernel.org/r/20240328085041.2916899-1-s-vadapalli@ti.com/ Regards, Siddharth. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel