From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0FA4BCA5501 for ; Wed, 13 Sep 2023 07:14:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=REhDje1AsNQ00yleoVcOoxDU+4hRQqm/YWsQOXb6IqA=; b=KhZd9vL8RDEkzP Lxe+E/ngw1J8QcWDbTkqDrdmCyJb4RCDnfzl8t+ltreCKvWiS5zMZ36VZbaEP4ygqi0VgA0xtHYnU Mh5hBd+WogRCurhKgNk66PtuZbW4MGk9bdA/o5UXphqAdy9KhDjaNKcLi+sQl5IswAE6fldy0OJqR 4XlFF+Py6BbpvkImnD9DnSfkKgk7SZaQV4UyfL+CviGPaNqM+7p/b5nrfI36gPORxXgOJ7EhB2/l4 GwwX4sUpdqxnDUEc7R9gESUGQ4piov2RnqMJy4aRv7eO3EZOn5xvl5HW4+cVYdUFsgoEVF4OWg4cE gsqzZIJCxVvSRmPApFVA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qgK4K-004uP2-2p; Wed, 13 Sep 2023 07:13:48 +0000 Received: from mail-lj1-x235.google.com ([2a00:1450:4864:20::235]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qgK4H-004uNV-13 for linux-arm-kernel@lists.infradead.org; Wed, 13 Sep 2023 07:13:47 +0000 Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2bce552508fso106241931fa.1 for ; Wed, 13 Sep 2023 00:13:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694589223; x=1695194023; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PMH3vpvCAYv9pjz0vyXayvBqBPROq5/ItNXcUQV0q9E=; b=DZzbXwd39luSFeZlggdK3PIWMbNRvGHM2AWy/RRbPg20B5VUD4ttnzEjEJBwKEe9um byzFsbfy8B+VOaskGvTp1uOIch84CwkNeknKtzLBpuiWpKX/HXZu7B61XMNDjQ1Rugu+ Ea6XGMkUse9agwTWIM+VJjZe1UFVjUFdLCwvgUwCyUdKO9wJZDQHYQclvnGbHBou5Rn8 HvmW/42eB5urqYUkqGru+ywGvtJlh4A6h7CFVBR+v8h/Ymk7lMCtjnHiEAvoZ/X3dGtu As0xva7m3eXvO+nyAlq1HXzHZaa2/GPS/k+h3bLkpki/sUCUZG+InERN0JjSY4DoeVK0 DIWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694589223; x=1695194023; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PMH3vpvCAYv9pjz0vyXayvBqBPROq5/ItNXcUQV0q9E=; b=nLn79QP+vJEb9oKoMbVvNJTcqGDalhbpnEG0OVYwwnZAwRLBppCedhj5YyAaMY9vA5 42ggUdGLQThO5/QDTI7nMWfaj8uxUR1mTY6RBLiCSOrXbd64n9DRj2GcLc0PaZnLqnUL Z44kA/n3ZwaRr0QR1siXxJ2qenm9Obqonw5Zxqj8wv8hzJCBViErcFYroRMyqE30aWgG ek0PuOPGh/Dqv12VMFH6HwDpyFqV64ISDidgFMrCNAItnixJwb3zW+TJhzkaV/z/nwBW f4MIb4Ps8RtcezljyPxXAOe3PafwiRaNxdHxbUbuPTH3yb36NjDrOKtlO2khd3kCP6gg gd4Q== X-Gm-Message-State: AOJu0YzzP3y8cSPwu7kmCuHKh4t+FP5fXw3NASkRzlx0aflqtrPOpX6f JULqJLmxlk0pTqhNeRXG3BEGSa3gUcxcYvNXi6A= X-Google-Smtp-Source: AGHT+IEaX2HHUaLs3S63J80qFOSmj6sWOrftUpS+R5qC7Xs/FsBZ7EPgP0pGvUeL/9pDbnFuXmPFwA== X-Received: by 2002:a2e:9e14:0:b0:2bd:1f83:8d4 with SMTP id e20-20020a2e9e14000000b002bd1f8308d4mr1400872ljk.22.1694589223002; Wed, 13 Sep 2023 00:13:43 -0700 (PDT) Received: from [192.168.1.20] ([178.197.214.188]) by smtp.gmail.com with ESMTPSA id ce7-20020a170906b24700b0098f99048053sm8015685ejb.148.2023.09.13.00.13.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Sep 2023 00:13:42 -0700 (PDT) Message-ID: <70b2a9d7-1a3e-25da-3d78-7bfa5d3a1e05@linaro.org> Date: Wed, 13 Sep 2023 09:13:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH v2 06/14] arm64: dts: qcom: sdm630: Drop RPM bus clocks Content-Language: en-US To: Konrad Dybcio , Andy Gross , Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , Sibi Sankar , Will Deacon , Robin Murphy , Joerg Roedel , Greg Kroah-Hartman , Wesley Cheng Cc: Marijn Suijten , Alexey Minnekhanov , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-usb@vger.kernel.org References: <20230721-topic-rpm_clk_cleanup-v2-0-1e506593b1bd@linaro.org> <20230721-topic-rpm_clk_cleanup-v2-6-1e506593b1bd@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20230721-topic-rpm_clk_cleanup-v2-6-1e506593b1bd@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230913_001345_403329_134B3F8F X-CRM114-Status: GOOD ( 16.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/09/2023 15:31, Konrad Dybcio wrote: > These clocks are now handled from within the icc framework and are > no longer registered from within the CCF. Remove them. > > Signed-off-by: Konrad Dybcio > --- > arch/arm64/boot/dts/qcom/sdm630.dtsi | 49 +++++++----------------------------- > 1 file changed, 9 insertions(+), 40 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi > index ec6003212c4d..f11d2a07508c 100644 > --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi > @@ -605,9 +605,6 @@ bimc: interconnect@1008000 { > compatible = "qcom,sdm660-bimc"; > reg = <0x01008000 0x78000>; > #interconnect-cells = <1>; > - clock-names = "bus", "bus_a"; > - clocks = <&rpmcc RPM_SMD_BIMC_CLK>, > - <&rpmcc RPM_SMD_BIMC_A_CLK>; Bindings expect here two clocks, so you miss some bindings patches. > }; > > restart@10ac000 { > @@ -619,28 +616,17 @@ cnoc: interconnect@1500000 { > compatible = "qcom,sdm660-cnoc"; > reg = <0x01500000 0x10000>; > #interconnect-cells = <1>; > - clock-names = "bus", "bus_a"; > - clocks = <&rpmcc RPM_SMD_CNOC_CLK>, > - <&rpmcc RPM_SMD_CNOC_A_CLK>; > }; > > snoc: interconnect@1626000 { > compatible = "qcom,sdm660-snoc"; > reg = <0x01626000 0x7090>; > #interconnect-cells = <1>; > - clock-names = "bus", "bus_a"; > - clocks = <&rpmcc RPM_SMD_SNOC_CLK>, > - <&rpmcc RPM_SMD_SNOC_A_CLK>; > }; > > anoc2_smmu: iommu@16c0000 { > compatible = "qcom,sdm630-smmu-v2", "qcom,smmu-v2"; > reg = <0x016c0000 0x40000>; > - > - assigned-clocks = <&rpmcc RPM_SMD_AGGR2_NOC_CLK>; > - assigned-clock-rates = <1000>; > - clocks = <&rpmcc RPM_SMD_AGGR2_NOC_CLK>; > - clock-names = "bus"; This is also against bindings. After your patch #4, such bus clock (or other combinations) is still required. > #global-interrupts = <2>; > #iommu-cells = <1>; > > @@ -685,16 +671,12 @@ a2noc: interconnect@1704000 { > compatible = "qcom,sdm660-a2noc"; > reg = <0x01704000 0xc100>; > #interconnect-cells = <1>; > - clock-names = "bus", > - "bus_a", > - "ipa", > + clock-names = "ipa", And which bindings does this match? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel