From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BC6BC2D0A3 for ; Tue, 27 Oct 2020 00:15:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA96E20754 for ; Tue, 27 Oct 2020 00:15:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PA08Fp51"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="ZWDgA8+y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA96E20754 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uuKIo1+JVj9TcsHtUP0F2xspiz3PxaTEFmQPsq4wGG0=; b=PA08Fp51OrRRikKFxwqoLDSBS F9id/eH1EDeHUspdF+cYvdvc8/tjUaRwXQqFY8Y+/7vRSKAPVHx4pIAn0GKh4M6GdIfN9xBcR3qix sCc2omvaQSfgVYZRJbnbJm2ZHORO+7qK9XNzKd50FoPdjYAoswxFd30/YIN7pQckf0IbmgLv5IGMV dLsA+XP8bcWORZirtVk+ZOFdUwLJ9XOCKHbg4mg26hLH8ZTp+mAeH0IvJa7lhfvl1zTImdOuIsNJn qGV14acK/2fJquZ8JcRSl/DDlYLhM7zfzdgg9ALvnbTIJYcJ9mnI/xQViI4NePYFT0Dcq6JdgzlFs rmP23sEBQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXCbj-0003Ac-Uy; Tue, 27 Oct 2020 00:13:00 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXCLa-0003qX-HY for linux-arm-kernel@lists.infradead.org; Mon, 26 Oct 2020 23:56:23 +0000 Received: by mail-pf1-x443.google.com with SMTP id 10so7115471pfp.5 for ; Mon, 26 Oct 2020 16:56:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=wqqvkA3oKUwkO5eXRPOBy8lXyQg0CiUtokie2wwagwI=; b=ZWDgA8+yUlKx2dZgiyZDe66Bv6aQYo4o4sBrgULvsJ7L1mqryuSoN/tRsTLtRNf5gl QA5GzgrsJ4IIXk6KefYiWNloPp5dTgRya5PAi5H2X1Ck5liCNMZ9plZFbXAFJkRhGENX zRADl3Fzwzqt5UTeMExAEl9+J6C00UJYGVeM9r+kQpMj10I4tNzbDp+KUhpG26z8ohQ5 u9LGW1VxEtuEY5uYo6W0qmYrYYX9WPLdyfh3K/l7hHXtbXds+UPAtJe/6QdzpKUrKNEa IHnev7OPcOoKpcEMuZBXfSj3e5H/bPp0SHxbMGuGbkkGN2ORlWbNlGQCKJOUg6Ub1kcx WOrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wqqvkA3oKUwkO5eXRPOBy8lXyQg0CiUtokie2wwagwI=; b=KJc/1h3XeA3FW4BdFvLOBIdMzXi4aLHcXZvKVOZ3759HuyRex7nzcM/GXHC6tztjBz MXWpBb+rMZMDEUSv8wsjjeM1/MtoW8x07F2cAufKkzvQrKckLVkFwN3KvqzWhBPdY2sC zFBDhi5jlWt+E0yq2xlBfaW3kR7lWTq9e2yk0WuXInIWMa3glkdxvohFf7Ih3Wb+L5dI m8e6Fk5tAdwsCVmLHELmZ0JOIodJp/Q5FY1Ih+G4EP2OzVSORuOKqpVE7+h7oDEP4o+H Mr5DPHGzZhvaoywXRPcTakSam5dH42hI9BdYXvMb7/Um24VE0SRZPufdUK0V/8R03McZ bgDg== X-Gm-Message-State: AOAM532Z98tX3FZYvPqH8tB5/7/zoqF+bin9+cGpuUXXysisxd7IJGe6 +3acgQkZoZQ69hyF1i9G/dUpFA== X-Google-Smtp-Source: ABdhPJzXWytxnG400Dp//klgHvFRu6jftuSrTTs7sW7oWyETnW8LM2mlLlQ2a53Jfzf5mLG9B/rX/w== X-Received: by 2002:a63:5f42:: with SMTP id t63mr569296pgb.0.1603756574857; Mon, 26 Oct 2020 16:56:14 -0700 (PDT) Received: from [192.168.1.134] ([66.219.217.173]) by smtp.gmail.com with ESMTPSA id s38sm3637009pgm.62.2020.10.26.16.56.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Oct 2020 16:56:14 -0700 (PDT) Subject: Re: [REGRESSION] mm: process_vm_readv testcase no longer works after compat_prcoess_vm_readv removed To: Kyle Huey , open list , Christoph Hellwig References: From: Jens Axboe Message-ID: <70d5569e-4ad6-988a-e047-5d12d298684c@kernel.dk> Date: Mon, 26 Oct 2020 17:56:11 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201026_195619_032820_CB3A0682 X-CRM114-Status: GOOD ( 17.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-aio@kvack.org, David Howells , linux-mm@kvack.org, keyrings@vger.kernel.org, sparclinux@vger.kernel.org, Robert O'Callahan , linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, "maintainer:X86 ARCHITECTURE \(32-BIT AND 64-BIT\)" , Linus Torvalds , Arnd Bergmann , linux-block@vger.kernel.org, Alexander Viro , io-uring@vger.kernel.org, "moderated list:ARM PORT" , linux-parisc@vger.kernel.org, netdev@vger.kernel.org, linux-mips@vger.kernel.org, linux-security-module@vger.kernel.org, "open list:FILESYSTEMS \(VFS and infrastructure\)" , Andrew Morton , linuxppc-dev@lists.ozlabs.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/26/20 4:55 PM, Kyle Huey wrote: > A test program from the rr[0] test suite, vm_readv_writev[1], no > longer works on 5.10-rc1 when compiled as a 32 bit binary and executed > on a 64 bit kernel. The first process_vm_readv call (on line 35) now > fails with EFAULT. I have bisected this to > c3973b401ef2b0b8005f8074a10e96e3ea093823. > > It should be fairly straightforward to extract the test case from our > repository into a standalone program. Can you check with this applied? diff --git a/mm/process_vm_access.c b/mm/process_vm_access.c index fd12da80b6f2..05676722d9cd 100644 --- a/mm/process_vm_access.c +++ b/mm/process_vm_access.c @@ -273,7 +273,8 @@ static ssize_t process_vm_rw(pid_t pid, return rc; if (!iov_iter_count(&iter)) goto free_iov_l; - iov_r = iovec_from_user(rvec, riovcnt, UIO_FASTIOV, iovstack_r, false); + iov_r = iovec_from_user(rvec, riovcnt, UIO_FASTIOV, iovstack_r, + in_compat_syscall()); if (IS_ERR(iov_r)) { rc = PTR_ERR(iov_r); goto free_iov_l; -- Jens Axboe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel