From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C4C9C35280 for ; Thu, 7 May 2020 23:40:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 10F9B206B9 for ; Thu, 7 May 2020 23:40:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IPIJGG38"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jJI7iisB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 10F9B206B9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tX6PQlCVAZ5K8kviFWGmZw73Y3vQNxPsqIyCaO0M5Hw=; b=IPIJGG38/PQ92x fKYqXxYQCH2m+Q+lIdttKwG9IrvOEYfeP5kpK3Rmh1ba2CmFWMOH6zSGFUvbFnNAOpxMo5sfS05zt L1oRXqACLNJs5zK+Rnv22N+bRwetTPD8fDWeQg+UI/tgKtbnncidveT7N8SZ/CKOOzfw1jDoW0HSS /38EC/YV+SZn+0Ao7COsxh6PtVsGpjIFlb4J1oejj9Ay8BAQII7jJwAq3BkznnYKJS4vIT+vQI61/ 5ofH/TR6Sx37J8w2SFBuPZTkJY+It5bOAVz7HbtB2Lhn+SD/PQkoNUHciG7RfitQgXWt1sZXQh7N6 HtauyUABiuR8Ddn/Ai8w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWq7k-0004wB-2j; Thu, 07 May 2020 23:40:16 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWq7f-0004q2-O1; Thu, 07 May 2020 23:40:13 +0000 Received: by mail-wm1-x343.google.com with SMTP id h4so8432432wmb.4; Thu, 07 May 2020 16:40:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=LeEjSoC+KWHnDVL+GAb88TtcLPL+vxgTH1UqxiwLGBE=; b=jJI7iisBRN9lUPdFF2pIY3P84wTuq5rziNa8d2Njwyf5twXA4f2pAJ22picElxpgCN RyBGlJMHmqCVyGXHpafltfYuFvjwQjXLeErMK7RbRKwR4i+jSCyDu/Gm9UGj92UXGQQV 4xuAE50GfM5+SUDeyXcWbvxi81C49veMoelfexh+sxYyvi6Xd3Hf9sHZwf2oJcdfqZ4c sj/MaurplX/+lA2Srv921WfXEfqyWGZrz6mDmuGsdFSU76YgtdC4NYP5L4n7Aew+1boG OaND5pJ0wkJhUVj19FxWH28LxXSvtdi1BUQOEzbpOOID4pvqpenZMTLZ0B7mDjS+3XJS cwzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LeEjSoC+KWHnDVL+GAb88TtcLPL+vxgTH1UqxiwLGBE=; b=JW4D841p8sI2aHT9twOg3XSAMQ9OOkb6ruLZyZNRqpejK6299ATgj2Sy1w5hOI3pss D7mRdMnuisDBTQ738MBEGkurNLmnMrkGqpv1PLI2Z1/xVqa52VWJI0pU+ozZZir4b6zv hF3N9sUti5X8kxui/3R6op293qokGNA4sj0zIgCP8VnSpkOwI7vP9uDAN0o3D/XcgwcV uBC8x43LaGGKfAyf69NBPC/x/h4EWOEgRvAapzmfc2vl++s2asUzQcsUrEqsRJCDGsco q7xoSck9w0PrP+rU53W6enbqms+kMPCNgf+aUYW/XUiQRO2WEgM7Am8LnQqjyuMX7/rE 1Nfg== X-Gm-Message-State: AGi0Puag9/uYUOoUOCZhkiN9ygeLr0Bu1fngCJsQUFx+u8CdYjGN8mls Kp5xJzFlh4Kb1ku3/S//E+g= X-Google-Smtp-Source: APiQypIMjl0Gv1T78MM/jPEcJHt9TQ1o4EZ7MA/8Dhv4FzUE6INX4d2J+WXVM11MeDplM6s2Vrwqbg== X-Received: by 2002:a05:600c:22d3:: with SMTP id 19mr13644233wmg.110.1588894810321; Thu, 07 May 2020 16:40:10 -0700 (PDT) Received: from [192.168.2.1] (ip51ccf9cd.speed.planet.nl. [81.204.249.205]) by smtp.gmail.com with ESMTPSA id c128sm10549504wma.42.2020.05.07.16.40.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 May 2020 16:40:09 -0700 (PDT) Subject: Re: [PATCH v3 2/4] arm64: dts: rockchip: Add RGA support to the PX30 To: Paul Kocialkowski References: <20200430164245.1630174-3-paul.kocialkowski@bootlin.com> <20200507202558.GK2422122@aptenodytes> From: Johan Jonker Message-ID: <7112d1fa-a872-c66f-0ece-a77ba1f852de@gmail.com> Date: Fri, 8 May 2020 01:40:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200507202558.GK2422122@aptenodytes> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200507_164011_810981_77774DAB X-CRM114-Status: GOOD ( 18.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, heiko@sntech.de, linux-kernel@vger.kernel.org, hansverk@cisco.com, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, thomas.petazzoni@bootlin.com, mchehab@kernel.org, ezequiel@collabora.com, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Paul, On 5/7/20 10:25 PM, Paul Kocialkowski wrote: > Hi, > > On Fri 01 May 20, 00:05, Johan Jonker wrote: >> Hi Paul, >> >>> The PX30 features a RGA block: add the necessary node to support it. >>> >>> Signed-off-by: Paul Kocialkowski >>> --- >>> arch/arm64/boot/dts/rockchip/px30.dtsi | 11 +++++++++++ >>> 1 file changed, 11 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi >>> index f809dd6d5dc3..3de70aa4f1ce 100644 >>> --- a/arch/arm64/boot/dts/rockchip/px30.dtsi >>> +++ b/arch/arm64/boot/dts/rockchip/px30.dtsi >>> @@ -1102,6 +1102,17 @@ vopl_mmu: iommu@ff470f00 { >>> status = "disabled"; >>> }; >>> >>> + rga: rga@ff480000 { >>> + compatible = "rockchip,px30-rga", "rockchip,rk3288-rga"; >>> + reg = <0x0 0xff480000 0x0 0x10000>; >>> + interrupts = ; >>> + clocks = <&cru ACLK_RGA>, <&cru HCLK_RGA>, <&cru SCLK_RGA_CORE>; >>> + clock-names = "aclk", "hclk", "sclk"; >> >>> + resets = <&cru SRST_RGA>, <&cru SRST_RGA_A>, <&cru SRST_RGA_H>; >>> + reset-names = "core", "axi", "ahb"; >>> + power-domains = <&power PX30_PD_VO>; >> >> sort >> >> power-domains = <&power PX30_PD_VO>; >> resets = <&cru SRST_RGA>, <&cru SRST_RGA_A>, <&cru SRST_RGA_H>; >> reset-names = "core", "axi", "ahb"; > > What's the rationale behind this (besides alphabetic sorting, which I don't > believe is a rule for dt properties)? Some nodes above in the file have it in > the same order that I do, and I like to see clocks followed by resets. My short list. There is no hard rule... It mostly depend on Heiko... For nodes: If exists on top: model, compatible and chosen. Sort things without reg alphabetical first, then sort the rest by reg address. Inside nodes: If exists on top: compatible, reg and interrupts. In alphabetical order the required properties. Then in alphabetical order the other properties. And as last things that start with '#' in alphabetical order. Add status below all other properties for soc internal components with any board-specifics. Keep an empty line between properties and nodes. Exceptions: Sort pinctrl-0 above pinctrl-names, so it stays in line with clock-names and dma-names. Sort simple-audio-card,name above other simple-audio-card properties. Sort regulator-name above other regulator properties. Sort regulator-min-microvolt above regulator-max-microvolt. > > Cheers, > > Paul > >> >> >>> + }; >>> + >>> qos_gmac: qos@ff518000 { >>> compatible = "syscon"; >>> reg = <0x0 0xff518000 0x0 0x20>; >>> -- >>> 2.26.0 >> > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel