From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA7CDC4167B for ; Wed, 29 Nov 2023 10:20:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=toRig7Bk+KNZoIZgvIBgmEqZ2TUwvWdyULJzKHPa/gg=; b=nkeolSyAzyk7Zm FjrJu90LLPvtyM6hGtCXfoJHeftsK4MnI+fVNzVVfuRNZRQMtWfNQyET+rLHn/Vc5MiJIwadBCsY5 XgYdfVk0Pjor2Xq7W5luhe+TinJ0i7XHPlInCA+3u0CwfPArBvyS8LfdekSmMUf1sPWFSAArXpI85 L2g9s3WDvNG+god8ac+BDKH9e1q49AoFgmOKcsdQD/ztT3JU7WOrA9VfGzSYSn59prF14jw3SrFbf 5Lgv1830VIIHkCYezdUWBdKPfLntTQXWUL57AWvEJ4cZMwMb2Vg/AhMBG7LoIA6Ww7It0C7Or/n8K dzBr/mF9OJY+bvwcID7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r8Hfx-007ngK-1j; Wed, 29 Nov 2023 10:20:13 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r8Hfu-007nfZ-0z for linux-arm-kernel@lists.infradead.org; Wed, 29 Nov 2023 10:20:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1701253210; x=1732789210; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=KZkH8bl3BtculFLewEii2JTZkTpl2Gc15g5xYx6zHoQ=; b=Z9DqCNf/6k10xKzhLFM1lpDEiya4zzh8+W7mjBUN5+bmbc0Zq4d40gIG +9AZtgejVTDpkFAbs6HbDZS7wxnL/6+rxK0EQyNVguWPprczA2Jn2lML1 9ILvU1xY6SBufQXG2j1e6+QRZ8i+jgD5ux33938sCK/UcRvibfuDERPlf vIFo/7lkM8Wt4dY2Y8MKwVXiIB+fP4T2IT1EGJLEwfbWZHxfA4n8okEqD eYOgMZWo3+dFq1ElOiMjZ/WhgtDr6H5813rZvK1UdemAxpWU76JDpyqMP AAK0tmTh3zzjzGE24Thf7O5R/Q8burtiyztVx25+eE2A93ksCTIjxj80/ A==; X-IronPort-AV: E=Sophos;i="6.04,235,1695679200"; d="scan'208";a="34234253" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 29 Nov 2023 11:20:08 +0100 Received: from steina-w.localnet (steina-w.tq-net.de [10.123.53.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 240C3280075; Wed, 29 Nov 2023 11:20:08 +0100 (CET) From: Alexander Stein To: linux-media@vger.kernel.org, devicetree@vger.kernel.org, Paul Elder Cc: kieran.bingham@ideasonboard.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, Laurent Pinchart , Paul Elder , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Tim Harvey , Philippe Schenker , Marek Vasut , Gregor Herburger , Marcel Ziswiler , open list , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Subject: Re: [PATCH 2/2] arm64: dts: imx8mp: Add overlays for ISP instances Date: Wed, 29 Nov 2023 11:20:07 +0100 Message-ID: <7122934.GXAFRqVoOG@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20231129093113.255161-3-paul.elder@ideasonboard.com> References: <20231129093113.255161-1-paul.elder@ideasonboard.com> <20231129093113.255161-3-paul.elder@ideasonboard.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231129_022010_692825_4088223E X-CRM114-Status: GOOD ( 19.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Paul, thanks for the patch. Am Mittwoch, 29. November 2023, 10:31:13 CET schrieb Paul Elder: > From: Laurent Pinchart > = > Add two overlay to enable each ISP instance. The ISP is wired directly > to the CSIS for now, bypassing the ISI completely. I'm not sure if this is worth adding in a separate overlay. > Signed-off-by: Laurent Pinchart > Signed-off-by: Paul Elder > --- > arch/arm64/boot/dts/freescale/Makefile | 2 ++ > .../arm64/boot/dts/freescale/imx8mp-isp1.dtso | 36 +++++++++++++++++++ > .../arm64/boot/dts/freescale/imx8mp-isp2.dtso | 36 +++++++++++++++++++ > 3 files changed, 74 insertions(+) > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > = > diff --git a/arch/arm64/boot/dts/freescale/Makefile > b/arch/arm64/boot/dts/freescale/Makefile index 300049037eb0..f97dfac11189 > 100644 > --- a/arch/arm64/boot/dts/freescale/Makefile > +++ b/arch/arm64/boot/dts/freescale/Makefile > @@ -113,6 +113,8 @@ dtb-$(CONFIG_ARCH_MXC) +=3D imx8mp-dhcom-pdk2.dtb > dtb-$(CONFIG_ARCH_MXC) +=3D imx8mp-dhcom-pdk3.dtb > dtb-$(CONFIG_ARCH_MXC) +=3D imx8mp-evk.dtb > dtb-$(CONFIG_ARCH_MXC) +=3D imx8mp-icore-mx8mp-edimm2.2.dtb > +dtb-$(CONFIG_ARCH_MXC) +=3D imx8mp-isp1.dtbo > +dtb-$(CONFIG_ARCH_MXC) +=3D imx8mp-isp2.dtbo > dtb-$(CONFIG_ARCH_MXC) +=3D imx8mp-msc-sm2s-ep1.dtb > dtb-$(CONFIG_ARCH_MXC) +=3D imx8mp-phyboard-pollux-rdk.dtb > dtb-$(CONFIG_ARCH_MXC) +=3D imx8mp-tqma8mpql-mba8mpxl.dtb > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > b/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso new file mode 100644 > index 000000000000..cf394ed224ab > --- /dev/null > +++ b/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > @@ -0,0 +1,36 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright 2022 Ideas on Board Oy > + */ > + > +/dts-v1/; > +/plugin/; > + > +#include > + > +&isi_0 { > + status =3D "disabled"; ISI is disabled by default. What is your intention here? > + > + ports { > + port@0 { > + /delete-node/ endpoint; This doesn't work in overlays. See [1]. Otherwise the OF graph connections = look fine to me. I'm using the same in my local overlay. Best regards, Alexander [1] https://lore.kernel.org/all/ CAMuHMdWu4KZbBkvEofUV2wuA1g2S=3DXHHM3RUN1cNrcZBkhsPZA@mail.gmail.com/ > + }; > + }; > +}; > + > +&isp_0 { > + status =3D "okay"; > + > + ports { > + port@1 { > + isp0_in: endpoint { > + bus-type =3D ; > + remote-endpoint =3D <&mipi_csi_0_out>; > + }; > + }; > + }; > +}; > + > +&mipi_csi_0_out { > + remote-endpoint =3D <&isp0_in>; > +}; > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > b/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso new file mode 100644 > index 000000000000..14e2e7b2617f > --- /dev/null > +++ b/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > @@ -0,0 +1,36 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright 2022 Ideas on Board Oy > + */ > + > +/dts-v1/; > +/plugin/; > + > +#include > + > +&isi_0 { > + status =3D "disabled"; > + > + ports { > + port@1 { > + /delete-node/ endpoint; > + }; > + }; > +}; > + > +&isp_1 { > + status =3D "okay"; > + > + ports { > + port@1 { > + isp1_in: endpoint { > + bus-type =3D ; > + remote-endpoint =3D <&mipi_csi_1_out>; > + }; > + }; > + }; > +}; > + > +&mipi_csi_1_out { > + remote-endpoint =3D <&isp1_in>; > +}; -- = TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel