* [PATCH 0/4] Moto G (2013) DTS updates
@ 2025-05-08 14:11 Stanislav Jakubek
2025-05-08 14:11 ` [PATCH 1/4] ARM: dts: qcom: msm8226-motorola-falcon: add clocks, power-domain to simpleFB Stanislav Jakubek
` (4 more replies)
0 siblings, 5 replies; 10+ messages in thread
From: Stanislav Jakubek @ 2025-05-08 14:11 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-arm-kernel, phone-devel,
linux-kernel
This series improves the accuracy of motorola-falcon's DTS.
As a side note, I wanted to ask how to describe the Hall effect sensor's
vdd-supply. The sensor's currently described as part of the gpio-keys node.
According to the schematic it's powered by pm8226_lvs1, but I don't see a way
to describe this as part of the gpio-keys node (maybe it's always-on because
of this? Downstream describes it as gpio-keys too). Any tips?
Stanislav Jakubek (4):
ARM: dts: qcom: msm8226-motorola-falcon: add clocks, power-domain to
simpleFB
ARM: dts: qcom: msm8226-motorola-falcon: add I2C clock frequencies
ARM: dts: qcom: msm8226-motorola-falcon: limit TPS65132 to 5.4V
ARM: dts: qcom: msm8226-motorola-falcon: specify vddio_disp output
voltage
.../boot/dts/qcom/msm8226-motorola-falcon.dts | 22 +++++++++++++++----
1 file changed, 18 insertions(+), 4 deletions(-)
--
2.43.0
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/4] ARM: dts: qcom: msm8226-motorola-falcon: add clocks, power-domain to simpleFB
2025-05-08 14:11 [PATCH 0/4] Moto G (2013) DTS updates Stanislav Jakubek
@ 2025-05-08 14:11 ` Stanislav Jakubek
2025-05-08 14:29 ` Konrad Dybcio
2025-05-08 14:11 ` [PATCH 2/4] ARM: dts: qcom: msm8226-motorola-falcon: add I2C clock frequencies Stanislav Jakubek
` (3 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Stanislav Jakubek @ 2025-05-08 14:11 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-arm-kernel, phone-devel,
linux-kernel
Makes the display work without clk_ignore_unused and pd_ignore_unused.
Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com>
---
arch/arm/boot/dts/qcom/msm8226-motorola-falcon.dts | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm/boot/dts/qcom/msm8226-motorola-falcon.dts b/arch/arm/boot/dts/qcom/msm8226-motorola-falcon.dts
index 5dbca83f22309..c01becca3d56b 100644
--- a/arch/arm/boot/dts/qcom/msm8226-motorola-falcon.dts
+++ b/arch/arm/boot/dts/qcom/msm8226-motorola-falcon.dts
@@ -31,6 +31,15 @@ framebuffer@3200000 {
vsp-supply = <®_lcd_pos>;
vsn-supply = <®_lcd_neg>;
vddio-supply = <&vddio_disp_vreg>;
+ clocks = <&mmcc MDSS_AHB_CLK>,
+ <&mmcc MDSS_AXI_CLK>,
+ <&mmcc MDSS_BYTE0_CLK>,
+ <&mmcc MDSS_ESC0_CLK>,
+ <&mmcc MDSS_MDP_CLK>,
+ <&mmcc MMSS_MISC_AHB_CLK>,
+ <&mmcc MDSS_PCLK0_CLK>,
+ <&mmcc MDSS_VSYNC_CLK>;
+ power-domains = <&mmcc MDSS_GDSC>;
};
};
--
2.43.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/4] ARM: dts: qcom: msm8226-motorola-falcon: add I2C clock frequencies
2025-05-08 14:11 [PATCH 0/4] Moto G (2013) DTS updates Stanislav Jakubek
2025-05-08 14:11 ` [PATCH 1/4] ARM: dts: qcom: msm8226-motorola-falcon: add clocks, power-domain to simpleFB Stanislav Jakubek
@ 2025-05-08 14:11 ` Stanislav Jakubek
2025-05-08 14:27 ` Konrad Dybcio
2025-05-08 14:11 ` [PATCH 3/4] ARM: dts: qcom: msm8226-motorola-falcon: limit TPS65132 to 5.4V Stanislav Jakubek
` (2 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Stanislav Jakubek @ 2025-05-08 14:11 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-arm-kernel, phone-devel,
linux-kernel
While the currently supported hardware works fine with the default clock
frequencies of 100000 on both I2C2 and I2C3, downstream sources list the
frequencies as 100000 for I2C2 and 400000 for I2C3. Update them as such.
Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com>
---
arch/arm/boot/dts/qcom/msm8226-motorola-falcon.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/qcom/msm8226-motorola-falcon.dts b/arch/arm/boot/dts/qcom/msm8226-motorola-falcon.dts
index c01becca3d56b..e2bf292159fa9 100644
--- a/arch/arm/boot/dts/qcom/msm8226-motorola-falcon.dts
+++ b/arch/arm/boot/dts/qcom/msm8226-motorola-falcon.dts
@@ -106,6 +106,7 @@ reserved@fb00000 {
};
&blsp1_i2c2 {
+ clock-frequency = <100000>;
status = "okay";
magnetometer@c {
@@ -135,6 +136,7 @@ accelerometer@19 {
};
&blsp1_i2c3 {
+ clock-frequency = <400000>;
status = "okay";
regulator@3e {
--
2.43.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 3/4] ARM: dts: qcom: msm8226-motorola-falcon: limit TPS65132 to 5.4V
2025-05-08 14:11 [PATCH 0/4] Moto G (2013) DTS updates Stanislav Jakubek
2025-05-08 14:11 ` [PATCH 1/4] ARM: dts: qcom: msm8226-motorola-falcon: add clocks, power-domain to simpleFB Stanislav Jakubek
2025-05-08 14:11 ` [PATCH 2/4] ARM: dts: qcom: msm8226-motorola-falcon: add I2C clock frequencies Stanislav Jakubek
@ 2025-05-08 14:11 ` Stanislav Jakubek
2025-05-08 14:30 ` Konrad Dybcio
2025-05-08 14:11 ` [PATCH 4/4] ARM: dts: qcom: msm8226-motorola-falcon: specify vddio_disp output voltage Stanislav Jakubek
2025-05-12 21:48 ` [PATCH 0/4] Moto G (2013) DTS updates Bjorn Andersson
4 siblings, 1 reply; 10+ messages in thread
From: Stanislav Jakubek @ 2025-05-08 14:11 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-arm-kernel, phone-devel,
linux-kernel
After some digging in downstream sources, it was found that the TPS65132
outputs are fixed to +5.4V and -5.4V respectively. This is further confirmed
on runtime through debugfs, the troubleshooting guide confirms this as well.
Specify these limits as such.
Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com>
---
arch/arm/boot/dts/qcom/msm8226-motorola-falcon.dts | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/qcom/msm8226-motorola-falcon.dts b/arch/arm/boot/dts/qcom/msm8226-motorola-falcon.dts
index e2bf292159fa9..d6d5a86491aac 100644
--- a/arch/arm/boot/dts/qcom/msm8226-motorola-falcon.dts
+++ b/arch/arm/boot/dts/qcom/msm8226-motorola-falcon.dts
@@ -147,8 +147,8 @@ regulator@3e {
reg_lcd_pos: outp {
regulator-name = "outp";
- regulator-min-microvolt = <4000000>;
- regulator-max-microvolt = <6000000>;
+ regulator-min-microvolt = <5400000>;
+ regulator-max-microvolt = <5400000>;
regulator-active-discharge = <1>;
regulator-boot-on;
enable-gpios = <&tlmm 31 GPIO_ACTIVE_HIGH>;
@@ -156,8 +156,8 @@ reg_lcd_pos: outp {
reg_lcd_neg: outn {
regulator-name = "outn";
- regulator-min-microvolt = <4000000>;
- regulator-max-microvolt = <6000000>;
+ regulator-min-microvolt = <5400000>;
+ regulator-max-microvolt = <5400000>;
regulator-active-discharge = <1>;
regulator-boot-on;
enable-gpios = <&tlmm 33 GPIO_ACTIVE_HIGH>;
--
2.43.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 4/4] ARM: dts: qcom: msm8226-motorola-falcon: specify vddio_disp output voltage
2025-05-08 14:11 [PATCH 0/4] Moto G (2013) DTS updates Stanislav Jakubek
` (2 preceding siblings ...)
2025-05-08 14:11 ` [PATCH 3/4] ARM: dts: qcom: msm8226-motorola-falcon: limit TPS65132 to 5.4V Stanislav Jakubek
@ 2025-05-08 14:11 ` Stanislav Jakubek
2025-05-08 14:29 ` Konrad Dybcio
2025-05-12 21:48 ` [PATCH 0/4] Moto G (2013) DTS updates Bjorn Andersson
4 siblings, 1 reply; 10+ messages in thread
From: Stanislav Jakubek @ 2025-05-08 14:11 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-arm-kernel, phone-devel,
linux-kernel
After some digging in downstream sources, it was found that the vddio_disp
regulator's output voltage is 1.8V. This is further confirmed by the
troubleshooting guide. Specify its output voltage as such.
While at it, add a comment specifying the IC, which according to the
schematic is the TI TPS22902.
Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com>
---
arch/arm/boot/dts/qcom/msm8226-motorola-falcon.dts | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm/boot/dts/qcom/msm8226-motorola-falcon.dts b/arch/arm/boot/dts/qcom/msm8226-motorola-falcon.dts
index d6d5a86491aac..e6392f7d14c75 100644
--- a/arch/arm/boot/dts/qcom/msm8226-motorola-falcon.dts
+++ b/arch/arm/boot/dts/qcom/msm8226-motorola-falcon.dts
@@ -62,9 +62,12 @@ key-volume-up {
};
};
+ /* TI TPS22902 */
vddio_disp_vreg: regulator-vddio-disp {
compatible = "regulator-fixed";
regulator-name = "vddio_disp";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
gpio = <&tlmm 34 GPIO_ACTIVE_HIGH>;
vin-supply = <&pm8226_l8>;
startup-delay-us = <300>;
--
2.43.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 2/4] ARM: dts: qcom: msm8226-motorola-falcon: add I2C clock frequencies
2025-05-08 14:11 ` [PATCH 2/4] ARM: dts: qcom: msm8226-motorola-falcon: add I2C clock frequencies Stanislav Jakubek
@ 2025-05-08 14:27 ` Konrad Dybcio
0 siblings, 0 replies; 10+ messages in thread
From: Konrad Dybcio @ 2025-05-08 14:27 UTC (permalink / raw)
To: Stanislav Jakubek, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-arm-kernel, phone-devel,
linux-kernel
On 5/8/25 4:11 PM, Stanislav Jakubek wrote:
> While the currently supported hardware works fine with the default clock
> frequencies of 100000 on both I2C2 and I2C3, downstream sources list the
> frequencies as 100000 for I2C2 and 400000 for I2C3. Update them as such.
>
> Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 4/4] ARM: dts: qcom: msm8226-motorola-falcon: specify vddio_disp output voltage
2025-05-08 14:11 ` [PATCH 4/4] ARM: dts: qcom: msm8226-motorola-falcon: specify vddio_disp output voltage Stanislav Jakubek
@ 2025-05-08 14:29 ` Konrad Dybcio
0 siblings, 0 replies; 10+ messages in thread
From: Konrad Dybcio @ 2025-05-08 14:29 UTC (permalink / raw)
To: Stanislav Jakubek, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-arm-kernel, phone-devel,
linux-kernel
On 5/8/25 4:11 PM, Stanislav Jakubek wrote:
> After some digging in downstream sources, it was found that the vddio_disp
> regulator's output voltage is 1.8V. This is further confirmed by the
> troubleshooting guide. Specify its output voltage as such.
> While at it, add a comment specifying the IC, which according to the
> schematic is the TI TPS22902.
>
> Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com>
> ---
Not sure what the troubleshooting guide you're referring to is, but
nonetheless
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/4] ARM: dts: qcom: msm8226-motorola-falcon: add clocks, power-domain to simpleFB
2025-05-08 14:11 ` [PATCH 1/4] ARM: dts: qcom: msm8226-motorola-falcon: add clocks, power-domain to simpleFB Stanislav Jakubek
@ 2025-05-08 14:29 ` Konrad Dybcio
0 siblings, 0 replies; 10+ messages in thread
From: Konrad Dybcio @ 2025-05-08 14:29 UTC (permalink / raw)
To: Stanislav Jakubek, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-arm-kernel, phone-devel,
linux-kernel
On 5/8/25 4:11 PM, Stanislav Jakubek wrote:
> Makes the display work without clk_ignore_unused and pd_ignore_unused.
>
> Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 3/4] ARM: dts: qcom: msm8226-motorola-falcon: limit TPS65132 to 5.4V
2025-05-08 14:11 ` [PATCH 3/4] ARM: dts: qcom: msm8226-motorola-falcon: limit TPS65132 to 5.4V Stanislav Jakubek
@ 2025-05-08 14:30 ` Konrad Dybcio
0 siblings, 0 replies; 10+ messages in thread
From: Konrad Dybcio @ 2025-05-08 14:30 UTC (permalink / raw)
To: Stanislav Jakubek, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-arm-kernel, phone-devel,
linux-kernel
On 5/8/25 4:11 PM, Stanislav Jakubek wrote:
> After some digging in downstream sources, it was found that the TPS65132
> outputs are fixed to +5.4V and -5.4V respectively. This is further confirmed
> on runtime through debugfs, the troubleshooting guide confirms this as well.
> Specify these limits as such.
>
> Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 0/4] Moto G (2013) DTS updates
2025-05-08 14:11 [PATCH 0/4] Moto G (2013) DTS updates Stanislav Jakubek
` (3 preceding siblings ...)
2025-05-08 14:11 ` [PATCH 4/4] ARM: dts: qcom: msm8226-motorola-falcon: specify vddio_disp output voltage Stanislav Jakubek
@ 2025-05-12 21:48 ` Bjorn Andersson
4 siblings, 0 replies; 10+ messages in thread
From: Bjorn Andersson @ 2025-05-12 21:48 UTC (permalink / raw)
To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Stanislav Jakubek
Cc: linux-arm-msm, devicetree, linux-arm-kernel, phone-devel,
linux-kernel
On Thu, 08 May 2025 16:11:05 +0200, Stanislav Jakubek wrote:
> This series improves the accuracy of motorola-falcon's DTS.
>
> As a side note, I wanted to ask how to describe the Hall effect sensor's
> vdd-supply. The sensor's currently described as part of the gpio-keys node.
> According to the schematic it's powered by pm8226_lvs1, but I don't see a way
> to describe this as part of the gpio-keys node (maybe it's always-on because
> of this? Downstream describes it as gpio-keys too). Any tips?
>
> [...]
Applied, thanks!
[1/4] ARM: dts: qcom: msm8226-motorola-falcon: add clocks, power-domain to simpleFB
commit: cbcd04ab82c61dc777a4b56014292b9467f10c4e
[2/4] ARM: dts: qcom: msm8226-motorola-falcon: add I2C clock frequencies
commit: db6e3f2ba0bf6ad069347050ff62f29ef0d88b14
[3/4] ARM: dts: qcom: msm8226-motorola-falcon: limit TPS65132 to 5.4V
commit: 7bce56fd73ee7264ed04418dab1719164e42f113
[4/4] ARM: dts: qcom: msm8226-motorola-falcon: specify vddio_disp output voltage
commit: e41ece7cd173486f6767de050deb2d8f0882a82a
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2025-05-12 22:26 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-08 14:11 [PATCH 0/4] Moto G (2013) DTS updates Stanislav Jakubek
2025-05-08 14:11 ` [PATCH 1/4] ARM: dts: qcom: msm8226-motorola-falcon: add clocks, power-domain to simpleFB Stanislav Jakubek
2025-05-08 14:29 ` Konrad Dybcio
2025-05-08 14:11 ` [PATCH 2/4] ARM: dts: qcom: msm8226-motorola-falcon: add I2C clock frequencies Stanislav Jakubek
2025-05-08 14:27 ` Konrad Dybcio
2025-05-08 14:11 ` [PATCH 3/4] ARM: dts: qcom: msm8226-motorola-falcon: limit TPS65132 to 5.4V Stanislav Jakubek
2025-05-08 14:30 ` Konrad Dybcio
2025-05-08 14:11 ` [PATCH 4/4] ARM: dts: qcom: msm8226-motorola-falcon: specify vddio_disp output voltage Stanislav Jakubek
2025-05-08 14:29 ` Konrad Dybcio
2025-05-12 21:48 ` [PATCH 0/4] Moto G (2013) DTS updates Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).