Re: [PATCH v7 1/3] dt-bindings: soc: imx93-media-blk-ctrl: Add PDFC subnode to schema and example

[Krzysztof Kozlowski <krzk@kernel.org>]

On 15/12/2025 17:17, Marco Felsch wrote:
> Hi Liu,
> 
> On 25-12-08, Liu Ying wrote:
>> Hi Marco,
>>
>> On 12/02/2025, Marco Felsch wrote:
>>> From: Liu Ying <victor.liu@nxp.com>
>>>
>>> i.MX93 SoC mediamix blk-ctrl contains one DISPLAY_MUX register which
>>> configures parallel display format by using the "PARALLEL_DISP_FORMAT"
>>> field. Document the Parallel Display Format Configuration(PDFC) subnode
>>> and add the subnode to example.
>>>
>>> Signed-off-by: Liu Ying <victor.liu@nxp.com>
>>> [m.felsch@pengutronix.de: port to v6.18-rc1]
>>> [m.felsch@pengutronix.de: add bus-width]
>>> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
>>> ---
>>>  .../bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml | 92 ++++++++++++++++++++++
>>>  1 file changed, 92 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml
>>> index 34aea58094e55365a2f9c86092f637e533f954ff..6e2d86d9341c75108b492bcbabc8a560d8e707cd 100644
>>> --- a/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml
>>> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml
>>> @@ -26,6 +26,12 @@ properties:
>>>    reg:
>>>      maxItems: 1
>>>  
>>> +  '#address-cells':
>>> +    const: 1
>>> +
>>> +  '#size-cells':
>>> +    const: 1
>>> +
>>>    '#power-domain-cells':
>>>      const: 1
>>>  
>>> @@ -40,6 +46,60 @@ properties:
>>>      minItems: 8
>>>      maxItems: 10
>>>  
>>> +  bridge@60:
>>
>> The dependency patch series mentioned in cover letter has two links in it's
>> cover letter.  Reading the patch sets pointed by the two links, we may find
>> Krzysztof's comments - the child nodes of the blk-ctrl should be completely
>> documented.
> 
> Thanks for pointing this out.
> 
> @Krzysztof
> Requesting to add everything seems not feasible if everything added
> should be tested too.
> I don't see why everything should be added in one step, since the base
> .dtsi isn't added in one step too.

Because otherwise we do not see entire picture and people post incorrect
bindings, claiming they are complete picture, like messing nodes with
addressing and nodes without. So sure, if you do not want to post
complete picture, we cannot review that complete picture, therefore YOU
MUST POST CORRECT CODE.

I will not be taking excuses later "we did not know that such code is
not allowed". You must know all rules.


Best regards,
Krzysztof