From: Michal Simek <michal.simek@xilinx.com>
To: YueHaibing <yuehaibing@huawei.com>,
mturquette@baylibre.com, sboyd@kernel.org,
michal.simek@xilinx.com, rajan.vaja@xilinx.com,
tejas.patel@xilinx.com, m.tretter@pengutronix.de
Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] clk: zynqmp: Make zynqmp_clk_get_max_divisor static
Date: Fri, 3 Apr 2020 10:37:57 +0200 [thread overview]
Message-ID: <713789e9-c947-44d4-cd66-06373537da31@xilinx.com> (raw)
In-Reply-To: <20200403083040.37748-1-yuehaibing@huawei.com>
On 03. 04. 20 10:30, YueHaibing wrote:
> Fix sparse warning:
>
> drivers/clk/zynqmp/divider.c:259:5: warning:
> symbol 'zynqmp_clk_get_max_divisor' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/clk/zynqmp/divider.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/zynqmp/divider.c b/drivers/clk/zynqmp/divider.c
> index 4be2cc76aa2e..1e93a4d32fa9 100644
> --- a/drivers/clk/zynqmp/divider.c
> +++ b/drivers/clk/zynqmp/divider.c
> @@ -256,7 +256,7 @@ static const struct clk_ops zynqmp_clk_divider_ops = {
> * Return: Maximum divisor of a clock if query data is successful
> * U16_MAX in case of query data is not success
> */
> -u32 zynqmp_clk_get_max_divisor(u32 clk_id, u32 type)
> +static u32 zynqmp_clk_get_max_divisor(u32 clk_id, u32 type)
> {
> const struct zynqmp_eemi_ops *eemi_ops = zynqmp_pm_get_eemi_ops();
> struct zynqmp_pm_query_data qdata = {0};
>
Reviewed-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-03 8:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 8:30 [PATCH -next] clk: zynqmp: Make zynqmp_clk_get_max_divisor static YueHaibing
2020-04-03 8:37 ` Michal Simek [this message]
2020-05-27 1:45 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=713789e9-c947-44d4-cd66-06373537da31@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.tretter@pengutronix.de \
--cc=mturquette@baylibre.com \
--cc=rajan.vaja@xilinx.com \
--cc=sboyd@kernel.org \
--cc=tejas.patel@xilinx.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox