From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52AECCDB482 for ; Tue, 17 Oct 2023 10:51:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5mnSbIXnfd54Lf0Vdu1JERt0x3QaGkWXIFvZ1vxvCeg=; b=4sS4nBMw13EVr4 2OJbSZBK3/LEmbNGJDeNa7c0433U0lTGyFt8THubUmhk4LxJOAt/IJ/TChPGeArTD1s9NDUybcvV1 9Ph9DiWJTMj3sWJo60UuCOg0BzJnoaC9hv8VZqTAsEH7g3kSUjiCWUlV8WU/FuTYpQ30xg0hVjfjr U0lbxkTRUbR3DZm6amggoCR7WghJyQLEev1XyjBnqibDN/PfhGIc03MQzPcf1f3t7zAgonkfKvjjq ipq//gXU6gjWTxTjoTYd9//dDQBFSfo9xfAkiijSn5qb70NQgt0tICxMbWoBK0FGCr4xLEgchX3MU SZfqK1o7pdLCeivZxfVA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qshfB-00C7vS-2M; Tue, 17 Oct 2023 10:51:01 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qshf8-00C7u1-1g; Tue, 17 Oct 2023 10:50:59 +0000 X-UUID: 0ab134dc6cdb11ee9b7791016c24628a-20231017 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=2s6rIsj3S+nC9n3/7CRtCj9yH7eOFeG3/2ltEI09ZSs=; b=lozSNOYCK54Qs0lgGuahZYIf1J4BLS2npsRj2qSGIm43PTmg0Zy4XKalkVqv6Om5JtGvN/SCNo5iEqkrxZjf4TXsFS3hUZ2nm86O+PaGxrnd3YPhgXsBQAIzNWGSsthlZLmblQzfvsTlfFmsXwjpxesLJJsq7sBMPfdo6srhSO4=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.32,REQID:1ebdcb02-47ae-44e8-b10a-69165d7c5ab6,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:5f78ec9,CLOUDID:23bc39c4-1e57-4345-9d31-31ad9818b39f,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:11|1,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR: NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_ULN X-UUID: 0ab134dc6cdb11ee9b7791016c24628a-20231017 Received: from mtkmbs14n1.mediatek.inc [(172.21.101.75)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 390866503; Tue, 17 Oct 2023 03:50:52 -0700 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by mtkmbs11n2.mediatek.inc (172.21.101.187) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Tue, 17 Oct 2023 18:50:17 +0800 Received: from APC01-SG2-obe.outbound.protection.outlook.com (172.21.101.237) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Tue, 17 Oct 2023 18:50:17 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b2zmsxqKUAoeeMtzSMAGFbX/6Feo+pjkz172dbQqNVmoRtsVIHHtpOESJSBjg9Zk3h3O7MgDoPLMyaNuaAtjGyqPKVm4mWXOjJ/V5KMHwbW5tBgYn+TpFI8NXDvJ2BJJFhLUtsOZanr1SsYvRCKzKHfizLlqw3GHd9TYRekKHFVy72ZJzn61VYwT0uDXWOsFs39sqHu9PNBdTeJ1TsjA/7CX8xi0c6le/APRZOXVQaeIBQJK9/MNLI2s5QxG4Yi1CmSRG9SlCIH6vTk1Nw1NEYAwVg3nbs995Dgo3i+xvnq7V2lw7wt+wz7Pgfyd4Fhaqm3akjJcmxwJOT0b+aoJ/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2s6rIsj3S+nC9n3/7CRtCj9yH7eOFeG3/2ltEI09ZSs=; b=EEo3pPeZyPxHyAi1Knp1rssyEM/AJi5cqu5AasLg7gqO/YXD3sMnM+gbhZX5qk3yuKRQAuUTUOuOXAVXVwC55hatUZM2JRRttJwkAQjDH6flmC2qPxtPorTpjnLGnbKYKA3YUzADnGX3dw4+5tvveR4nmn7NvKJ6MFxRFUeUA0u44ERujCoTagiuDw0VmejiCXC3QT3qvNkZUcdMGEbJRvO/ggOsj+XLdrtyLhPJmbRMH3FGeABNVc8v7TXtMWiYbpO7tM7jJmpM2UM7/5jTzFO6znuaAbY2gRNIRkMR7ujWbQ0guZAvM4DISZWAPMd0VJRBGGWT+TsgoxIqVXAEBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2s6rIsj3S+nC9n3/7CRtCj9yH7eOFeG3/2ltEI09ZSs=; b=kgGyOxh/P42vL2yvKAhmtkxJHcYPrKXEW9GrlqCpUlHwI8B5PZHov0hJcmQHd267IkdtWOrRz9MsLYZMRMcq4ZLbl5Nk7pLo9+S9SJg0w9kZN97rIclDr9oYGhC64d57o9x3J92nuU0Hrt356jNol4AZlG3VJDa7dXdcXmnLl+E= Received: from TYZPR03MB6623.apcprd03.prod.outlook.com (2603:1096:400:1f5::13) by KL1PR03MB5603.apcprd03.prod.outlook.com (2603:1096:820:5d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.36; Tue, 17 Oct 2023 10:50:14 +0000 Received: from TYZPR03MB6623.apcprd03.prod.outlook.com ([fe80::faa3:6316:28ab:206b]) by TYZPR03MB6623.apcprd03.prod.outlook.com ([fe80::faa3:6316:28ab:206b%4]) with mapi id 15.20.6886.034; Tue, 17 Oct 2023 10:50:14 +0000 From: =?utf-8?B?U2hhd24gU3VuZyAo5a6L5a2d6KyZKQ==?= To: =?utf-8?B?Q0sgSHUgKOiDoeS/iuWFiSk=?= , "matthias.bgg@gmail.com" , "angelogioacchino.delregno@collabora.com" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" CC: =?utf-8?B?WW9uZ3FpYW5nIE5pdSAo54mb5rC45by6KQ==?= , "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "chunkuang.hu@kernel.org" , =?utf-8?B?SmFzb24tSkggTGluICjmnpfnnb/npaUp?= , "devicetree@vger.kernel.org" , =?utf-8?B?TmFuY3kgTGluICjmnpfmrKPonqIp?= , =?utf-8?B?TW91ZHkgSG8gKOS9leWul+WOnyk=?= , "daniel@ffwll.ch" , "p.zabel@pengutronix.de" , "mchehab@kernel.org" , "dri-devel@lists.freedesktop.org" , =?utf-8?B?TmF0aGFuIEx1ICjlkYLmnbHpnJYp?= , "airlied@gmail.com" , "sean@poorly.run" , "hverkuil-cisco@xs4all.nl" , "linux-arm-kernel@lists.infradead.org" , "fshao@chromium.org" , "johnson.wang@mediatek.corp-partner.google.com" Subject: Re: [PATCH v8 15/23] drm/mediatek: Manage component's clock with function pointers Thread-Topic: [PATCH v8 15/23] drm/mediatek: Manage component's clock with function pointers Thread-Index: AQHaAB1EFgvzgIQf10CXPVdnWO1vobBNvcmAgAARZwA= Date: Tue, 17 Oct 2023 10:50:14 +0000 Message-ID: <714697a54f449cbc78620f7482ca78173fc94230.camel@mediatek.com> References: <20231016104010.3270-1-shawn.sung@mediatek.com> <20231016104010.3270-16-shawn.sung@mediatek.com> <91932706-c42c-4c10-96bd-c8a91b7d82f0@collabora.com> In-Reply-To: <91932706-c42c-4c10-96bd-c8a91b7d82f0@collabora.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mediatek.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYZPR03MB6623:EE_|KL1PR03MB5603:EE_ x-ms-office365-filtering-correlation-id: 90be9f9f-572a-4975-ea04-08dbcefed839 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8qVLNumOfcTs7GnHdPqzojgqwQYLx0ChRMtP/z7hNB5BHTp+8JiuzFmsVPO88KRJDnUoREie7fSPsE2nxBXONAiUH1PdjoxLWyIee7oPD6hOoDJw07ez+EwHR5Yu9hyiEVz2YgIh+O1rBQb0aS1X2+ot0bp5ZytzAHsWlkleNvD+qcjASPnLmdqUICdmMdRQVKEZDWwK8Nd73xYFYZ1+5e32knUa8P/CN5N4wp1/aICMX5IkJY4qRsdBuzGoM5hlsTv3L5vDuX5VwBaozty9fZNd593E+iH+gI3sUmKZ2BM7teCjtRWfGuBBWCkS+ytpLFuSiF9SF/uH/fQJxguE83EqvmNmaORuH79MJ1wcL35VlhtsN0JzAciZfBKCr6o9j7EGBs6xniAnR3qVBx+++GraAOeaFdhLbg0bFoTKGxoNJFg5glgPJl8ItX2NJ9pVcdedRQAOvBG+jvaLyPsmEEpVvPMzw/u08jyqsyM0nud7GEBEtTGHShTCTc6NqQj1XcZvphzr4OFOKldm0lel0XD2c/6em551iFE2AuzQckdcde5NLsZJnxm41JNERZnWz65ROzdJu30LbfJ31yVOU1tOLeBW8k6d7yCj1zQvZoBpmSusHvBXyQX5wSmlKEfXixIDUa+a1FAhGllIKc261h6z58JxvGk9eN8TBrPA8ag= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYZPR03MB6623.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(136003)(346002)(376002)(39860400002)(366004)(396003)(230922051799003)(186009)(1800799009)(64100799003)(451199024)(83380400001)(8676002)(8936002)(6506007)(71200400001)(110136005)(6486002)(478600001)(26005)(76116006)(64756008)(6512007)(66446008)(66556008)(2616005)(54906003)(66476007)(38100700002)(7416002)(66946007)(4001150100001)(2906002)(36756003)(5660300002)(85182001)(86362001)(4326008)(38070700005)(122000001)(316002)(41300700001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?TG9sUEtYcHVVWkVvMDJOcjVjWEVta1FESGV2OXhKL0RYN0VTRzVHRTZxejVk?= =?utf-8?B?LzRscE9jcFFGUVN0emQ2QU5vNm1kWjNBampLdjgzTGZXTnUyL3FWdEFoRmlt?= =?utf-8?B?SWRQeWhtVGU3V2F4Q3pFRDhZcHQ1cUs0VjhtWVFyKzhQWXFlcE9iNGNpQjN3?= =?utf-8?B?YTlrT3hiSk1hTXRtRjBwdjhUOGtJWWZ4Q0ExK3FvZThFRGRDcUtCRXlKOFpL?= =?utf-8?B?eDRBQjAza0pkcXpxNTk2czNRT2JVRmVDZDd2RDExNU52YWRLb2N1UXNVaTN6?= =?utf-8?B?b3FGWEw4TUZIQ2NUL001cTcyTTl3cG1WNXNBajZGUC9CdUJoUWMybmhGYkg0?= =?utf-8?B?YXNSV2Zrajl3MytDVUtxVm9LNXRPU3lyM1JtUnh0dEZ1VE40aTNibERYL1Jl?= =?utf-8?B?MUlraHYwT2VnbHFxRTRuWDhVWEhaK3dsUnVXc0xmaGlyWGgwTmJETDhtdWRM?= =?utf-8?B?K1J4L0N3L1Ixd2t1STBQSUFYU29nSTZkSHVsbW1YYkhiT1loU3FoVGdHZzVO?= =?utf-8?B?MHg3d0NDSlpaU05YRE4rTWExUUpxSUJkcVlVQzd2VHhCRmwrd2NIVUp0enpv?= =?utf-8?B?NWNXOTNMNUZaSFhrVU1OcEtrMmdjN2J5T2NRYjN4U1l5bnpneFI5dFRiWDhu?= =?utf-8?B?eHNPRUZodXNOR2dBQjRMQ3h6VkdTVEdUM3pjR2JpRWJ6WThVdlhVWVY0U0tj?= =?utf-8?B?ODY2V3FGZ1ZlYlRwZGpPNTVlVWFlM21hUmN0eHp3RUdWVG95NHRQKzJHeG5w?= =?utf-8?B?MFh6MnRJZGhrYmh6NWtzSmMxSld2djMyY2dna0hsYUJRNmNHaVBEV3BGU282?= =?utf-8?B?QmdoRXh6M1owWGZDZ3M0ZGx1aVpsWmpHUmlHNjhzVWtnWVRwbFZQRnZLWlRk?= =?utf-8?B?V01wUnJoeWJXbUs3eHJ1QVV0cGlFSzcxNUFZdEluMFlJNVlpNzBKT0paNm5C?= =?utf-8?B?TEJ0d3B6TStmU0FHWXVOZTdqMzh5QkRoR04rZUNIUEFhamw4dm9KYkZpWUVj?= =?utf-8?B?enpMMmkwNFpBNUVscE9ZSlFjc3RsRkJYYU5HUlJ4eDBmMGVSTE9JOWxPNFFy?= =?utf-8?B?R3hYUGQrUElGU0laNllnZFA4SytYcWRPNDUvYzJ6c0JkQW1ISFNkUlEvakR6?= =?utf-8?B?cUFxTktuR0MwRjRoU1l6UTZvTWJSZmk1K1pGWWRhUWdvenVSV0lWTDduM1ds?= =?utf-8?B?UmYrSFd1NTNCdStwRWI1Q0hKc25udnE2ZWZSVjNhT3R4TG4vQldYMndWU2xa?= =?utf-8?B?ODFaeXRBME1vNmFMd1QwdGRHZGtud3J0VUh3UjdreVZHL0VYc0lLVDZVM1dO?= =?utf-8?B?anhtYWxtVmphWmp2U1dBREZpcUdtK2tHdit0STZPUjlGQXNuQmF4TUhCRmsz?= =?utf-8?B?Y2pFRVlaMnh3WmVlaDlKajVpWXlnZzFuQWkreFliY3N2OVQvY2sySmtnZDJw?= =?utf-8?B?U2dRSXpyMzNlOEhsSXA4SEsrWFdScGt0bFVMY1lMakIyRE8zdFRXTUQ2UVJ0?= =?utf-8?B?Q0NEMVRGaEtlQmk3WGdHaHlEclNVVFNGYkJRTUJzeXU3c3ltMmx4TjYwanR3?= =?utf-8?B?a2E4aEphR2U3dWtiYURWZWZiSnhiN3hkZjFzV3RUbWdmYUl5N1lSbTdZMGo3?= =?utf-8?B?dlhsWlNCOXgwVXFmVFVCd01makhTWHBYb3NGQjE4N3orM0YyYlVwWDdsSHRW?= =?utf-8?B?bzBhUU9MQzVJYmdMRlR2cTVKcTczcGE1U2RGU3laRXBnbGkzVklGdEUrdHhF?= =?utf-8?B?UHo0ZGMxMlM0d0JWZEtGdnA4dmI4cTJNMUdTeVNmSzQwWmNFam5IcGZjVENB?= =?utf-8?B?SUdidUdmcUYxckRqZ3RDc0FWMk90aVQrZi9VZFZPb1RmZE9YNjNUQlNKTFlU?= =?utf-8?B?dDBOSVdCOW5rRjllNnRWOUZDWkVWTnpvT2FXVFUyZkdNcVUyajZnRUtWeXA4?= =?utf-8?B?WTFNUkhwbkNFSDN3TU5SWjdQVCtuL3ZBMTlRU05TcnJHVVhuUTB0N0craUxn?= =?utf-8?B?R0JJNlFjZG95MlE5T3UzSkp2K2JiTU9GVUJPaVZ3NldkQUlqNEQwK212eEYw?= =?utf-8?B?d0RXamFSbWFycC9qbU5VVGs4U3p3RTVnZnBLVzd2NnpwWGVPbzVuL0NPb1Fu?= =?utf-8?B?WEc0a3ZWYzFpdmoyaHJoTDlVbkFHeFFFQzV6R00zUzhmWEZybXJidGRha2p0?= =?utf-8?B?OGc9PQ==?= Content-ID: <5B08DBBC04251549A7EF2C5625408CAC@apcprd03.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB6623.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 90be9f9f-572a-4975-ea04-08dbcefed839 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2023 10:50:14.7541 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XdaurLVG6t+ugZkvRLFPSw/6ciBvKnjBWAZnrw4A+Uxjh99WeE0ngtISvupgKtS2P3AEAh4iqkh/FYbuockYcA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR03MB5603 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231017_035058_569029_F30EFDD7 X-CRM114-Status: GOOD ( 18.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Angelo, On Tue, 2023-10-17 at 11:47 +0200, AngeloGioacchino Del Regno wrote: > Il 16/10/23 12:40, Hsiao Chien Sung ha scritto: > > By registering component related functions to the pointers, > > we can easily manage them within a for-loop and simplify the > > logic of clock control significantly. > > > > Reviewed-by: CK Hu > > Signed-off-by: Hsiao Chien Sung > > --- > > .../gpu/drm/mediatek/mtk_disp_ovl_adaptor.c | 111 +++++++---- > > ------- > > 1 file changed, 44 insertions(+), 67 deletions(-) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c > > b/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c > > index 60e5dfe9ef0d..fffef2a4f919 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c > > +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c > > @@ -53,6 +53,7 @@ struct ovl_adaptor_comp_match { > > enum mtk_ovl_adaptor_comp_type type; > > enum mtk_ddp_comp_id comp_id; > > int alias_id; > > + const struct mtk_ddp_comp_funcs *funcs; > > }; > > > > struct mtk_disp_ovl_adaptor { > > @@ -67,20 +68,35 @@ static const char * const > > private_comp_stem[OVL_ADAPTOR_TYPE_NUM] = { > > [OVL_ADAPTOR_TYPE_MERGE] = "merge", > > }; > > > > +static const struct mtk_ddp_comp_funcs _ethdr = { > > Sorry I just noticed that; can you please remove the leading "_" from > all > of those? > > _ethdr -> ethdr or mtk_ethdr > _merge -> merge or mtk_merge > _rdma -> rdma or mtk_rdma > > Thanks, > Angelo > Sure. Will do in the next version. The reason I didn't use mtk_* is simply because of the column width will exceed 100 characaters. Thanks, Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel