From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6170AE7716B for ; Wed, 4 Dec 2024 14:48:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MMFBk9eLaL6gQuRpLXcAw0glVg7Z/D6IgiZ3CsC/KvI=; b=pQj9W5rSDaTBGPWoVBRZA24UMb 45YBmflkDa+DRydoxCWWECA7TFl7eTmwXuBsSHntzZgmbofUBLxaWMqBC1xKei5Pc1Qk0Sv6LdfwS kAGd7HOOFmuyxXceqzAbGhF5ihGVEWrVuoUNvuRt9lUB/DWRk887DMXRWeGyp1CMR2rldnOBQVpzL rD8815sLmzuRfVg8+TnonnpiEL95Bp6g3hG8ju8t+WppLes3u3jeh0NTQukd5bn/iupZm8udMdD9E eh8uf30bRHtBw1UI7w3mmYB6zs/dwZ9u/ervx63G9mpHg/4FFpUIPciEGLO/Eq0pAVF6uRa0jwOTs 5clrfftg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tIqfP-0000000CsuT-1OdX; Wed, 04 Dec 2024 14:47:51 +0000 Received: from bali.collaboradmins.com ([2a01:4f8:201:9162::2]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tIqcX-0000000Cs6C-31pm; Wed, 04 Dec 2024 14:44:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1733323490; bh=NZbhLNGj94fIzTT5df4O2rJPrluFBHWpQhHhEfIxwhg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=aN2bDnH5vbcXNAqGycKY+bKNa4aoLURt8zZOMxLXlUZHDOGsNfz/oX0Mrm3hiWQZZ /8lhBZZ5kx1Oh7A0ZDAUcBMqR0I0pKrSx4umMXINYcxUqst2R4kXaYg5BsP7goIO0Q UK6s2IF3K6ZUcCHvR69f2or38sT+hitX22uBb+rTccxiqxRAxgiiUzHuPVzNx7d/73 TW2RtJ7lTmupGQdl9cLsk3QOEBWH2JhpyBK8SBpfDBTn+/OCOxVvkgSImThXZQMXii cLogFTiURiF1imUVd/0v+bZAMC1NEVd/rPPoS30E9xfhW+29jgC83iECMhzAzJfTuK 9F5d33mEqMS1A== Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id A5C2217E376C; Wed, 4 Dec 2024 15:44:49 +0100 (CET) Message-ID: <716b8630-66ef-4497-8cba-d5d20da2382a@collabora.com> Date: Wed, 4 Dec 2024 15:44:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 7/7] drm/mediatek: Introduce HDMI/DDC v2 for MT8195/MT8188 To: =?UTF-8?B?Q0sgSHUgKOiDoeS/iuWFiSk=?= , "chunkuang.hu@kernel.org" Cc: "linux-mediatek@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "tzimmermann@suse.de" , "simona@ffwll.ch" , "mripard@kernel.org" , "kernel@collabora.com" , "p.zabel@pengutronix.de" , "maarten.lankhorst@linux.intel.com" , "conor+dt@kernel.org" , "robh@kernel.org" , "dri-devel@lists.freedesktop.org" , "airlied@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "matthias.bgg@gmail.com" , "krzk+dt@kernel.org" References: <20241120124512.134278-1-angelogioacchino.delregno@collabora.com> <20241120124512.134278-8-angelogioacchino.delregno@collabora.com> <559ac08df6614e47c3e8d9d8160b35c9e683c503.camel@mediatek.com> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <559ac08df6614e47c3e8d9d8160b35c9e683c503.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241204_064453_926209_BF505522 X-CRM114-Status: GOOD ( 27.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Il 02/12/24 08:27, CK Hu (胡俊光) ha scritto: > Hi, Angelo: > > On Wed, 2024-11-20 at 13:45 +0100, AngeloGioacchino Del Regno wrote: >> External email : Please do not click links or open attachments until you have verified the sender or the content. >> >> >> Add support for the newer HDMI-TX (Encoder) v2 and DDC v2 IPs >> found in MediaTek's MT8195, MT8188 SoC and their variants, and >> including support for display modes up to 4k60 and for HDMI >> Audio, as per the HDMI 2.0 spec. >> >> HDCP and CEC functionalities are also supported by this hardware, >> but are not included in this commit. >> >> Signed-off-by: AngeloGioacchino Del Regno >> --- > > [snip] > >> +static int mtk_hdmi_v2_enable(struct mtk_hdmi *hdmi) >> +{ >> + int ret; >> + >> + ret = pm_runtime_resume_and_get(hdmi->dev); > > Why turn on power when attach? > Should hot-plug detection be always on so power on when attach? > If so, maybe we need to use CEC to detect hot-plug because CEC has lower power and HDMI power would not be always on. > As you describe previously, CEC just need some hack to support both HDMI Tx and HDMI Rx. > So there is a software solution to use CEC to detect hot-plug in a lower power mode. > And v1 use CEC to detect hot-plug, so it's worth to make v1 and v2 has the same behavior. > As I said, we can't use CEC to detect hotplug, because the same CEC controller can be used for both HDMI TX and RX at the same time. If you use CEC to detect cable attach and you have both HDMI RX and HDMI TX drivers probed and ready, if you attach the cable to HDMI RX port, HDMI TX will try to get enabled and will error out. Same happens if you attach a cable to HDMI TX: HDMI RX will try to get enabled and will error out. The only way to use CEC for hotplug detection is to detect twice: CEC for HDMI TX/RX controllers wakeup, then reset both, wait for autodetect in both controllers, suppress errors, and start signal transmit or receive. While it is technically possible to do so, it's very complicated and hacky. Please keep in mind that on the new SoCs (8188/8195) the CEC block is different from the one in the old SoCs (6795, 8173, etc) and requires an entirely new driver to get it working. Using CEC for hotplug detection would mean that we need 3 full drivers: 1. HDMI TX 2. HDMI RX 3. CEC This is because the CEC is shared, so we need to have all three to properly test the functionality - and this is not possible to do all at once. To save some power (not much, though!), we can eventually go for your proposed CEC detection *in the future*, but really not right now - and we can do that only after upstreaming both HDMI TX and HDMI RX drivers. The plan (time/effort pemitting!) would look like this: Series 1 - Upstream HDMIv2 TX (HPD through HDMIv2 TX controller) - drivers/gpu/drm Series 2 - Upstream HDMIv2 RX (HPD through HDMIv2 RX controller) - drivers/media Series 3 - Upstream CEC driver (No HPD in CEC) - drivers/media Series 4 - Implement HPD in CEC and use it in HDMIv2 TX and HDMIv2 RX - media,drm You can see how complicated this is - and I'm sure that you understand why that cannot be done all at once. Adding up some: the HDMI driver is used only on IoT boards for now, which typically run off AC and not battery - so the (again) very little power consumption raise is not critical for now. Cheers, Angelo > Regards, > CK > > >> + if (ret) { >> + dev_err(hdmi->dev, "Cannot resume HDMI\n"); >> + return ret; >> + } >> + >> + mtk_hdmi_v2_clk_enable(hdmi); >> + mtk_hdmi_hw_reset(hdmi); >> + mtk_hdmi_set_sw_hpd(hdmi, true); >> + >> + return 0; >> +} >> + >