From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ADCFECD6911 for ; Tue, 10 Oct 2023 09:31:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3gMsUT5oMllXozgkxI5pXut5/FsyeXEHbZtGOF99n3E=; b=x+2CI1H8r2CU/A jeNW2aVnMUt907Kh7/v1g98r25jHkeEI48nbpESSAT0t4tb21JUSilW3BBM5AFLcoXLcc0ooPXFVA 7U/nQ9vlW9oTOXyGf+NkDIfRpZ7iH22RkyzlRRJ87FeLJ1yilP8Vru9ZAMephmNPUB7AAaxIxPO7e 8HGq5iW9cYk7zMUWJpnEygNjilwVUS7aDnez/2Hqjpc+kayA54tr16lLvXl896HsNLK3g7l7OGKlh f4JPObj0TZvZFJ0Sg85BOatMJCn4chMEtJNujRVUABm9asQiS6eh4ngg0ISLuPX4bjymFnBaiHgl5 DZfphQKD5LMZ2R0Fk9CQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qq951-00CwYS-0q; Tue, 10 Oct 2023 09:31:07 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qq94z-00CwY4-0p for linux-arm-kernel@lists.infradead.org; Tue, 10 Oct 2023 09:31:06 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D51741FB; Tue, 10 Oct 2023 02:31:44 -0700 (PDT) Received: from [10.57.69.45] (unknown [10.57.69.45]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D266B3F762; Tue, 10 Oct 2023 02:31:02 -0700 (PDT) Message-ID: <717a0880-1bc4-461f-bd42-c522d653b3ea@arm.com> Date: Tue, 10 Oct 2023 10:30:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ACPI: bus: Move acpi_arm_init() to the place of after acpi_ghes_init() To: Sudeep Holla , Hanjun Guo , Jean-Philippe Brucker Cc: Lorenzo Pieralisi , "Rafael J . Wysocki" , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, D Scott Phillips References: <20231010082123.4167603-1-guohanjun@huawei.com> <20231010085012.qkntexfsph333sif@bogus> Content-Language: en-GB From: Robin Murphy In-Reply-To: <20231010085012.qkntexfsph333sif@bogus> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231010_023105_345646_FE3C9285 X-CRM114-Status: GOOD ( 19.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2023-10-10 09:50, Sudeep Holla wrote: > On Tue, Oct 10, 2023 at 04:21:23PM +0800, Hanjun Guo wrote: >> acpi_agdi_init() in acpi_arm_init() will register a SDEI event, so >> it needs the SDEI subsystem to be initialized (which is done in >> acpi_ghes_init()) before the AGDI driver probing. >> >> In commit fcea0ccf4fd7 ("ACPI: bus: Consolidate all arm specific >> initialisation into acpi_arm_init()"), the acpi_agdi_init() was >> called before acpi_ghes_init() and it causes following failure: >> >> | [ 0.515864] sdei: Failed to create event 1073741825: -5 >> | [ 0.515866] agdi agdi.0: Failed to register for SDEI event 1073741825 >> | [ 0.515867] agdi: probe of agdi.0 failed with error -5 >> | ... >> | [ 0.516022] sdei: SDEIv1.0 (0x0) detected in firmware. >> >> Fix it by moving acpi_arm_init() to the place of after >> acpi_ghes_init(). >> >> Fixes: fcea0ccf4fd7 ("ACPI: bus: Consolidate all arm specific initialisation into acpi_arm_init()") >> Reported-by: D Scott Phillips >> Signed-off-by: Hanjun Guo >> --- >> >> I did a test on a ARM server and I didn't see regressions, but >> I don't have a AGDI table firmware, so Scott please give a >> test to see if it fixes your issue. >> >> drivers/acpi/bus.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c >> index f41dda2d3493..a4aa53b7e2bb 100644 >> --- a/drivers/acpi/bus.c >> +++ b/drivers/acpi/bus.c >> @@ -1410,10 +1410,10 @@ static int __init acpi_init(void) >> acpi_init_ffh(); >> >> pci_mmcfg_late_init(); >> - acpi_arm_init(); >> acpi_viot_early_init(); >> acpi_hest_init(); >> acpi_ghes_init(); >> + acpi_arm_init(); > > I am fine with the change, but just wanted to check with Robin/Jean-Philippe > if there are any dependency on IORT initialisation for VIOT ? IIUC IORT was > always initialised before VIOT but that changes after this change. They should be independent, and typically we'd only expect to see one or the other anyway (although strictly a VMM *could* provide virtio-iommu for some devices while also emulating an SMMU for others if it really really wanted to). Cheers, Robin. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel