From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB66DC52D6F for ; Sat, 24 Aug 2024 16:18:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tLewfIc0V1606kS8OnVX5wewyAHhmWACUF+UrTlyhhY=; b=jDMK/U6+sC/T22DxalxzgXIPh4 vKIWgVVQvgyftJbHuueHwW7WmCLo0V26xm/aBpYUjrZr2IeD9HN5ZgTiUoxNbE/j+rHWeapt4LKu3 jXAAM72CBcZcXpowA1mfVnXtHjaEWGCGGWIIP3+d5w1Dj1tX9k6wCLWANFoylf8Is8dJdAZI1DkyG AIF1rnQWSB/TKoaVQNBaladjvFIcgmu+Swd5TeOFPM2cKcUiQWYj41HTAmdkUNz+UeOx7qZxojCs5 UedzXiMArJiKxSoq/BkXuUzmwP8HII1fFEKmh4SNGDFd7oIwCnM6oORt43Z81Uh9H27qvk/D+gSpu /iDg8OfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1shtTH-00000002WQ0-3pis; Sat, 24 Aug 2024 16:18:35 +0000 Received: from mail-lj1-x22f.google.com ([2a00:1450:4864:20::22f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1shtSW-00000002WKc-066I for linux-arm-kernel@lists.infradead.org; Sat, 24 Aug 2024 16:17:49 +0000 Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2f3f25a1713so32778911fa.2 for ; Sat, 24 Aug 2024 09:17:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1724516266; x=1725121066; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tLewfIc0V1606kS8OnVX5wewyAHhmWACUF+UrTlyhhY=; b=gtcsAcQzkWxNVcMQPuizmgSWyYCeN2P5ms02n7uGPmw1VpaHceo/pk7f77basfnUvl AUzO4ekRZWYh8CHCnMd/xvuXIYgJfzt7Xiw/+L8MM8OusiyqYaDqXxA5W+JgddyX8rKH Es/7GX6+/q7z7EvObTOKIFhbJC//mI4nJ1zFbKE114u5xGzo4I/iFwhkHfq7wrFUUDrO qaE+6LIc37PbX4+XvnO4S0YxLHFjaTYolqbbk10lDy/2jD07e6d1L1PNxYXvwmDX+SvL GOKOJhJagDu0CF5wXWdZUXC2l0NonK4XuC1IzisuG4lGSVRLVFsks2QOKgM00OyutJPV I0Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724516266; x=1725121066; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tLewfIc0V1606kS8OnVX5wewyAHhmWACUF+UrTlyhhY=; b=AkidRXjMxWy+2q5hnLxy9HvSIXjR0VLunzxgdjdVjFYN8pU5xq0X1x3jhrjoH9z2i3 0YTVvsE89LuP8S5ErQfqm2bG/3WFjKeArua2GewiJloQ0OZqhBnuTRAvnRaYHKAs0fLw hXW6q2Bmztx8eV1wor8OTLquNBpA0bU07wCpTzJwb3ooAmdRdFhR+7cZ4AGYMYRQ8Buz Obt8bUR5PUfbvX5TQPG08iW1uG2PHYCi/UMrg//2o2CwBNvv9TbkiK+cCexAvIePJCpl dC0SNPmRbgH4MmpMM4uShTAEd3WQmMnyrIihXrIVocUsn5syDPFEvfetzOtk22GpW0FO EF4w== X-Forwarded-Encrypted: i=1; AJvYcCWtD7jzD9D8LDE7FN1ycV1erWMhWlh26smodRYOQkXyeYeyrfk1G/3TyG0gTlAu13nI5goYygdGYNXjAy4dpiei@lists.infradead.org X-Gm-Message-State: AOJu0YwE9huIiPTyT+487eW4MZzZLkB+tZjtYCC2kEdWIbPEWAokSThh 7yUjALZJXiY1RLsfxoC98yWnCaZuLDtmNYIqJcXKFL1WTzICzvv+VBttZvqoMzk= X-Google-Smtp-Source: AGHT+IG1B8GIfumzhHnj7hWtGm9Ri19lD7phgp+y6ayI6ebhTTQom/sBEbyQQqKIe7quJGIBo5VwAg== X-Received: by 2002:a05:651c:1548:b0:2ef:268a:a194 with SMTP id 38308e7fff4ca-2f4f48d6dedmr44127171fa.9.1724516265407; Sat, 24 Aug 2024 09:17:45 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.94]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c04a4c43e7sm3499608a12.70.2024.08.24.09.17.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 24 Aug 2024 09:17:44 -0700 (PDT) Message-ID: <717bd06f-3eba-4825-a53f-b2f9aa1c81c8@tuxon.dev> Date: Sat, 24 Aug 2024 19:17:43 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 00/12] Microchip OTPC driver on SAM9X60 exposing UIDxR as additional nvmem device Content-Language: en-US To: Alexander Dahl , Nicolas Ferre Cc: Christian Melki , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org References: <20240821105943.230281-1-ada@thorsis.com> From: claudiu beznea In-Reply-To: <20240821105943.230281-1-ada@thorsis.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240824_091748_094774_B94F67CA X-CRM114-Status: GOOD ( 39.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Alexander, On 21.08.2024 13:59, Alexander Dahl wrote: > Hei hei, > > on a custom sam9x60 based board we want to access a unique ID of the > SoC. Microchip sam-ba has a command 'readuniqueid' which returns the > content of the OTPC Product UID x Register in that case. > > (On different boards with a SAMA5D2 we use the Serial Number x Register > exposed through the atmel soc driver. Those registers are not present > in the SAM9X60 series, but only for SAMA5D2/SAMA5D4 AFAIK.) Not sure if you are talking about Chip ID, Chip ID extension registers. These are available also on SAM9X60. > > There is a driver for the OTPC of the SAMA7G5 and after comparing > register layouts it seems that one is almost identical to the one used > by SAM9X60. Currently that driver has no support for the UIDx > registers, but I suppose it would be the right place to implement it, > because the registers are within the OTPC register address offsets. > > The patch series starts with fixups for the current driver. It then > adds the necessary pieces to DT and driver to work on SAM9X60 in > general. Later support for enabling the main RC oscillator is added, > which is required on SAM9X60 for the OTPC to work. The last patch adds > an additional nvmem device for the UIDx registers. > > This v1 of the series was _not_ tested on SAMA7G5, because I don't have > such a board for testing. Actually I don't know if the main_rc_osc > clock is required on SAMA7G5 too, and if yes how to handle that with > regard to the different clock ids. If someone could test on SAMA7G5 > and/or help me sorting out the core clock id things, that would be > highly appreciated. Please add Nicolas in the loop on the next revisions of this series as this should also be tested on SAMA7G5. I don't have a SAMA7G5 with OTP memory populated. > > Also I assume some more devicetree and/or sysfs documentation is > necessary. If someone could point me what's exactly required, this > would be very helpful for me. You see I expect at least another version > v2 of the series. ;-) > > Maybe some files having that "sama7g5" should be renamed, because that > DT binding is used for more SoCs now and deserves a more generic name? Not needed, adding your compatible there is enough. > Thinking of these for example: > > - Documentation/devicetree/bindings/nvmem/microchip,sama7g5-otpc.yaml > - include/dt-bindings/nvmem/microchip,sama7g5-otpc.h > > Are there other SoCs than SAMA7G5 and SAM9X60 using the same OTPC? > > Last question: Should the UID be added to the device entropy pool with > add_device_randomness() as done in the SAMA5D2 sfr driver? > > I sent an RFC patch on this topic earlier this year, you'll find the > link below as a reference to the discussion. The patch itself was > trivial and not meant for applying as is anyways, so I decided to not > write a full changelog from RFC to v1. > > Last not least, special thanks to Christian Melki on IRC, who wrote and > tested parts of this, and was very kind and helpful in discussing the > topic several times in the past months. > > Christian, if you feel there's credit missing, just point me where to > add Co-developed-by and I'll happily do that for v2. > > Greets > Alex > > (series based on v6.11-rc4) > > Cc: linux-arm-kernel@lists.infradead.org > Cc: devicetree@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-clk@vger.kernel.org > Link: https://lore.kernel.org/all/20240412140802.1571935-2-ada@thorsis.com/ > > Alexander Dahl (12): > nvmem: microchip-otpc: Avoid writing a write-only register > nvmem: microchip-otpc: Fix swapped 'sleep' and 'timeout' parameters > dt-bindings: nvmem: microchip-otpc: Add compatible for SAM9X60 > nvmem: microchip-otpc: Add SAM9X60 support > ARM: dts: microchip: sam9x60: Add OTPC node > ARM: dts: microchip: sam9x60_curiosity: Enable OTP Controller > nvmem: microchip-otpc: Add missing register definitions > nvmem: microchip-otpc: Add warnings for bad OTPC conditions on probe > clk: at91: sam9x60: Allow enabling main_rc_osc through DT > ARM: dts: microchip: sam9x60: Add clock properties to OTPC > nvmem: microchip-otpc: Enable main RC oscillator clock > nvmem: microchip-otpc: Expose UID registers as 2nd nvmem device > > .../nvmem/microchip,sama7g5-otpc.yaml | 1 + > .../dts/microchip/at91-sam9x60_curiosity.dts | 4 + > arch/arm/boot/dts/microchip/sam9x60.dtsi | 10 +++ > drivers/clk/at91/sam9x60.c | 3 +- > drivers/nvmem/microchip-otpc.c | 86 ++++++++++++++++++- > include/dt-bindings/clock/at91.h | 1 + > 6 files changed, 100 insertions(+), 5 deletions(-) > > > base-commit: 47ac09b91befbb6a235ab620c32af719f8208399