From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C911C432BE for ; Wed, 1 Sep 2021 06:49:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3CEF76101A for ; Wed, 1 Sep 2021 06:49:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3CEF76101A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6QfIXi84mikVJoF0jHXUcm0L94FE0m8NCa1YtpimDFU=; b=NuzSQ072HwRl+S fs8kYZi1Nu23D95V4PA86WwX+kgnuLqNn0369BssLegxNrbna9/OsvDq8FQujWCMLpvckHIl4N6TW uqEBJKU3UEUr19QFTtWm99woEqquccTIk8eeqpsJrcdz34Bq0NOju8FoBBDYWpCYONc3YJewGyOa6 oqQszsVmPvELZTSuTIQw3QTw0h/cur1myXy6E0avLOMGxw3C+VJdCnguMo4r/76OxvwxOd+GMl8le y1buCpsDyQnB+W4xxwKj+5HoNUqtxlyK7Oxo9jUJ/PdIagESV6y/R5LUGsaGUvjnVpLw0poIhTie6 W780+lNYeygJFR/0H1qQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLK1N-004DMQ-2H; Wed, 01 Sep 2021 06:46:53 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLK1K-004DLq-6I for linux-arm-kernel@lists.infradead.org; Wed, 01 Sep 2021 06:46:51 +0000 Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mLK1B-00060n-Qe; Wed, 01 Sep 2021 08:46:41 +0200 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1mLK18-000317-F6; Wed, 01 Sep 2021 08:46:38 +0200 Message-ID: <718b22d5ca0f8afa2f2815287e7aa13d34d9b0ec.camel@pengutronix.de> Subject: Re: [PATCH] media: imx-pxp: Make use of the helper function devm_platform_ioremap_resource() From: Philipp Zabel To: Cai Huoqing Cc: Mauro Carvalho Chehab , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Wed, 01 Sep 2021 08:46:38 +0200 In-Reply-To: <20210901055147.6779-1-caihuoqing@baidu.com> References: <20210901055147.6779-1-caihuoqing@baidu.com> User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210831_234650_256981_BB1AA71F X-CRM114-Status: GOOD ( 17.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2021-09-01 at 13:51 +0800, Cai Huoqing wrote: > Use the devm_platform_ioremap_resource() helper instead of > calling platform_get_resource() and devm_ioremap_resource() > separately > > Signed-off-by: Cai Huoqing > --- > drivers/media/platform/imx-pxp.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/media/platform/imx-pxp.c b/drivers/media/platform/imx-pxp.c > index 4321edc0c23d..723b096fedd1 100644 > --- a/drivers/media/platform/imx-pxp.c > +++ b/drivers/media/platform/imx-pxp.c > @@ -1636,7 +1636,6 @@ static int pxp_soft_reset(struct pxp_dev *dev) > static int pxp_probe(struct platform_device *pdev) > { > struct pxp_dev *dev; > - struct resource *res; > struct video_device *vfd; > int irq; > int ret; > @@ -1652,8 +1651,7 @@ static int pxp_probe(struct platform_device *pdev) > return ret; > } > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - dev->mmio = devm_ioremap_resource(&pdev->dev, res); > + dev->mmio = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(dev->mmio)) > return PTR_ERR(dev->mmio); Reviewed-by: Philipp Zabel regards Philipp _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel