From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5EFF8C77B61 for ; Thu, 13 Apr 2023 14:38:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RRZGNZ0Ha4arB0OywzueKlP2OZq1ciBc+ND8LZvjYeI=; b=WWkVfb2ETSk8DT 4KBwjqHwTHm/SUAvB2Ben/79QtkXjy9LG+LslqqrTDgsVcq8TtMPpqrs8E629nWmqHaOXTBSFo7FT MbayYX6QxwMzDSWnXup0CKxRXa3Xj+1N1qHKV8070y9dQOwmMY3EOWxAo9PZE2DTtByudvhlAu9q+ 3jUgtyhE1aL7ZXtuOXM4u9dHxuUnTAnKDvcE2Q280rwmxsNDCa2NvDQ8Q+anBYe3y9LMYL5V+WTNL MedpGP/FbQXuvdx/sn+TIlCZZ0apN2MbGhWQ5W2aWIjJDX7qDiqnwmit2FDIBgiOcHPzshu8G6L7J eff3oMniX3VZiz9347wQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmy4r-006Pow-1m; Thu, 13 Apr 2023 14:37:33 +0000 Received: from gnu.wildebeest.org ([45.83.234.184]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmy4n-006PmK-0m for linux-arm-kernel@lists.infradead.org; Thu, 13 Apr 2023 14:37:31 +0000 Received: from r6.localdomain (82-217-174-174.cable.dynamic.v4.ziggo.nl [82.217.174.174]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 7C8A2302BB02; Thu, 13 Apr 2023 16:37:14 +0200 (CEST) Received: by r6.localdomain (Postfix, from userid 1000) id 2A6AB34014C; Thu, 13 Apr 2023 16:37:14 +0200 (CEST) Message-ID: <718c102205750a00b86e8d33748e9bfb3c485ee1.camel@klomp.org> Subject: Re: [PATCH v5 1/2] check-uapi: Introduce check-uapi.sh From: Mark Wielaard To: John Moon , Greg Kroah-Hartman Cc: Masahiro Yamada , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Randy Dunlap , Arnd Bergmann , Bjorn Andersson , Todd Kjos , Matthias Maennich , Giuliano Procida , kernel-team@android.com, libabigail@sourceware.org, Jordan Crouse , Trilok Soni , Satya Durga Srinivasu Prabhala , Elliot Berman , Guru Das Srinagesh Date: Thu, 13 Apr 2023 16:37:14 +0200 In-Reply-To: References: <20230407203456.27141-1-quic_johmoo@quicinc.com> <20230407203456.27141-2-quic_johmoo@quicinc.com> <2023041015-lunar-dandelion-1b4e@gregkh> <2023041136-donator-faceplate-5f91@gregkh> <2023041209-armed-overlaid-3d3d@gregkh> User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230413_073729_454466_3F0DB8F9 X-CRM114-Status: GOOD ( 21.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Wed, 2023-04-12 at 09:37 -0700, John Moon via Libabigail wrote: > On 4/11/2023 11:14 PM, Greg Kroah-Hartman wrote: > > > Would you find the tool more useful if it simply filtered out all instances > > > where the size of the type did not change? This would filter out the > > > following which the tool currently flags: > > > > > > - enum expansions > > > - reserved field expansions > > > - expansions of a struct with a flex array at the end > > > - type changes > > > - re-ordering of existing members > > > - ...others? > > > > Obviously not, as some of those are real breakages, and some are not at > > all. > > > > Please understand what is an abi breakage. Adding new enums is not. > > Using a reserved field is not. Reording existing members IS. > > > > Yes, understood that method would miss certain classes of breakages. I > was suggesting it as a way to improve the signal-to-noise ratio of the > tool since we don't currently have an algorithm for determining > breakages with 100% accuracy. Note that you can check the exit code of libabigail's abidiff to see whether something is an incompatible abi change or not, see: https://sourceware.org/libabigail/manual/abidiff.html#return-values You can also of course use suppressions to instruct abidiff to avoid reporting changes involving certain ABI artifacts: https://sourceware.org/libabigail/manual/libabigail-concepts.html#suppr-spec-label Cheers, Mark _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel