From: Stefan Wahren <stefan.wahren@i2se.com>
To: kernel@martin.sperl.org
Cc: linux-spi@vger.kernel.org, Eric Anholt <eric@anholt.net>,
Mark Brown <broonie@kernel.org>,
linux-rpi-kernel@lists.infradead.org,
Hubert Denkmair <h.denkmair@intence.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2 8/9] spi: bcm2835aux: add driver stats to debugfs
Date: Mon, 25 Mar 2019 11:06:56 +0100 [thread overview]
Message-ID: <719f7607-4941-04d3-c05a-c9797cccc8ec@i2se.com> (raw)
In-Reply-To: <5AE813DD-9A2F-453D-B334-997FCEF72C31@martin.sperl.org>
Am 25.03.19 um 10:52 schrieb kernel@martin.sperl.org:
>> On 25.03.2019, at 10:28, Stefan Wahren <stefan.wahren@i2se.com> wrote:
>>
>> Hi Martin,
>>
>> Am 24.03.19 um 18:50 schrieb kernel@martin.sperl.org:
>>> +
>>> +#if defined(CONFIG_DEBUG_FS)
>>> +#define BCM2835_AUX_INCR(field) ((field)++)
>>> + u64 count_transfer_polling;
>>> + u64 count_transfer_irq;
>>> + u64 count_transfer_irq_after_poll;
>>> +
>>> + struct dentry *debugfs_dir;
>>> +#else
>>> +#define BCM2835_AUX_INCR(field)
>>> +#endif /* CONFIG_DEBUG_FS */
>>> };
>>>
>> is there a chance to avoid these ifdefs CONFIG_DEBUG_FS?
>>
> The idea was not to add those stats at all when debugfs is disabled.
> Other groups (e.g net/can) prefer it this way…
Yes, this is always a balance between size reduction and code readability.
My biggest concern was about BCM2835_AUX_INCR
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-25 10:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-24 17:49 [PATCH V2 0/9] spi: bcm2835aux: bug fixes and improvements kernel
2019-03-24 17:49 ` [PATCH V2 1/9] spi: bcm2835aux: unifying code between polling and interrupt driven code kernel
2019-03-24 17:49 ` [PATCH V2 2/9] spi: bcm2835aux: remove dangerous uncontrolled read of fifo kernel
2019-03-24 17:49 ` [PATCH V2 3/9] spi: bcm2835aux: use BCM2835_AUX_SPI_STAT_RX_LVL kernel
2019-03-25 9:52 ` Stefan Wahren
2019-03-24 17:49 ` [PATCH V2 4/9] spi: bcm2835aux: remove dead code kernel
2019-03-24 17:49 ` [PATCH V2 5/9] spi: bcm2835aux: fix driver to not allow 65535 (=-1) cs-gpios kernel
2019-03-24 17:49 ` [PATCH V2 6/9] spi: bcm2835aux: warn in dmesg that native cs is not really supported kernel
2019-03-25 10:28 ` Stefan Wahren
2019-03-24 17:50 ` [PATCH V2 7/9] spi: bcm2835aux: setup gpio-cs to output and correct level during setup kernel
2019-03-24 17:50 ` [PATCH V2 8/9] spi: bcm2835aux: add driver stats to debugfs kernel
2019-03-25 9:28 ` Stefan Wahren
2019-03-25 9:52 ` kernel
2019-03-25 10:06 ` Stefan Wahren [this message]
2019-03-25 10:11 ` kernel
2019-03-25 10:45 ` Stefan Wahren
2019-03-24 17:50 ` [PATCH V2 9/9] spi: bcm2835aux: make the polling duration limits configurable kernel
2019-03-25 9:44 ` Stefan Wahren
2019-03-25 9:49 ` kernel
2019-03-25 9:59 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=719f7607-4941-04d3-c05a-c9797cccc8ec@i2se.com \
--to=stefan.wahren@i2se.com \
--cc=broonie@kernel.org \
--cc=eric@anholt.net \
--cc=h.denkmair@intence.de \
--cc=kernel@martin.sperl.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox