From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Ulf Hansson <ulf.hansson@linaro.org>,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>
Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
linux-mips@vger.kernel.org, linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH v2 05/17] pmdomain: bcm: Move Kconfig options to the pmdomain subsystem
Date: Fri, 15 Sep 2023 09:30:58 -0700 [thread overview]
Message-ID: <71ab660c-bee3-038f-665c-cda04f18cf6d@broadcom.com> (raw)
In-Reply-To: <20230915092003.658361-6-ulf.hansson@linaro.org>
[-- Attachment #1.1: Type: text/plain, Size: 3143 bytes --]
On 9/15/23 02:19, Ulf Hansson wrote:
> The Kconfig options belongs closer to the corresponding implementations,
> hence let's move them from the soc subsystem to the pmdomain subsystem.
>
> Cc: Florian Fainelli <florian.fainelli@broadcom.com>
> Cc: Ray Jui <rjui@broadcom.com>
> Cc: Scott Branden <sbranden@broadcom.com>
> Cc: <linux-mips@vger.kernel.org>
> Cc: <linux-rpi-kernel@lists.infradead.org>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
> drivers/pmdomain/Kconfig | 1 +
> drivers/pmdomain/bcm/Kconfig | 46 ++++++++++++++++++++++++++++++++++++
> drivers/soc/bcm/Kconfig | 42 --------------------------------
> 3 files changed, 47 insertions(+), 42 deletions(-)
> create mode 100644 drivers/pmdomain/bcm/Kconfig
>
> diff --git a/drivers/pmdomain/Kconfig b/drivers/pmdomain/Kconfig
> index 482d9e970e14..ddc05d6af100 100644
> --- a/drivers/pmdomain/Kconfig
> +++ b/drivers/pmdomain/Kconfig
> @@ -4,5 +4,6 @@ menu "PM Domains"
> source "drivers/pmdomain/actions/Kconfig"
> source "drivers/pmdomain/amlogic/Kconfig"
> source "drivers/pmdomain/apple/Kconfig"
> +source "drivers/pmdomain/bcm/Kconfig"
>
> endmenu
> diff --git a/drivers/pmdomain/bcm/Kconfig b/drivers/pmdomain/bcm/Kconfig
> new file mode 100644
> index 000000000000..9311e90b7707
> --- /dev/null
> +++ b/drivers/pmdomain/bcm/Kconfig
> @@ -0,0 +1,46 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +menu "Broadcom PM Domains"
> +
> +config BCM2835_POWER
> + bool "BCM2835 power domain driver"
> + depends on ARCH_BCM2835 || (COMPILE_TEST && OF)
> + default y if ARCH_BCM2835
> + select PM_GENERIC_DOMAINS if PM
> + select RESET_CONTROLLER
> + help
> + This enables support for the BCM2835 power domains and reset
> + controller. Any usage of power domains by the Raspberry Pi
> + firmware means that Linux usage of the same power domain
> + must be accessed using the RASPBERRYPI_POWER driver
> +
> +config RASPBERRYPI_POWER
> + bool "Raspberry Pi power domain driver"
> + depends on ARCH_BCM2835 || (COMPILE_TEST && OF)
> + depends on RASPBERRYPI_FIRMWARE=y
> + select PM_GENERIC_DOMAINS if PM
> + help
> + This enables support for the RPi power domains which can be enabled
> + or disabled via the RPi firmware.
> +
> +config BCM_PMB
> + bool "Broadcom PMB (Power Management Bus) driver"
> + depends on ARCH_BCMBCA || (COMPILE_TEST && OF)
> + default ARCH_BCMBCA
> + select PM_GENERIC_DOMAINS if PM
> + help
> + This enables support for the Broadcom's PMB (Power Management Bus) that
> + is used for disabling and enabling SoC devices.
> +
> +if SOC_BCM63XX
> +
> +config BCM63XX_POWER
> + bool "BCM63xx power domain driver"
> + depends on BMIPS_GENERIC || (COMPILE_TEST && OF)
> + select PM_GENERIC_DOMAINS if PM
> + help
> + This enables support for the BCM63xx power domains controller on
> + BCM6318, BCM6328, BCM6362 and BCM63268 SoCs.
> +
> +endif # SOC_BCM63XX
That is confusing, SOC_BCM63XX remains defined in
drivers/soc/bcm/Kconfig, but we now made BCM63XX_POWER's visibility
conditional upon a Kconfig symbol defined elsewhere, I would just drop
the "if" condition completely.
--
Florian
[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-15 16:31 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 9:19 [PATCH v2 00/17] pmdomain: Move Kconfig options/files to the pmdomain subsystem Ulf Hansson
2023-09-15 9:19 ` [PATCH v2 01/17] pmdomain: Prepare to move Kconfig files into " Ulf Hansson
2023-09-15 10:07 ` Geert Uytterhoeven
2023-09-15 9:19 ` [PATCH v2 02/17] pmdomain: actions: Move Kconfig file to " Ulf Hansson
2023-09-15 9:19 ` [PATCH v2 03/17] pmdomain: amlogic: Move Kconfig options " Ulf Hansson
2023-09-15 9:19 ` [PATCH v2 04/17] pmdomain: apple: Move Kconfig option " Ulf Hansson
2023-09-15 9:45 ` Eric Curtin
2023-09-15 11:46 ` Ulf Hansson
2023-09-15 10:21 ` Neal Gompa
2023-09-15 9:19 ` [PATCH v2 05/17] pmdomain: bcm: Move Kconfig options " Ulf Hansson
2023-09-15 13:15 ` Philippe Mathieu-Daudé
2023-09-15 16:30 ` Florian Fainelli [this message]
2023-09-15 9:19 ` [PATCH v2 06/17] pmdomain: imx: " Ulf Hansson
2023-09-17 23:07 ` Peng Fan
2023-09-15 9:19 ` [PATCH v2 07/17] pmdomain: mediatek: " Ulf Hansson
2023-09-15 9:19 ` [PATCH v2 08/17] pmdomain: qcom: " Ulf Hansson
2023-09-15 9:19 ` [PATCH v2 09/17] pmdomain: renesas: " Ulf Hansson
2023-09-15 9:19 ` [PATCH v2 10/17] pmdomain: rockchip: Move Kconfig option " Ulf Hansson
2023-09-15 9:19 ` [PATCH v2 11/17] pmdomain: samsung: " Ulf Hansson
2023-09-15 9:19 ` [PATCH v2 12/17] pmdomain: st: Add a Kconfig option for the ux500 power domain Ulf Hansson
2023-09-15 9:19 ` [PATCH v2 13/17] pmdomain: starfive: Move Kconfig file to the pmdomain subsystem Ulf Hansson
2023-09-15 9:29 ` Conor Dooley
2023-09-15 11:42 ` Ulf Hansson
2023-09-15 9:20 ` [PATCH v2 14/17] pmdomain: sunxi: Move Kconfig option " Ulf Hansson
2023-09-15 9:20 ` [PATCH v2 15/17] pmdomain: tegra: " Ulf Hansson
2023-09-15 9:20 ` [PATCH v2 16/17] pmdomain: ti: Move and add Kconfig options " Ulf Hansson
2023-09-19 9:09 ` Dhruva Gole
2023-09-15 9:20 ` [PATCH v2 17/17] pmdomain: xilinx: Move Kconfig option " Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71ab660c-bee3-038f-665c-cda04f18cf6d@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=olof@lixom.net \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).