From: Sascha Bischoff <sascha.bischoff@arm.com>
To: Lorenzo Pieralisi <lpieralisi@kernel.org>
Cc: Marc Zyngier <maz@kernel.org>, Thomas Gleixner <tglx@kernel.org>,
Radu Rendec <radu@rendec.net>,
Timothy Hayes <Timothy.Hayes@arm.com>,
Catalin Marinas <Catalin.Marinas@arm.com>,
Jonathan Cameron <jic23@kernel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH v2 03/10] irqchip/gic-v5: Serialise IRS synchronisation requests
Date: Wed, 18 Nov 2026 15:34:48 +0000 [thread overview]
Message-ID: <71b9323b-902f-4bf9-9cbf-6d0d90ee7ca0@arm.com> (raw)
In-Reply-To: <auw0ulR3wrsKVcYe@red-moon>
On 05/11/2026 07:48, Lorenzo Pieralisi wrote:
> [Remove stable from the CC email recipient list, leave it only in the log]
Noted, and thanks. Hadn't caught that had been added in from CC. Will
omit henceforth!
>
> On Wed, Nov 04, 2026 at 05:47:57PM +0000, Sascha Bischoff wrote:
>> IRS_SYNCR writes are ignored while IRS_SYNC_STATUSR.IDLE is clear.
>> Calls to gicv5_irs_syncr() for different IRQs can overlap, allowing
>
> Nit: gicv5_irs_syncr() has no notion of specific IRQs, this is
> misleading.
>
>> the second request to be dropped. Its caller can then observe the
>> first request completing and assume that its own events have been
>> processed.
>>
>> With GICv5 ITS KVM support, gicv5_irs_syncr() is also called while
>> restoring the host ITTE in gicv5_its_set_vcpu_affinity(). The callback
>> runs under the IRQ descriptor lock via irq_set_vcpu_affinity(), so it
>> cannot sleep.
>
> Technically we are talking about a use case that does not exist yet.
>
> I understand it is churn to fix it first and change it again later,
> I would just say that gicv5_irs_syncr() might need to be called in atomic
> context.
I've reworked this commit message to make it clearer.
Thanks,
Sascha
>
>> Serialise the request and completion poll with a raw spinlock, and use
>> atomic polling because the synchronisation runs while holding the IRQ
>> descriptor lock.
>>
>> Fixes: 57d72196dfc8 ("irqchip/gic-v5: Add GICv5 ITS support")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Sascha Bischoff <sascha.bischoff@arm.com>
>> ---
>> drivers/irqchip/irq-gic-v5-irs.c | 8 ++++++--
>> 1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/irqchip/irq-gic-v5-irs.c b/drivers/irqchip/irq-gic-v5-irs.c
>> index 4edf787f3f97f..ead76560ea08f 100644
>> --- a/drivers/irqchip/irq-gic-v5-irs.c
>> +++ b/drivers/irqchip/irq-gic-v5-irs.c
>> @@ -10,6 +10,7 @@
>> #include <linux/log2.h>
>> #include <linux/of.h>
>> #include <linux/of_address.h>
>> +#include <linux/spinlock.h>
>>
>> #include <linux/irqchip.h>
>> #include <linux/irqchip/arm-gic-v5.h>
>> @@ -22,6 +23,8 @@
>> #define LPI_ID_BITS_LINEAR 12
>>
>> static DEFINE_PER_CPU_READ_MOSTLY(struct gicv5_irs_chip_data *, per_cpu_irs_data);
>> +/* Synchronization requests must not overlap in an IRS Domain. */
>> +static DEFINE_RAW_SPINLOCK(irs_sync_lock);
>> static LIST_HEAD(irs_nodes);
>>
>> static u32 irs_readl_relaxed(struct gicv5_irs_chip_data *irs_data,
>> @@ -507,10 +510,11 @@ void gicv5_irs_syncr(void)
>> return;
>>
>> syncr = FIELD_PREP(GICV5_IRS_SYNCR_SYNC, 1);
>> + guard(raw_spinlock_irqsave)(&irs_sync_lock);
>> irs_writel_relaxed(irs_data, syncr, GICV5_IRS_SYNCR);
>>
>> - gicv5_wait_for_op(irs_data->irs_base, GICV5_IRS_SYNC_STATUSR,
>> - GICV5_IRS_SYNC_STATUSR_IDLE);
>> + gicv5_wait_for_op_atomic(irs_data->irs_base, GICV5_IRS_SYNC_STATUSR,
>> + GICV5_IRS_SYNC_STATUSR_IDLE, NULL);
>> }
>
> Acked-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
>
>>
>> int gicv5_irs_register_cpu(int cpuid)
>>
>> --
>> 2.34.1
>>
next prev parent reply other threads:[~2026-11-18 15:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 17:47 [PATCH v2 00/10] irqchip/gic-v5: Fix misc IRS and ITS host driver issues Sascha Bischoff
2026-11-04 17:47 ` [PATCH v2 01/10] irqchip/gic-v5: Reject SPIs not backed by an IRS Sascha Bischoff
2026-11-05 7:35 ` Lorenzo Pieralisi
2026-11-18 15:32 ` Sascha Bischoff
2026-11-04 17:47 ` [PATCH v2 02/10] irqchip/gic-v5: Only set IRS DPS when 1ofN routing is supported Sascha Bischoff
2026-11-04 17:47 ` [PATCH v2 03/10] irqchip/gic-v5: Serialise IRS synchronisation requests Sascha Bischoff
2026-11-05 7:48 ` Lorenzo Pieralisi
2026-11-18 15:34 ` Sascha Bischoff [this message]
2026-11-04 17:47 ` [PATCH v2 04/10] irqchip/gic-v5: Serialise ITS invalidation commands Sascha Bischoff
2026-11-05 8:31 ` Lorenzo Pieralisi
2026-11-18 15:39 ` Sascha Bischoff
2026-11-04 17:47 ` [PATCH v2 05/10] irqchip/gic-v5: Use linear DT and ITT when L2 covers all IDs Sascha Bischoff
2026-11-04 17:48 ` [PATCH v2 06/10] irqchip/gic-v5: Honour ACPI ITS noncoherent flag Sascha Bischoff
2026-11-04 17:48 ` [PATCH v2 07/10] irqchip/gic-v5: Use firmware node name in ITS warning Sascha Bischoff
2026-11-04 17:48 ` [PATCH v2 08/10] irqchip/gic-v5: Invalidate ITS device cache before freeing ITT Sascha Bischoff
2026-11-04 17:48 ` [PATCH v2 09/10] irqchip/gic-v5: Clean the allocated linear device table size Sascha Bischoff
2026-11-05 7:37 ` Lorenzo Pieralisi
2026-11-04 17:48 ` [PATCH v2 10/10] irqchip/gic-v5: Release ITS MMIO region on DT probe failure Sascha Bischoff
2026-11-12 14:58 ` [PATCH v2 00/10] irqchip/gic-v5: Fix misc IRS and ITS host driver issues Fuad Tabba
2026-11-16 12:14 ` Lorenzo Pieralisi
2026-11-16 13:28 ` Fuad Tabba
2026-11-16 14:06 ` Lorenzo Pieralisi
2026-11-18 14:58 ` Sascha Bischoff
2026-11-18 15:16 ` Fuad Tabba
2026-11-18 15:20 ` Sascha Bischoff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71b9323b-902f-4bf9-9cbf-6d0d90ee7ca0@arm.com \
--to=sascha.bischoff@arm.com \
--cc=Catalin.Marinas@arm.com \
--cc=Timothy.Hayes@arm.com \
--cc=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=maz@kernel.org \
--cc=radu@rendec.net \
--cc=rafael.j.wysocki@intel.com \
--cc=stable@vger.kernel.org \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox